Attention is currently required from: Martin Roth, Jeremy Soller, Paul Menzel, Angel Pons.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47822 )
Change subject: mb/system76/gaze15: Add System76 Gazelle 15
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/system76/gaze15/gpio.c:
https://review.coreboot.org/c/coreboot/+/47822/comment/680efd8c_c86aa24e
PS8, Line 98: //
I simply booted the board without any GPIO config and then checked against vendor firmware values an […]
This is taking me a while to do, since I don't know what changes are significant between the vendor firmware, leaving them unset, and what we set. Almost every GPIO is configured differently in vendor firmware. If I'm parsing it right, vendor firmware configures IOSTERM, but IOSTANDBY isn't enabled on CML.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10667fa26ac7c4b8eb67da11f3e963062bd0db47
Gerrit-Change-Number: 47822
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 03 Mar 2021 15:11:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford
tcrawford@system76.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment