HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41764 )
Change subject: Makefile.inc: Remove '-Wstrict-aliasing' ......................................................................
Makefile.inc: Remove '-Wstrict-aliasing'
'-Wstrict-aliasing' warning flag is already turned on with '-Wall'.
Change-Id: I8212cfa5d67fba854ee84dd9d560cd7f8a27632e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/41764/1
diff --git a/Makefile.inc b/Makefile.inc index 210e9cf..c401b54 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -407,7 +407,7 @@ CFLAGS_common += -pipe -g -nostdinc -std=gnu11 CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough -CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time -Wtype-limits -Wvla +CFLAGS_common += -Wshadow -Wdate-time -Wtype-limits -Wvla CFLAGS_common += -Wlogical-op -Wduplicated-cond -Wdangling-else CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41764 )
Change subject: Makefile.inc: Remove '-Wstrict-aliasing' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41764/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41764/1//COMMIT_MSG@9 PS1, Line 9: '-Wstrict-aliasing' warning flag is already turned on with '-Wall'. Does that depend on the compiler (gcc, clang) and version, what is enabled with `-Wall`?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41764 )
Change subject: Makefile.inc: Remove '-Wstrict-aliasing' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41764/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41764/1//COMMIT_MSG@9 PS1, Line 9: '-Wstrict-aliasing' warning flag is already turned on with '-Wall'.
Does that depend on the compiler (gcc, clang) and version, what is enabled with `-Wall`?
coreboot will not support clang I think, isn't it? I'll check if Will turns on 'Wstrict-aliasing' also.
For gcc, Wstrict-aliasing is enabled by -Wall
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41764 )
Change subject: Makefile.inc: Remove '-Wstrict-aliasing' ......................................................................
Patch Set 1:
(1 comment)
Thank you
https://review.coreboot.org/c/coreboot/+/41764/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41764/1//COMMIT_MSG@9 PS1, Line 9: '-Wstrict-aliasing' warning flag is already turned on with '-Wall'.
coreboot will not support clang I think, isn't it? […]
Wstrict-aliasing has no effect in Clang https://clang.llvm.org/docs/DiagnosticsReference.html#wstrict-aliasing
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41764 )
Change subject: Makefile.inc: Remove '-Wstrict-aliasing' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41764/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41764/1//COMMIT_MSG@9 PS1, Line 9: '-Wstrict-aliasing' warning flag is already turned on with '-Wall'.
Wstrict-aliasing has no effect in Clang […]
Done
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41764 )
Change subject: Makefile.inc: Remove '-Wstrict-aliasing' ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Paul Menzel (Code Review)