HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43280 )
Change subject: [test] extent of damage ......................................................................
[test] extent of damage
Change-Id: I38bf5a33f989c99e3fe720df93cc4741aa4df732 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/43280/1
diff --git a/Makefile.inc b/Makefile.inc index 89bb3e4..428ca35 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -255,20 +255,20 @@ # possibly true in many cases. In other cases it seems that an empty # ResourceTemplate is the correct code. # As it's valid ASL, disable the warning. -EMPTY_RESOURCE_TEMPLATE_WARNING = 3150 +# EMPTY_RESOURCE_TEMPLATE_WARNING = 3150 # Redundant offset remarks are not useful in any way and are masking useful # ones that might indicate an issue so it is better to hide them. -REDUNDANT_OFFSET_REMARK = 2158 +# REDUNDANT_OFFSET_REMARK = 2158 # Ignore _HID & _ADR coexisting in Intel Lynxpoint and Broadwell ASL code. # See cb:38803 & cb:38802 # "Multiple types (Device object requires either a _HID or _ADR, but not both)" -MULTIPLE_TYPES_WARNING = 3073 +# MULTIPLE_TYPES_WARNING = 3073
-ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_LYNXPOINT)$(CONFIG_SOC_INTEL_BROADWELL),y) -IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK) -vw $(MULTIPLE_TYPES_WARNING) -else -IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK) -endif +#ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_LYNXPOINT)$(CONFIG_SOC_INTEL_BROADWELL),y) +#IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK) -vw $(MULTIPLE_TYPES_WARNING) +#else +#IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK) +#endif
define asl_template $(CONFIG_CBFS_PREFIX)/$(1).aml-file = $(obj)/$(1).aml
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43280
to look at the new patch set (#2).
Change subject: [test] remove EMPTY_RESOURCE_TEMPLATE_WARNING ......................................................................
[test] remove EMPTY_RESOURCE_TEMPLATE_WARNING
Change-Id: I38bf5a33f989c99e3fe720df93cc4741aa4df732 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/43280/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43280
to look at the new patch set (#3).
Change subject: [test] remove EMPTY_RESOURCE_TEMPLATE_WARNING ......................................................................
[test] remove EMPTY_RESOURCE_TEMPLATE_WARNING
Change-Id: I38bf5a33f989c99e3fe720df93cc4741aa4df732 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/43280/3
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43280
to look at the new patch set (#4).
Change subject: [test] enable REDUNDANT_OFFSET_REMARK ......................................................................
[test] enable REDUNDANT_OFFSET_REMARK
Change-Id: I38bf5a33f989c99e3fe720df93cc4741aa4df732 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/43280/4
Patrick Georgi has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/43280 )
Change subject: [test] enable REDUNDANT_OFFSET_REMARK ......................................................................
Removed reviewer Martin Roth.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43280 )
Change subject: [test] enable REDUNDANT_OFFSET_REMARK ......................................................................
Patch Set 4:
(1 comment)
a
https://review.coreboot.org/c/coreboot/+/43280/4/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43280/4/Makefile.inc@259 PS4, Line 259: Redundant offset remarks are not useful in any way and are masking useful : # ones that might indicate an issue so it is better to hide them. Oh look, we have a reason to keep this warning disabled
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43280 )
Change subject: [test] enable REDUNDANT_OFFSET_REMARK ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43280/4/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43280/4/Makefile.inc@259 PS4, Line 259: Redundant offset remarks are not useful in any way and are masking useful : # ones that might indicate an issue so it is better to hide them.
Oh look, we have a reason to keep this warning disabled
hiding a problem doesn't mean problem solved :)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43280 )
Change subject: [test] enable REDUNDANT_OFFSET_REMARK ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43280/4/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43280/4/Makefile.inc@259 PS4, Line 259: Redundant offset remarks are not useful in any way and are masking useful : # ones that might indicate an issue so it is better to hide them.
hiding a problem doesn't mean problem solved :)
changes for version 20180927: "iASL: Implemented detection of extraneous/redundant uses of the Offset() operator within a Field Unit list. A remark is now issued ...."
and here is the problem :
"Note, when optimization is enabled, the iASL compiler will in fact remove the redundant Offset operators and will not emit any AML code for them"
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43280 )
Change subject: [test] enable REDUNDANT_OFFSET_REMARK ......................................................................
Abandoned
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)