Attention is currently required from: Angel Pons. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55355 )
Change subject: soc/intel/elkhartlake: Enable PCH GBE ......................................................................
Patch Set 17:
(6 comments)
This change is ready for review.
File src/soc/intel/elkhartlake/acpi/pch_glan.asl:
PS10:
nit: I'd name this file `tsn_ethernet. […]
done.
File src/soc/intel/elkhartlake/chip.h:
https://review.coreboot.org/c/coreboot/+/55355/comment/ca6178da_c3b125f5 PS10, Line 26:
Here's what I would do to account for a future setting for PSE (part 1): […]
Done
https://review.coreboot.org/c/coreboot/+/55355/comment/7e9a71f2_27a2852a PS10, Line 384: /* TSN GBE Link Speed: 0: 2.5Gbps, 1: 1Gbps */ : enum { : Tsn_2_5_Gbps, : Tsn_1_Gbps, : } TsnGbeLinkSpeed; : /* PCH TSN GBE Link Speed: 0: 2.5Gbps, 1: 1Gbps */ : uint8_t PchTsnGbeLinkSpeed;
Here's what I would do to account for a future setting for PSE (part 2): […]
Done
File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55355/comment/e6646709_75350bf9 PS10, Line 339: Mhz
nit: MHz (there's multiple instances of this in this comment)
Done
https://review.coreboot.org/c/coreboot/+/55355/comment/a2308acf_5df2fa67 PS10, Line 355: dev_set_enabled(dev, 0);
Actually, I forgot that `is_dev_enabled` returns false if `dev` is NULL, which means `dev` could nev […]
Done
https://review.coreboot.org/c/coreboot/+/55355/comment/b0864e7a_8498c8ad PS10, Line 355: dev_set_enabled(dev, 0);
Actually, I forgot that `is_dev_enabled` returns false if `dev` is NULL, which means `dev` could nev […]
Done
-
Lean Sheng Tan (Code Review)