Attention is currently required from: Angel Pons.
6 comments:
File src/soc/intel/elkhartlake/acpi/pch_glan.asl:
nit: I'd name this file `tsn_ethernet. […]
done.
File src/soc/intel/elkhartlake/chip.h:
Here's what I would do to account for a future setting for PSE (part 1): […]
Done
/* TSN GBE Link Speed: 0: 2.5Gbps, 1: 1Gbps */
enum {
Tsn_2_5_Gbps,
Tsn_1_Gbps,
} TsnGbeLinkSpeed;
/* PCH TSN GBE Link Speed: 0: 2.5Gbps, 1: 1Gbps */
uint8_t PchTsnGbeLinkSpeed;
Here's what I would do to account for a future setting for PSE (part 2): […]
Done
File src/soc/intel/elkhartlake/fsp_params.c:
nit: MHz (there's multiple instances of this in this comment)
Done
Patch Set #10, Line 355: dev_set_enabled(dev, 0);
Actually, I forgot that `is_dev_enabled` returns false if `dev` is NULL, which means `dev` could nev […]
Done
Patch Set #10, Line 355: dev_set_enabled(dev, 0);
Actually, I forgot that `is_dev_enabled` returns false if `dev` is NULL, which means `dev` could nev […]
Done
To view, visit change 55355. To unsubscribe, or for help writing mail filters, visit settings.