Attention is currently required from: Jérémy Compostella, Nico Huber.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79905?usp=email )
Change subject: [RFC] region: Introduce region_create() functions
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
LGTM
File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/c/coreboot/+/79905/comment/736eed54_81f3e881 :
PS1, Line 99: assert(offset + size - 1 >= offset);
This would not allow empty regions. […]
I don't see the need for zero-size regions. I guess they could be used as a marker or something, but that seems outside of the intended region usage.
I think excluding them is totally reasonable.
But the assert, it does nothing...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79905?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ae3e6274c981c9ab4fb1263c2a72fa68ef1c32b
Gerrit-Change-Number: 79905
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Sun, 14 Jan 2024 02:33:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment