Attention is currently required from: Jérémy Compostella, Nico Huber.
Patch set 1:Code-Review +1
2 comments:
Patchset:
LGTM
File src/commonlib/include/commonlib/region.h:
Patch Set #1, Line 99: assert(offset + size - 1 >= offset);
This would not allow empty regions. […]
I don't see the need for zero-size regions. I guess they could be used as a marker or something, but that seems outside of the intended region usage.
I think excluding them is totally reasonable.
But the assert, it does nothing...
To view, visit change 79905. To unsubscribe, or for help writing mail filters, visit settings.