Change in coreboot[master]: trogdor: latching GPIO interrupt support

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

mturney mturney (Code Review)

4 Feb 2020 4 Feb '20

5:18 p.m.

Hello Ravi kumar,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/38714

to review the following change.

Change subject: trogdor: latching GPIO interrupt support ......................................................................

trogdor: latching GPIO interrupt support

Required for TPM IRQ.

Change-Id: I8198213cf2808be5291620892185b1e534263e3f Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org --- M src/mainboard/google/trogdor/chromeos.c 1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38714/1

diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c index e840613..e9c3a78 100644 --- a/src/mainboard/google/trogdor/chromeos.c +++ b/src/mainboard/google/trogdor/chromeos.c @@ -16,6 +16,7 @@ #include <boot/coreboot_tables.h> #include <bootmode.h> #include "board.h" +#include <security/tpm/tis.h>

int get_write_protect_state(void) { @@ -46,3 +47,9 @@

lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); } + +int tis_plat_irq_status(void) +{ + return gpio_irq_status(GPIO_H1_AP_INT); +} +

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

build bot (Jenkins) (Code Review)

4 Feb 4 Feb

5:22 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: latching GPIO interrupt support ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38714/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.c:

https://review.coreboot.org/c/coreboot/+/38714/1/src/mainboard/google/trogdo... PS1, Line 53: return gpio_irq_status(GPIO_H1_AP_INT); code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/1/src/mainboard/google/trogdo... PS1, Line 53: return gpio_irq_status(GPIO_H1_AP_INT); please, no spaces at the start of a line

mturney mturney (Code Review)

5 Feb 5 Feb

1:23 p.m.

Hello Ravi kumar, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38714

to look at the new patch set (#2).

Change subject: trogdor: latching GPIO interrupt support ......................................................................

trogdor: latching GPIO interrupt support

Required for TPM IRQ.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38714/2

Julius Werner (Code Review)

6:04 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: latching GPIO interrupt support ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38714/3/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.c:

https://review.coreboot.org/c/coreboot/+/38714/3/src/mainboard/google/trogdo... PS3, Line 53: GPIO_H1_AP_INT ...and what about gpio_input_irq()? It's not going to initialize itself... (should be done in bootblock_mainboard_init()).

Paul Menzel (Code Review)

6 Feb 6 Feb

8:52 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: latching GPIO interrupt support ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38714/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38714/3//COMMIT_MSG@7 PS3, Line 7: latching Imperative mood. Latch?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 3 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Feb 2020 16:52:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

mturney mturney (Code Review)

7 Feb 7 Feb

10:41 a.m.

mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: latching GPIO interrupt support ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38714/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38714/3//COMMIT_MSG@7 PS3, Line 7: latching

...

Imperative mood. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 3 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 07 Feb 2020 18:41:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

mturney mturney (Code Review)

10:47 a.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Hello Ravi kumar, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38714

to look at the new patch set (#4).

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

trogdor: Latch GPIO interrupt support

Required for TPM IRQ.

Change-Id: I8198213cf2808be5291620892185b1e534263e3f Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org --- M src/mainboard/google/trogdor/board.h M src/mainboard/google/trogdor/bootblock.c M src/mainboard/google/trogdor/chromeos.c 3 files changed, 15 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38714/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 4 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

10:50 a.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

Patch Set 4:

(6 comments)

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/board.h:

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 29: GPIO_PULLNONE = 0, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 29: GPIO_PULLNONE = 0, please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 30: GPIO_PULLUP = 1, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 30: GPIO_PULLUP = 1, please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 31: GPIO_PULLDOWN = 2, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 31: GPIO_PULLDOWN = 2, please, no spaces at the start of a line

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 4 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 07 Feb 2020 18:50:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Julius Werner (Code Review)

2:06 p.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/board.h:

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 29: GPIO_PULLNONE = 0,

...

code indent should use tabs where possible

These don't need to be here, just use GPIO_PULL_UP from <soc/gpio.h>. (Also, like the bot says, please always indent with tabs, not spaces.)

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/bootblock.c:

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 27: gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULLUP); Sorry, on second thought, this should go into chromeos.c after all...

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.c:

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 32: gpio_input_pullup(GPIO_H1_AP_INT); ...and replace this line here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 4 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 07 Feb 2020 22:06:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

2:54 p.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

Patch Set 5:

(6 comments)

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/board.h:

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 29: GPIO_PULLNONE = 0, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 29: GPIO_PULLNONE = 0, please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 30: GPIO_PULLUP = 1, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 30: GPIO_PULLUP = 1, please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 31: GPIO_PULLDOWN = 2, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 31: GPIO_PULLDOWN = 2, please, no spaces at the start of a line

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 5 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 07 Feb 2020 22:54:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

14 Feb 14 Feb

9:01 p.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

Patch Set 6:

(6 comments)

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/board.h:

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 29: GPIO_PULLNONE = 0, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 29: GPIO_PULLNONE = 0, please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 30: GPIO_PULLUP = 1, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 30: GPIO_PULLUP = 1, please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 31: GPIO_PULLDOWN = 2, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 31: GPIO_PULLDOWN = 2, please, no spaces at the start of a line

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 6 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 15 Feb 2020 05:01:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

11:39 p.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

Patch Set 7:

(6 comments)

https://review.coreboot.org/c/coreboot/+/38714/7/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/board.h:

https://review.coreboot.org/c/coreboot/+/38714/7/src/mainboard/google/trogdo... PS7, Line 29: GPIO_PULLNONE = 0, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/7/src/mainboard/google/trogdo... PS7, Line 29: GPIO_PULLNONE = 0, please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/38714/7/src/mainboard/google/trogdo... PS7, Line 30: GPIO_PULLUP = 1, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/7/src/mainboard/google/trogdo... PS7, Line 30: GPIO_PULLUP = 1, please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/38714/7/src/mainboard/google/trogdo... PS7, Line 31: GPIO_PULLDOWN = 2, code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/38714/7/src/mainboard/google/trogdo... PS7, Line 31: GPIO_PULLDOWN = 2, please, no spaces at the start of a line

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 7 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 15 Feb 2020 07:39:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ravi Kumar Bokka (Code Review)

17 Feb 17 Feb

8:41 a.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38714/3/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.c:

https://review.coreboot.org/c/coreboot/+/38714/3/src/mainboard/google/trogdo... PS3, Line 53: GPIO_H1_AP_INT

...

...and what about gpio_input_irq()? It's not going to initialize itself... […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 7 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Mon, 17 Feb 2020 16:41:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Ravi kumar (Code Review)

18 Feb 18 Feb

12:40 a.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Ravi kumar has uploaded a new patch set (#8) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

trogdor: Latch GPIO interrupt support

Required for TPM IRQ.

Change-Id: I8198213cf2808be5291620892185b1e534263e3f Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org --- M src/mainboard/google/trogdor/bootblock.c M src/mainboard/google/trogdor/chromeos.c 2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38714/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 8 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

6:01 a.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Ravi kumar has uploaded a new patch set (#9) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

trogdor: Latch GPIO interrupt support

Required for TPM IRQ.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38714/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 9 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Ravi Kumar Bokka (Code Review)

6:09 a.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

Patch Set 9:

(8 comments)

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/board.h:

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 29: GPIO_PULLNONE = 0,

...

please, no spaces at the start of a line

Done

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 29: GPIO_PULLNONE = 0,

...

These don't need to be here, just use GPIO_PULL_UP from <soc/gpio.h>. […]

Done

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 30: GPIO_PULLUP = 1,

...

please, no spaces at the start of a line

Done

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 30: GPIO_PULLUP = 1,

...

code indent should use tabs where possible

Done

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 31: GPIO_PULLDOWN = 2,

...

please, no spaces at the start of a line

Done

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 31: GPIO_PULLDOWN = 2,

...

code indent should use tabs where possible

Done

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/bootblock.c:

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 27: gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULLUP);

...

Sorry, on second thought, this should go into chromeos.c after all...

Done

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.c:

https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 32: gpio_input_pullup(GPIO_H1_AP_INT);

...

...and replace this line here.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 9 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Tue, 18 Feb 2020 14:09:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: comment

Ravi Kumar Bokka (Code Review)

6:11 a.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

Patch Set 9:

(6 comments)

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/board.h:

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 29: GPIO_PULLNONE = 0,

...

please, no spaces at the start of a line

Done

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 29: GPIO_PULLNONE = 0,

...

code indent should use tabs where possible

Done

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 30: GPIO_PULLUP = 1,

...

code indent should use tabs where possible

Done

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 30: GPIO_PULLUP = 1,

...

please, no spaces at the start of a line

Done

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 31: GPIO_PULLDOWN = 2,

...

please, no spaces at the start of a line

Done

https://review.coreboot.org/c/coreboot/+/38714/5/src/mainboard/google/trogdo... PS5, Line 31: GPIO_PULLDOWN = 2,

...

code indent should use tabs where possible

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 9 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Tue, 18 Feb 2020 14:11:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: comment

Ravi Kumar Bokka (Code Review)

6:12 a.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

Patch Set 9:

(6 comments)

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/board.h:

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 29: GPIO_PULLNONE = 0,

...

code indent should use tabs where possible

Done

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 29: GPIO_PULLNONE = 0,

...

please, no spaces at the start of a line

Done

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 30: GPIO_PULLUP = 1,

...

code indent should use tabs where possible

Done

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 30: GPIO_PULLUP = 1,

...

please, no spaces at the start of a line

Done

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 31: GPIO_PULLDOWN = 2,

...

please, no spaces at the start of a line

Done

https://review.coreboot.org/c/coreboot/+/38714/6/src/mainboard/google/trogdo... PS6, Line 31: GPIO_PULLDOWN = 2,

...

code indent should use tabs where possible

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 9 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Tue, 18 Feb 2020 14:12:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: comment

Ravi kumar (Code Review)

8:46 a.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Ravi kumar has uploaded a new patch set (#10) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

trogdor: Latch GPIO interrupt support

Required for TPM IRQ.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38714/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 10 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

mturney mturney (Code Review)

1:18 p.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Hello Ravi kumar, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38714

to look at the new patch set (#11).

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

trogdor: Latch GPIO interrupt support

Required for TPM IRQ.

Change-Id: I8198213cf2808be5291620892185b1e534263e3f Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org --- M src/mainboard/google/trogdor/chromeos.c 1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38714/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 11 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

19 Feb 19 Feb

7:56 p.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

Patch Set 12: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 12 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Thu, 20 Feb 2020 03:56:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ravi kumar (Code Review)

3 Mar 3 Mar

2:29 a.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Ravi kumar has uploaded a new patch set (#14) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

trogdor: Latch GPIO interrupt support

Required for TPM IRQ.

Change-Id: I8198213cf2808be5291620892185b1e534263e3f Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org --- M src/mainboard/google/trogdor/chromeos.c 1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38714/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 14 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

mturney mturney (Code Review)

6 Mar 6 Mar

1:21 p.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Hello Ravi kumar, build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38714

to look at the new patch set (#15).

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

trogdor: Latch GPIO interrupt support

Required for TPM IRQ.

Change-Id: I8198213cf2808be5291620892185b1e534263e3f Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org --- M src/mainboard/google/trogdor/chromeos.c 1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38714/15

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 15 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

17 Mar 17 Mar

8:57 a.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Ravi kumar has uploaded a new patch set (#17) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

trogdor: Latch GPIO interrupt support

Required for TPM IRQ.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38714/17

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 17 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

21 Apr 21 Apr

3:27 p.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

Patch Set 19: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 19 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Tue, 21 Apr 2020 22:27:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

11 May 11 May

4:59 p.m.

New subject: Change in coreboot[master]: trogdor: Latch GPIO interrupt support

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38714 )

Change subject: trogdor: Latch GPIO interrupt support ......................................................................

trogdor: Latch GPIO interrupt support

Required for TPM IRQ.

Change-Id: I8198213cf2808be5291620892185b1e534263e3f Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/38714 Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/trogdor/chromeos.c 1 file changed, 6 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved

diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c index cb01091..985ba0f 100644 --- a/src/mainboard/google/trogdor/chromeos.c +++ b/src/mainboard/google/trogdor/chromeos.c @@ -3,6 +3,7 @@ #include <boot/coreboot_tables.h> #include <bootmode.h> #include "board.h" +#include <security/tpm/tis.h>

int get_write_protect_state(void) { @@ -31,3 +32,8 @@

lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); } + +int tis_plat_irq_status(void) +{ + return gpio_irq_status(GPIO_H1_AP_INT); +}

-- To view, visit https://review.coreboot.org/c/coreboot/+/38714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f Gerrit-Change-Number: 38714 Gerrit-PatchSet: 25 Gerrit-Owner: mturney mturney mturney@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: merged

1651

days inactive

1747

days old

coreboot-gerrit@coreboot.org

25 comments

6 participants

tags (0)

participants (6)

build bot (Jenkins) (Code Review)
Julius Werner (Code Review)
mturney mturney (Code Review)
Paul Menzel (Code Review)
Ravi kumar (Code Review)
Ravi Kumar Bokka (Code Review)