8 comments:
File src/mainboard/google/trogdor/board.h:
Patch Set #4, Line 29: GPIO_PULLNONE = 0,
please, no spaces at the start of a line
Done
Patch Set #4, Line 29: GPIO_PULLNONE = 0,
These don't need to be here, just use GPIO_PULL_UP from <soc/gpio.h>. […]
Done
Patch Set #4, Line 30: GPIO_PULLUP = 1,
please, no spaces at the start of a line
Done
Patch Set #4, Line 30: GPIO_PULLUP = 1,
code indent should use tabs where possible
Done
Patch Set #4, Line 31: GPIO_PULLDOWN = 2,
please, no spaces at the start of a line
Done
Patch Set #4, Line 31: GPIO_PULLDOWN = 2,
code indent should use tabs where possible
Done
File src/mainboard/google/trogdor/bootblock.c:
Patch Set #4, Line 27: gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULLUP);
Sorry, on second thought, this should go into chromeos.c after all...
Done
File src/mainboard/google/trogdor/chromeos.c:
Patch Set #4, Line 32: gpio_input_pullup(GPIO_H1_AP_INT);
...and replace this line here.
Done
To view, visit change 38714. To unsubscribe, or for help writing mail filters, visit settings.