Attention is currently required from: Federico Amedeo Izzo.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82010?usp=email )
Change subject: mb/aoostar: Add AOOSTAR R1 (WTR_R1) ......................................................................
Patch Set 8:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82010/comment/266bbfca_2e6e1621 : PS8, Line 47: VDT VBT?
https://review.coreboot.org/c/coreboot/+/82010/comment/8cf30f73_43b348fe : PS8, Line 49: vgabios blob (ID 8086,0406) Shouldn't be needed if you use FSP GOP for video init. Also, 8086:0406 is "Haswell Integrated Graphics Controller", which is blatantly wrong.
File src/mainboard/aoostar/wtr_r1/Kconfig:
https://review.coreboot.org/c/coreboot/+/82010/comment/da424775_4283f1e2 : PS8, Line 28: config MAINBOARD_VENDOR : string : default "AOOSTAR" Already set in vendor Kconfig, please drop
File src/mainboard/aoostar/wtr_r1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/82010/comment/9d2e54f5_a7a6deff : PS8, Line 194: : [PchSerialIoIndexUART1] = PchSerialIoDisabled, : [PchSerialIoIndexUART2] = PchSerialIoDisabled, Disabled equals zero. Devicetree "register"s are default-initialised to zero, so this can be dropped.
https://review.coreboot.org/c/coreboot/+/82010/comment/8a90558f_06e67568 : PS8, Line 201: : [PchSerialIoIndexGSPI1] = PchSerialIoDisabled, : [PchSerialIoIndexGSPI2] = PchSerialIoDisabled, : [PchSerialIoIndexGSPI3] = PchSerialIoDisabled, Disabled equals zero. Devicetree "register"s are default-initialised to zero, so this can be dropped.
https://review.coreboot.org/c/coreboot/+/82010/comment/05b4af84_80c771d7 : PS8, Line 205: : register "serial_io_gspi_cs_mode" = "{ : [PchSerialIoIndexGSPI0] = 0, : [PchSerialIoIndexGSPI1] = 0, : [PchSerialIoIndexGSPI2] = 0, : [PchSerialIoIndexGSPI3] = 0, : }" : register "serial_io_gspi_cs_state" = "{ : [PchSerialIoIndexGSPI0] = 0, : [PchSerialIoIndexGSPI1] = 0, : [PchSerialIoIndexGSPI2] = 0, : [PchSerialIoIndexGSPI3] = 0, : }" Devicetree "register"s are default-initialised to zero, so this can be dropped.