Attention is currently required from: Federico Amedeo Izzo.

View Change

6 comments:

• Commit Message:

  • Patch Set #8, Line 47: VDT

    VBT?

  • Patch Set #8, Line 49: vgabios blob (ID 8086,0406)

    Shouldn't be needed if you use FSP GOP for video init. Also, 8086:0406 is "Haswell Integrated Graphics Controller", which is blatantly wrong.

• File src/mainboard/aoostar/wtr_r1/Kconfig:

  • Patch Set #8, Line 28:

    config MAINBOARD_VENDOR
    	string
    	default "AOOSTAR"
    

    Already set in vendor Kconfig, please drop

• File src/mainboard/aoostar/wtr_r1/devicetree.cb:

  • Patch Set #8, Line 194:

    
    				[PchSerialIoIndexUART1] = PchSerialIoDisabled,
    				[PchSerialIoIndexUART2] = PchSerialIoDisabled,
    

    Disabled equals zero. Devicetree "register"s are default-initialised to zero, so this can be dropped.

  • Patch Set #8, Line 201:

    
    				[PchSerialIoIndexGSPI1] = PchSerialIoDisabled,
    				[PchSerialIoIndexGSPI2] = PchSerialIoDisabled,
    				[PchSerialIoIndexGSPI3] = PchSerialIoDisabled,
    

    Disabled equals zero. Devicetree "register"s are default-initialised to zero, so this can be dropped.

  • Patch Set #8, Line 205:

    
    			register "serial_io_gspi_cs_mode" = "{
    				[PchSerialIoIndexGSPI0] = 0,
    				[PchSerialIoIndexGSPI1] = 0,
    				[PchSerialIoIndexGSPI2] = 0,
    				[PchSerialIoIndexGSPI3] = 0,
    			}"
    			register "serial_io_gspi_cs_state" = "{
    				[PchSerialIoIndexGSPI0] = 0,
    				[PchSerialIoIndexGSPI1] = 0,
    				[PchSerialIoIndexGSPI2] = 0,
    				[PchSerialIoIndexGSPI3] = 0,
    			}"
    

    Devicetree "register"s are default-initialised to zero, so this can be dropped.

To view, visit change 82010. To unsubscribe, or for help writing mail filters, visit settings.