Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42398 )
Change subject: mb/asrock/b85m_pro4: Correct PS/2 keyboard IRQ ......................................................................
mb/asrock/b85m_pro4: Correct PS/2 keyboard IRQ
No wonder why the PS/2 keyboard was being detected as a mouse!
Change-Id: I7080c8210d96b079a5c08d98554ed154141086a6 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/42398/1
diff --git a/src/mainboard/asrock/b85m_pro4/devicetree.cb b/src/mainboard/asrock/b85m_pro4/devicetree.cb index 4bb5380..98a2ee8 100644 --- a/src/mainboard/asrock/b85m_pro4/devicetree.cb +++ b/src/mainboard/asrock/b85m_pro4/devicetree.cb @@ -70,7 +70,7 @@ device pnp 2e.5 on # PS/2 KBC io 0x60 = 0x0060 io 0x62 = 0x0064 - irq 0x70 = 12 # + Keyboard + irq 0x70 = 1 # + Keyboard irq 0x72 = 12 # + Mouse end device pnp 2e.6 off end # CIR
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42398 )
Change subject: mb/asrock/b85m_pro4: Correct PS/2 keyboard IRQ ......................................................................
Patch Set 10: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42398 )
Change subject: mb/asrock/b85m_pro4: Correct PS/2 keyboard IRQ ......................................................................
Patch Set 10: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42398 )
Change subject: mb/asrock/b85m_pro4: Correct PS/2 keyboard IRQ ......................................................................
mb/asrock/b85m_pro4: Correct PS/2 keyboard IRQ
No wonder why the PS/2 keyboard was being detected as a mouse!
Change-Id: I7080c8210d96b079a5c08d98554ed154141086a6 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42398 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/b85m_pro4/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
diff --git a/src/mainboard/asrock/b85m_pro4/devicetree.cb b/src/mainboard/asrock/b85m_pro4/devicetree.cb index 4bb5380..98a2ee8 100644 --- a/src/mainboard/asrock/b85m_pro4/devicetree.cb +++ b/src/mainboard/asrock/b85m_pro4/devicetree.cb @@ -70,7 +70,7 @@ device pnp 2e.5 on # PS/2 KBC io 0x60 = 0x0060 io 0x62 = 0x0064 - irq 0x70 = 12 # + Keyboard + irq 0x70 = 1 # + Keyboard irq 0x72 = 12 # + Mouse end device pnp 2e.6 off end # CIR
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Paul Menzel (Code Review)