Change in coreboot[master]: mb/asrock/b85m_pro4: Correct HWM related settings

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

7 Jun 2020 7 Jun '20

2:09 a.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Correct HWM related settings ......................................................................

mb/asrock/b85m_pro4: Correct HWM related settings

Only one generic decode range is needed for the HWM. Also, pin 3 was selected as fan input, but it is not connected. Use pin 93 instead, because boardviews show that it is wired to the PWR_FAN1 connector.

Change-Id: I964a073efbfaa1d79d3483d59ad04fe674bcb275 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/devicetree.cb 1 file changed, 2 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/42131/1

diff --git a/src/mainboard/asrock/b85m_pro4/devicetree.cb b/src/mainboard/asrock/b85m_pro4/devicetree.cb index eec921ec..b17d290 100644 --- a/src/mainboard/asrock/b85m_pro4/devicetree.cb +++ b/src/mainboard/asrock/b85m_pro4/devicetree.cb @@ -26,9 +26,7 @@ device pci 03.0 on end # Mini-HD audio

chip southbridge/intel/lynxpoint - register "gen1_dec" = "0x000c0291" - register "gen2_dec" = "0x000c0241" - register "gen3_dec" = "0x000c0251" + register "gen1_dec" = "0x000c0291" # Super I/O HWM register "pirqa_routing" = "0x8b" register "pirqb_routing" = "0x80" register "pirqc_routing" = "0x83" @@ -102,7 +100,7 @@ irq 0xf0 = 0x20 end device pnp 2e.b on # HWM, LED - irq 0x30 = 0xe1 + irq 0x30 = 0x61 # + Fan RPM sense pins io 0x60 = 0x0290 end device pnp 2e.d off end # VID

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

Angel Pons (Code Review)

7 Jun 7 Jun

2:11 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Correct HWM related settings ......................................................................

Patch Set 1:

(1 comment)

Needs to be squashed with CB:42135

https://review.coreboot.org/c/coreboot/+/42131/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/42131/1/src/mainboard/asrock/b85m_p... PS1, Line 103: irq 0x30 = 0x61 # + Fan RPM sense pins This is wrong. Those pins are actually controlling gating of tach signals

Angel Pons (Code Review)

15 Jun 15 Jun

4:43 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Correct HWM related settings ......................................................................

Patch Set 1:

(1 comment)

This change is ready for review.

https://review.coreboot.org/c/coreboot/+/42131/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/42131/1/src/mainboard/asrock/b85m_p... PS1, Line 103: irq 0x30 = 0x61 # + Fan RPM sense pins

...

This is wrong. […]

Pin 3: N/C Pin 4: GPO to enable CPU fan RPM reading on the 4-pin connector Pin 5: GPO to enable CPU fan RPM reading on the 3-pin connector Pin 90: CHA_FAN2 tach Pin 91: N/C (can be connected to SUSACK#) Pin 93: PWR_FAN1 tach

Original value was correct.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I964a073efbfaa1d79d3483d59ad04fe674bcb275 Gerrit-Change-Number: 42131 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 15 Jun 2020 14:43:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

16 Jun 16 Jun

12:03 a.m.

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Correct HWM related settings ......................................................................

Abandoned

Superseded by something else

Angel Pons (Code Review)

12:03 a.m.

Angel Pons has restored this change. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Correct HWM related settings ......................................................................

Restored

Angel Pons (Code Review)

12:03 a.m.

New subject: Change in coreboot[master]: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42131

to look at the new patch set (#2).

Change subject: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges ......................................................................

mb/asrock/b85m_pro4: Drop spurious LPC decode ranges

Only one generic decode range is needed for the HWM.

Change-Id: I964a073efbfaa1d79d3483d59ad04fe674bcb275 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/devicetree.cb 1 file changed, 1 insertion(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/42131/2

HAOUAS Elyes (Code Review)

5:03 p.m.

New subject: Change in coreboot[master]: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42131/3/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/42131/3/src/mainboard/asrock/b85m_p... PS3, Line 30: register "gen2_dec" = "0x000c0241" : register "gen3_dec" = "0x000c0251" those are from vendor "dump" , isn't it? Please teach me how do you found those are not needed?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I964a073efbfaa1d79d3483d59ad04fe674bcb275 Gerrit-Change-Number: 42131 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 16 Jun 2020 15:03:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

5:36 p.m.

New subject: Change in coreboot[master]: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42131/3/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/42131/3/src/mainboard/asrock/b85m_p... PS3, Line 30: register "gen2_dec" = "0x000c0241" : register "gen3_dec" = "0x000c0251"

...

those are from vendor "dump" , isn't it? […]

No, I copied those from h81m-hds carelessly

-- To view, visit https://review.coreboot.org/c/coreboot/+/42131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I964a073efbfaa1d79d3483d59ad04fe674bcb275 Gerrit-Change-Number: 42131 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 16 Jun 2020 15:36:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7 Jul 7 Jul

7:11 a.m.

New subject: Change in coreboot[master]: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42131/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42131/11//COMMIT_MSG@9 PS11, Line 9: Only one generic decode range is needed for the HWM. Please elaborate: found how? will it fix something?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I964a073efbfaa1d79d3483d59ad04fe674bcb275 Gerrit-Change-Number: 42131 Gerrit-PatchSet: 11 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 07 Jul 2020 05:11:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

3:17 p.m.

New subject: Change in coreboot[master]: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42131/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42131/11//COMMIT_MSG@9 PS11, Line 9: Only one generic decode range is needed for the HWM.

...

Please elaborate: found how? will it fix something?

I had copied the code from elsewhere but didn't check it in detail. Then I revisited it and saw I only needed one range. It doesn't make much of a difference because the dropped decode ranges were not used.

I'm not sure if this is worth adding to the commit message. Still, want me to add something?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I964a073efbfaa1d79d3483d59ad04fe674bcb275 Gerrit-Change-Number: 42131 Gerrit-PatchSet: 11 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 07 Jul 2020 13:17:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Felix Held (Code Review)

8 Jul 8 Jul

1:58 a.m.

New subject: Change in coreboot[master]: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges ......................................................................

Patch Set 11: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I964a073efbfaa1d79d3483d59ad04fe674bcb275 Gerrit-Change-Number: 42131 Gerrit-PatchSet: 11 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 07 Jul 2020 23:58:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

9 Jul 9 Jul

12:29 a.m.

New subject: Change in coreboot[master]: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42131/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42131/11//COMMIT_MSG@9 PS11, Line 9: Only one generic decode range is needed for the HWM.

...

I had copied the code from elsewhere but didn't check it in detail. […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/42131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I964a073efbfaa1d79d3483d59ad04fe674bcb275 Gerrit-Change-Number: 42131 Gerrit-PatchSet: 11 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jul 2020 22:29:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Angel Pons (Code Review)

12:30 a.m.

New subject: Change in coreboot[master]: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42131 )

Change subject: mb/asrock/b85m_pro4: Drop spurious LPC decode ranges ......................................................................

mb/asrock/b85m_pro4: Drop spurious LPC decode ranges

Only one generic decode range is needed for the HWM.

Change-Id: I964a073efbfaa1d79d3483d59ad04fe674bcb275 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42131 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/b85m_pro4/devicetree.cb 1 file changed, 1 insertion(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved

diff --git a/src/mainboard/asrock/b85m_pro4/devicetree.cb b/src/mainboard/asrock/b85m_pro4/devicetree.cb index eec921ec..4bb5380 100644 --- a/src/mainboard/asrock/b85m_pro4/devicetree.cb +++ b/src/mainboard/asrock/b85m_pro4/devicetree.cb @@ -26,9 +26,7 @@ device pci 03.0 on end # Mini-HD audio

-- To view, visit https://review.coreboot.org/c/coreboot/+/42131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I964a073efbfaa1d79d3483d59ad04fe674bcb275 Gerrit-Change-Number: 42131 Gerrit-PatchSet: 12 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1387

days inactive

1418

days old

coreboot-gerrit@coreboot.org

12 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Felix Held (Code Review)
HAOUAS Elyes (Code Review)