Change in coreboot[master]: soc/intel/alderlake, soc/common: Add method to determine the cpu type

[Sridhar Siricilla (Code Review)]

Attention is currently required from: Arthur Heymans, Tim Wawrzynczak, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59360 )

Change subject: soc/intel/alderlake, soc/common: Add method to determine the cpu type
......................................................................

Patch Set 7:

(5 comments)

File src/soc/intel/alderlake/cpu.c:

https://review.coreboot.org/c/coreboot/+/59360/comment/42561a6f_8ede1b84 
PS6, Line 74: 0xBE
> could we define an enum for the possible model types ?

Ack

File src/soc/intel/common/block/acpi/cpu_hybrid.c:

https://review.coreboot.org/c/coreboot/+/59360/comment/ad6032df_ead33dc2 
PS1, Line 25: return global_cpu_type_bitmask;
> > Done […]

Ack

File src/soc/intel/common/block/acpi/cpu_hybrid.c:

https://review.coreboot.org/c/coreboot/+/59360/comment/32d99a8c_06e8c3ca 
PS6, Line 15: uint8_t
> `enum core_type`

Ack

https://review.coreboot.org/c/coreboot/+/59360/comment/53e108f8_d63f9522 
PS6, Line 15: uint8_t __weak get_soc_cpu_type(void)
            : {
            : 	return 0;
            : }
> Should not be necessary to add this weak function, instead let's just make it mandatory for platform […]

Agree, when Kconfig option is provided for a feature, it is better to force all dependent functions be implemented.

File src/soc/intel/common/block/include/intelblocks/acpi.h:

https://review.coreboot.org/c/coreboot/+/59360/comment/f42932a0_69b0aab7 
PS6, Line 17:
> Since this can return incorrect data before MP-init, then this should have an 'INVALID' or 'UNKNOWN' […]

Ack