Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32102
Change subject: mb/*/devicetree.cb: Set PrimaryDisplay for skl/kbl ......................................................................
mb/*/devicetree.cb: Set PrimaryDisplay for skl/kbl
Set PrimaryDisplay option in the devicetree.cb for all motherboards with Skylake/Kaby Lake processor.
Change-Id: Ibed05fc9171e2bd73654f0da6273a8534746913d Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb M src/mainboard/google/eve/devicetree.cb M src/mainboard/google/fizz/variants/baseboard/devicetree.cb M src/mainboard/google/glados/variants/asuka/devicetree.cb M src/mainboard/google/glados/variants/caroline/devicetree.cb M src/mainboard/google/glados/variants/cave/devicetree.cb M src/mainboard/google/glados/variants/chell/devicetree.cb M src/mainboard/google/glados/variants/glados/devicetree.cb M src/mainboard/google/glados/variants/lars/devicetree.cb M src/mainboard/google/glados/variants/sentry/devicetree.cb M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/nocturne/devicetree.cb M src/mainboard/google/poppy/variants/rammus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb M src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb M src/mainboard/intel/kunimitsu/devicetree.cb M src/mainboard/intel/saddlebrook/devicetree.cb M src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb M src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb 22 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/32102/1
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 9e2fca0..c79fccf 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -47,6 +47,7 @@ register "HeciEnabled" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "0" + register "PrimaryDisplay" = "Display_PEG" register "Device4Enable" = "1" register "SaGv" = "SaGv_Enabled" register "PmTimerDisabled" = "0" diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb index 2f275ac..839c830 100644 --- a/src/mainboard/google/eve/devicetree.cb +++ b/src/mainboard/google/eve/devicetree.cb @@ -43,6 +43,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/fizz/variants/baseboard/devicetree.cb b/src/mainboard/google/fizz/variants/baseboard/devicetree.cb index bfabe29..80a0eb8 100644 --- a/src/mainboard/google/fizz/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/fizz/variants/baseboard/devicetree.cb @@ -78,6 +78,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/glados/variants/asuka/devicetree.cb b/src/mainboard/google/glados/variants/asuka/devicetree.cb index e0a792d..3b3f71d 100644 --- a/src/mainboard/google/glados/variants/asuka/devicetree.cb +++ b/src/mainboard/google/glados/variants/asuka/devicetree.cb @@ -35,6 +35,7 @@ register "ScsSdCardEnabled" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/glados/variants/caroline/devicetree.cb b/src/mainboard/google/glados/variants/caroline/devicetree.cb index 0f5a911..77ac89f 100644 --- a/src/mainboard/google/glados/variants/caroline/devicetree.cb +++ b/src/mainboard/google/glados/variants/caroline/devicetree.cb @@ -45,6 +45,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/glados/variants/cave/devicetree.cb b/src/mainboard/google/glados/variants/cave/devicetree.cb index a9b28a8..02b06fd 100644 --- a/src/mainboard/google/glados/variants/cave/devicetree.cb +++ b/src/mainboard/google/glados/variants/cave/devicetree.cb @@ -45,6 +45,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/glados/variants/chell/devicetree.cb b/src/mainboard/google/glados/variants/chell/devicetree.cb index 07467b3..730ea42 100644 --- a/src/mainboard/google/glados/variants/chell/devicetree.cb +++ b/src/mainboard/google/glados/variants/chell/devicetree.cb @@ -45,6 +45,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/glados/variants/glados/devicetree.cb b/src/mainboard/google/glados/variants/glados/devicetree.cb index d4266cc..8aa165c 100644 --- a/src/mainboard/google/glados/variants/glados/devicetree.cb +++ b/src/mainboard/google/glados/variants/glados/devicetree.cb @@ -45,6 +45,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/glados/variants/lars/devicetree.cb b/src/mainboard/google/glados/variants/lars/devicetree.cb index f3f5eab..e33342a 100644 --- a/src/mainboard/google/glados/variants/lars/devicetree.cb +++ b/src/mainboard/google/glados/variants/lars/devicetree.cb @@ -33,6 +33,7 @@ register "ScsSdCardEnabled" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/glados/variants/sentry/devicetree.cb b/src/mainboard/google/glados/variants/sentry/devicetree.cb index 5cce0f0..65a5fee 100644 --- a/src/mainboard/google/glados/variants/sentry/devicetree.cb +++ b/src/mainboard/google/glados/variants/sentry/devicetree.cb @@ -35,6 +35,7 @@ register "ScsSdCardEnabled" = "2" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 87d7348..43ee482 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -51,6 +51,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb index 7335c0a..ba681a8 100644 --- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb @@ -48,6 +48,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index 59cca29..d77a8d4 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -47,6 +47,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index fed85b6..8d4e6f8 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -48,6 +48,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index ac52208..08899fc 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -53,6 +53,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/poppy/variants/rammus/devicetree.cb b/src/mainboard/google/poppy/variants/rammus/devicetree.cb index 4f58f40..9285fa6 100644 --- a/src/mainboard/google/poppy/variants/rammus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/rammus/devicetree.cb @@ -51,6 +51,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb index d813cc1..6451523 100644 --- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb +++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb @@ -48,6 +48,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb b/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb index fcd5aab..5098996 100644 --- a/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb +++ b/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb @@ -29,6 +29,7 @@ register "ScsSdCardEnabled" = "2" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "SaGv" = "SaGv_Enabled"
diff --git a/src/mainboard/intel/kunimitsu/devicetree.cb b/src/mainboard/intel/kunimitsu/devicetree.cb index ec1c11f..2f011d9 100644 --- a/src/mainboard/intel/kunimitsu/devicetree.cb +++ b/src/mainboard/intel/kunimitsu/devicetree.cb @@ -33,6 +33,7 @@ register "ScsSdCardEnabled" = "2" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3" diff --git a/src/mainboard/intel/saddlebrook/devicetree.cb b/src/mainboard/intel/saddlebrook/devicetree.cb index 2f84a5d..294f176b 100644 --- a/src/mainboard/intel/saddlebrook/devicetree.cb +++ b/src/mainboard/intel/saddlebrook/devicetree.cb @@ -41,6 +41,7 @@ register "ScsSdCardEnabled" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "0" register "Heci3Enabled" = "0"
diff --git a/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb b/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb index 8d2a436..b2b2377 100644 --- a/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb +++ b/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb @@ -59,6 +59,7 @@ register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" register "Device4Enable" = "1" + register "PrimaryDisplay" = "Display_Auto" register "HeciEnabled" = "0" register "SaGv" = "3" register "PmConfigSlpS3MinAssert" = "2" # 50ms diff --git a/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb b/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb index 49af7b6..8968036 100644 --- a/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb +++ b/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb @@ -58,6 +58,7 @@ register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" + register "PrimaryDisplay" = "Display_Auto" register "Device4Enable" = "1" register "HeciEnabled" = "0" register "SaGv" = "3"
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32102 )
Change subject: mb/*/devicetree.cb: Set PrimaryDisplay for skl/kbl ......................................................................
Patch Set 3:
I think IGD should be used over auto on Chromebooks as we know there's only one GPU.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32102 )
Change subject: mb/*/devicetree.cb: Set PrimaryDisplay for skl/kbl ......................................................................
Patch Set 3:
This CL should be squashed into the previous one so that all the changes go in together.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32102 )
Change subject: mb/*/devicetree.cb: Set PrimaryDisplay for skl/kbl ......................................................................
Patch Set 3:
Patch Set 3:
This CL should be squashed into the previous one so that all the changes go in together.
All changes have been moved to patch with Change-Id: Ie3f9362676105e41c69139a094dbb9e8b865689f
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32102 )
Change subject: mb/*/devicetree.cb: Set PrimaryDisplay for skl/kbl ......................................................................
Patch Set 3:
Patch Set 3:
I think IGD should be used over auto on Chromebooks as we know there's only one GPU.
Ok. I set PrimaryDisplay to "Display_iGFX" for Chromebooks in Change-Id: Ie3f9362676105e41c69139a094dbb9e8b865689f
Maxim Polyakov has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32102 )
Change subject: mb/*/devicetree.cb: Set PrimaryDisplay for skl/kbl ......................................................................
Abandoned
-
Furquan Shaikh (Code Review) -
Maxim Polyakov (Code Review)
-
Patrick Rudolph (Code Review)