Change in ...coreboot[master]: mb/aopen/dxplplusu: Remove redundant use of ACPI offset operator
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32127
Change subject: mb/aopen/dxplplusu: Remove redundant use of ACPI offset operator ......................................................................
mb/aopen/dxplplusu: Remove redundant use of ACPI offset operator
Change-Id: I790303a1fab64dbbe749563325394b9be2c109ad Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/aopen/dxplplusu/acpi/i82801db.asl 1 file changed, 17 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/32127/1
diff --git a/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl b/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl index 4be964d..5cd077b 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl @@ -85,10 +85,23 @@ OperationRegion (ACPI, SystemIO, 0x0400, 0xC0) Field (ACPI, ByteAcc, NoLock, Preserve) { - Offset (0x00), PS1L,8, PS1H,8, PE1L,8, PE1H,8, - Offset (0x28), GS0L,8, GS0H,8, GSPL,8, GSPH,8, - Offset (0x2C), GE0L,8, GE0H,8, GEPL,8, GEPH,8, - Offset (0xB8), GPLV,8 + PS1L, 8, + PS1H, 8, + PE1L, 8, + PE1H, 8, + + Offset (0x28), + GS0L, 8, + GS0H, 8, + GSPL, 8, + GSPH, 8, + GE0L, 8, + GE0H, 8, + GEPL, 8, + GEPH, 8, + + Offset (0xB8), + GPLV, 8 }
Name (MSBF, ResourceTemplate ()
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32127 )
Change subject: mb/aopen/dxplplusu: Remove redundant use of ACPI offset operator ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32127 )
Change subject: mb/aopen/dxplplusu: Remove redundant use of ACPI offset operator ......................................................................
mb/aopen/dxplplusu: Remove redundant use of ACPI offset operator
Change-Id: I790303a1fab64dbbe749563325394b9be2c109ad Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32127 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/aopen/dxplplusu/acpi/i82801db.asl 1 file changed, 17 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl b/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl index 4be964d..5cd077b 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl @@ -85,10 +85,23 @@ OperationRegion (ACPI, SystemIO, 0x0400, 0xC0) Field (ACPI, ByteAcc, NoLock, Preserve) { - Offset (0x00), PS1L,8, PS1H,8, PE1L,8, PE1H,8, - Offset (0x28), GS0L,8, GS0H,8, GSPL,8, GSPH,8, - Offset (0x2C), GE0L,8, GE0H,8, GEPL,8, GEPH,8, - Offset (0xB8), GPLV,8 + PS1L, 8, + PS1H, 8, + PE1L, 8, + PE1H, 8, + + Offset (0x28), + GS0L, 8, + GS0H, 8, + GSPL, 8, + GSPH, 8, + GE0L, 8, + GE0H, 8, + GEPL, 8, + GEPH, 8, + + Offset (0xB8), + GPLV, 8 }
Name (MSBF, ResourceTemplate ()
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)