Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48194 )
Change subject: mb/google/volteer: Improve type-C Port 1 USB2 Eye Diagram for delbin
......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48194/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48194/3/src/mainboard/google/voltee...
PS3, Line 50: 3
USB2_BIAS_39P35MV
Done
https://review.coreboot.org/c/coreboot/+/48194/3/src/mainboard/google/voltee...
PS3, Line 51: 2
USB2_PRE_EMP_ON
Done
https://review.coreboot.org/c/coreboot/+/48194/3/src/mainboard/google/voltee...
PS3, Line 52: 7
USB2_BIAS_56P3MV
Done
https://review.coreboot.org/c/coreboot/+/48194/3/src/mainboard/google/voltee...
PS3, Line 53: 1
USB2_HALF_BIT_PRE_EMP
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41cda27f97287fae5c23dc9843fdf0a8a33057f8
Gerrit-Change-Number: 48194
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 09 Dec 2020 09:37:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment