Change in ...coreboot[master]: mb/google/sarein: Add power control for Sarien touchscreen

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

EricR Lai (Code Review)

16 Apr 2019 16 Apr '19

8:32 a.m.

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32330

Change subject: mb/google/sarein: Add power control for Sarien touchscreen ......................................................................

mb/google/sarein: Add power control for Sarien touchscreen

This change will save touchscreen power leakage 2-3mW in S0iX and increase T2 display time delay to meet display panel requirement.

BUG=b:129899315 TEST= Measure touchscreen power from Sarien during S0iX

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 14 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/32330/1

diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index e4a92a9..bdd134a 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -311,10 +311,12 @@ register "generic.desc" = ""Touchscreen"" register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" + register "generic.reset_delay_ms" = "10" register "generic.enable_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" - register "generic.enable_delay_ms" = "5" - register "generic.enable_off_delay_ms" = "100" + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" + register "generic.enable_delay_ms" = "55" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x0" device i2c 10 on end @@ -324,10 +326,12 @@ register "generic.desc" = ""ELAN Touchscreen"" register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" + register "generic.reset_delay_ms" = "10" register "generic.enable_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" - register "generic.enable_delay_ms" = "5" - register "generic.enable_off_delay_ms" = "100" + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" + register "generic.enable_delay_ms" = "55" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 10 on end @@ -337,8 +341,10 @@ register "desc" = ""Melfas Touchscreen"" register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" register "probed" = "1" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" - register "enable_delay_ms" = "5" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" + register "reset_delay_ms" = "10" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" + register "enable_delay_ms" = "55" register "has_power_resource" = "1" device i2c 34 on end end

Attachments:

attachment.htm (text/html — 6.3 KB)

Show replies by date

EricR Lai (Code Review)

19 Apr 19 Apr

2:37 p.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32330 )

Change subject: mb/google/sarein: Add power control for Sarien touchscreen ......................................................................

Patch Set 1:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 19 Apr 2019 12:37:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Simon Glass (Code Review)

22 Apr 22 Apr

2:34 p.m.

Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32330 )

Change subject: mb/google/sarein: Add power control for Sarien touchscreen ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 22 Apr 2019 12:34:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

EricR Lai (Code Review)

24 Apr 24 Apr

8:34 a.m.

Hello Simon Glass, Lijian Zhao, Duncan Laurie, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32330

to look at the new patch set (#2).

Change subject: mb/google/sarein: Add power control for Sarien touchscreen ......................................................................

mb/google/sarein: Add power control for Sarien touchscreen

This change will save touchscreen power leakage 2-3mW in S0iX and increase T2 display time delay to meet display panel requirement.

BUG=b:129899315 TEST= Measure touchscreen power from Sarien during S0iX

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/32330/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 2 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

2:09 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32330 )

Change subject: mb/google/sarein: Add power control for Sarien touchscreen ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 3 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Apr 2019 12:09:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

3:22 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32330 )

Change subject: mb/google/sarein: Add power control for Sarien touchscreen ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/32330/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32330/3//COMMIT_MSG@7 PS3, Line 7: sarein sarien

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 3 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Apr 2019 13:22:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

EricR Lai (Code Review)

3:53 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien: Add power control for Sarien touchscreen

Hello Simon Glass, Angel Pons, Lijian Zhao, Paul Menzel, Duncan Laurie, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32330

to look at the new patch set (#4).

Change subject: mb/google/sarien: Add power control for Sarien touchscreen ......................................................................

mb/google/sarien: Add power control for Sarien touchscreen

This change will save touchscreen power leakage 2-3mW in S0iX and increase T2 display time delay to meet display panel requirement.

BUG=b:129899315 TEST= Measure touchscreen power from Sarien during S0iX

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/32330/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

EricR Lai (Code Review)

3:54 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien: Add power control for Sarien touchscreen

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32330 )

Change subject: mb/google/sarien: Add power control for Sarien touchscreen ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32330/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32330/3//COMMIT_MSG@7 PS3, Line 7: sarein

...

sarien

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Apr 2019 13:54:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Duncan Laurie (Code Review)

5:52 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien: Add power control for Sarien touchscreen

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32330 )

Change subject: mb/google/sarien: Add power control for Sarien touchscreen ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Apr 2019 15:52:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

5:52 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien: Add power control for Sarien touchscreen

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32330 )

Change subject: mb/google/sarien: Add power control for Sarien touchscreen ......................................................................

mb/google/sarien: Add power control for Sarien touchscreen

This change will save touchscreen power leakage 2-3mW in S0iX and increase T2 display time delay to meet display panel requirement.

BUG=b:129899315 TEST= Measure touchscreen power from Sarien during S0iX

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32330 Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 9 insertions(+), 5 deletions(-)

Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index d5e8afb..27c0913 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -310,10 +310,12 @@ register "generic.desc" = ""ELAN Touchscreen"" register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" + register "generic.reset_delay_ms" = "10" register "generic.enable_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" - register "generic.enable_delay_ms" = "5" - register "generic.enable_off_delay_ms" = "100" + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" + register "generic.enable_delay_ms" = "55" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" register "generic.device_present_gpio" = "GPP_B4" @@ -325,8 +327,10 @@ register "desc" = ""Melfas Touchscreen"" register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" register "probed" = "1" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" - register "enable_delay_ms" = "5" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" + register "reset_delay_ms" = "10" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" + register "enable_delay_ms" = "55" register "has_power_resource" = "1" register "device_present_gpio" = "GPP_B4" register "device_present_gpio_invert" = "1"

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 5 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

Paul Menzel (Code Review)

21 Dec 21 Dec

2:02 p.m.

New subject: Change in coreboot[master]: mb/google/sarien: Add power control for Sarien touchscreen

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32330 )

Change subject: mb/google/sarien: Add power control for Sarien touchscreen ......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS5: I finally got a google/sarien, and in developer mode, I am having trouble with the Melfas Touchscreen (panel). Eric, can you please check if 55 ms is enough time?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 5 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 21 Dec 2021 13:02:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

EricR Lai (Code Review)

6:10 p.m.

New subject: Change in coreboot[master]: mb/google/sarien: Add power control for Sarien touchscreen

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32330 )

Change subject: mb/google/sarien: Add power control for Sarien touchscreen ......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS5: I think if's follow the spec, I can help check the latest one.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 5 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 21 Dec 2021 17:10:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

EricR Lai (Code Review)

6:11 p.m.

New subject: Change in coreboot[master]: mb/google/sarien: Add power control for Sarien touchscreen

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32330 )

Change subject: mb/google/sarien: Add power control for Sarien touchscreen ......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS5:

...

I think if's follow the spec, I can help check the latest one.

oh, typo, it's followed the spec in that time.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 5 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 21 Dec 2021 17:11:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-MessageType: comment

1068

days inactive

2048

days old

coreboot-gerrit@coreboot.org

12 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Duncan Laurie (Code Review)
EricR Lai (Code Review)
Paul Menzel (Code Review)
Simon Glass (Code Review)