EricR Lai has uploaded this change for review.

View Change

mb/google/sarein: Add power control for Sarien touchscreen

This change will save touchscreen power leakage 2-3mW in S0iX and
increase T2 display time delay to meet display panel requirement.

BUG=b:129899315
TEST= Measure touchscreen power from Sarien during S0iX

Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com>
Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0
---
M src/mainboard/google/sarien/variants/sarien/devicetree.cb
1 file changed, 14 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/32330/1
diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
index e4a92a9..bdd134a 100644
--- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb
+++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
@@ -311,10 +311,12 @@
register "generic.desc" = ""Touchscreen""
register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)"
register "generic.probed" = "1"
+ register "generic.reset_gpio" =
+ "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)"
+ register "generic.reset_delay_ms" = "10"
register "generic.enable_gpio" =
- "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)"
- register "generic.enable_delay_ms" = "5"
- register "generic.enable_off_delay_ms" = "100"
+ "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)"
+ register "generic.enable_delay_ms" = "55"
register "generic.has_power_resource" = "1"
register "hid_desc_reg_offset" = "0x0"
device i2c 10 on end
@@ -324,10 +326,12 @@
register "generic.desc" = ""ELAN Touchscreen""
register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)"
register "generic.probed" = "1"
+ register "generic.reset_gpio" =
+ "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)"
+ register "generic.reset_delay_ms" = "10"
register "generic.enable_gpio" =
- "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)"
- register "generic.enable_delay_ms" = "5"
- register "generic.enable_off_delay_ms" = "100"
+ "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)"
+ register "generic.enable_delay_ms" = "55"
register "generic.has_power_resource" = "1"
register "hid_desc_reg_offset" = "0x01"
device i2c 10 on end
@@ -337,8 +341,10 @@
register "desc" = ""Melfas Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)"
register "probed" = "1"
- register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)"
- register "enable_delay_ms" = "5"
+ register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)"
+ register "reset_delay_ms" = "10"
+ register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)"
+ register "enable_delay_ms" = "55"
register "has_power_resource" = "1"
device i2c 34 on end
end

To view, visit change 32330. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48419132ba734f20ad5cf484c2dda609570a6dd0
Gerrit-Change-Number: 32330
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-MessageType: newchange