Attention is currently required from: Paul Menzel, Subrata Banik, Andrey Petrov, Patrick Rudolph. Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59324 )
Change subject: [WIP] src/drivers/intel/fsp2_0: Add FSP 2.3 support ......................................................................
Patch Set 11:
(4 comments)
File src/drivers/intel/fsp2_0/hand_off_block.c:
https://review.coreboot.org/c/coreboot/+/59324/comment/2ec3f010_e15dbcb6 PS3, Line 24: : #ifdef CONFIG_PLATFORM_USES_FSP2_3
Hi Subrata. For the HOB changes please use the new patch :https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/59324/comment/2fde6f2d_b32553ad PS3, Line 318: return fsp_find_extension_hob_by_guid(fsp_nv_storage_guid, size);
const uint8_t fsp_nv_storage_guid_2[16] = { […]
Done
File src/drivers/intel/fsp2_0/header_display.c:
https://review.coreboot.org/c/coreboot/+/59324/comment/f319d4c1_fac6a4c8 PS3, Line 10: ext_revision.val = 0;
you don't need this
the value is expected to be zero when we print this info for FSP 2.2 and earlier. i am setting to zero to ensure this. for FSP 2.3 and later we set the value to ExtendenImageRevision in the next line of code. Sounds good ?
https://review.coreboot.org/c/coreboot/+/59324/comment/d742a633_25261279 PS3, Line 14: 6
worthwhile to make use of a macro for this ? […]
Ack
-
Anil Kumar K (Code Review)