Attention is currently required from: Paul Menzel, Subrata Banik, Andrey Petrov, Patrick Rudolph.
4 comments:
File src/drivers/intel/fsp2_0/hand_off_block.c:
#ifdef CONFIG_PLATFORM_USES_FSP2_3
Hi Subrata. For the HOB changes please use the new patch :https://review.coreboot. […]
Done
Patch Set #3, Line 318: return fsp_find_extension_hob_by_guid(fsp_nv_storage_guid, size);
const uint8_t fsp_nv_storage_guid_2[16] = { […]
Done
File src/drivers/intel/fsp2_0/header_display.c:
Patch Set #3, Line 10: ext_revision.val = 0;
you don't need this
the value is expected to be zero when we print this info for FSP 2.2 and earlier. i am setting to zero to ensure this. for FSP 2.3 and later we set the value to ExtendenImageRevision in the next line of code. Sounds good ?
worthwhile to make use of a macro for this ? […]
Ack
To view, visit change 59324. To unsubscribe, or for help writing mail filters, visit settings.