Attention is currently required from: Tian Shu Qiu, Tarun Tuli, Daniel Kang, Bingbu Cao, Dalibor Segan, Subrata Banik, Paul Menzel, Rizwan Qureshi, Kapil Porwal.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67085 )
Change subject: mb/google/rex: Set up MIPI cameras via ACPI
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/google/rex/variants/rex0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/67085/comment/90da8c74_51c46221
PS15, Line 314: Controls
clock control seems to be missed for UCAM.
Don't we need to control clock control like WCAM?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67085
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaa16e491a66500606b3a9eb1d87f396641778e0
Gerrit-Change-Number: 67085
Gerrit-PatchSet: 15
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Bingbu Cao
bingbu.cao@intel.com
Gerrit-Reviewer: Dalibor Segan
dalibor.segan@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Attention: Bingbu Cao
bingbu.cao@intel.com
Gerrit-Attention: Dalibor Segan
dalibor.segan@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Tue, 06 Sep 2022 22:54:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment