Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 62:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35523/13/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35523/13/src/mainboard/acer/aspire_... PS13, Line 18: # GPE configuration
I think you answered your own question?
Yes, I suppose :)
Skylake laptops seem to use the same GPIO communities. These are correct.
https://review.coreboot.org/c/coreboot/+/35523/13/src/mainboard/acer/aspire_... PS13, Line 150: # register "PcieRpEnable[6]" = "1"
I enabled it in the list of PCI devices and it probably doesn't hurt to enable it in general. […]
Port 7 actually backs SATA. Port 8 is NGFF.
https://review.coreboot.org/c/coreboot/+/35523/54/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35523/54/src/mainboard/acer/aspire_... PS54, Line 33: gpio_get(DGPU_PRESENT)
I haven't heard of any policy against wanting to do things properly :) […]
Of course. No idea what I thought could possibly be an issue (their copyright couldn't prevent our use)