Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39187 )
Change subject: mb/emulation/qemu-armv7: Fix board ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39187/2/src/arch/arm/armv7/bootbloc... File src/arch/arm/armv7/bootblock.S:
https://review.coreboot.org/c/coreboot/+/39187/2/src/arch/arm/armv7/bootbloc... PS2, Line 70: _ebootblock
Actually, this needs to be _eprogram, not _ebootblock (and for consistency the start should probably […]
Done
https://review.coreboot.org/c/coreboot/+/39187/2/src/arch/arm/armv7/bootbloc... PS2, Line 73: ldmia r2!, {r7-r8}
How confident are we that program segment sizes will always be divisible by 8? Is there any guarante […]
Done
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-armv7/bootblock_asm.S:
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 59: stmia r0!, {r9-r10}
Oh shit, yeah, the memcpy() for arm32 actually uses the stack. That would be why. […]
Done