View Change

3 comments:

• File src/arch/arm/armv7/bootblock.S:

  • Patch Set #2, Line 70: _ebootblock

    Actually, this needs to be _eprogram, not _ebootblock (and for consistency the start should probably […]

    Done

  • Patch Set #2, Line 73: ldmia r2!, {r7-r8}

    How confident are we that program segment sizes will always be divisible by 8? Is there any guarante […]

    Done

• File src/mainboard/emulation/qemu-armv7/bootblock_asm.S:

  • Patch Set #1, Line 59: stmia r0!, {r9-r10}

    Oh shit, yeah, the memcpy() for arm32 actually uses the stack. That would be why. […]

    Done

To view, visit change 39187. To unsubscribe, or for help writing mail filters, visit settings.