[coreboot-gerrit] Change in coreboot[master]: [RFC]arch/x86: Only use BOOTBLOCK_NORMAL with an CMOS option table

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35821 )

Change subject: [RFC]arch/x86: Only use BOOTBLOCK_NORMAL with an CMOS option table
......................................................................

Patch Set 1: Code-Review-1
> Patch Set 1:
>
> I assume you plan to use get_option() in a GCC bootblock
> implementation? Then I would make it a `depends on
> !C_ENVIRONMENT_BOOTBLOCK || USE_OPTION_TABLE`. I don't
> see why we should tie the current implementation to the
> option table.

I have only weak arguments for this one: besides that nvramtool won't work nicely.
I guess this change is too patronizing and I'm not even convinced if get_option is desirable in a GCC bootblock implementation. For instance in the grub payload, just setting a (not checksummed) rtc nvram byte is trivial and maybe it should stay that way.