Change in coreboot[master]: [RFC]arch/x86: Only use BOOTBLOCK_NORMAL with an CMOS option table

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35821 )

Change subject: [RFC]arch/x86: Only use BOOTBLOCK_NORMAL with an CMOS option table
......................................................................

[RFC]arch/x86: Only use BOOTBLOCK_NORMAL with an CMOS option table

There is no explicit dependency on an option table since the reboot
counter and the normal/fallback byte is at a fixed offset.

I don't feel strongly about imposing this...

Change-Id: I2126e71c72951d11960f5d27d25eaa838854057d
Signed-off-by: Arthur Heymans 
---
M src/arch/x86/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/35821/1

diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 502e774..9d26692 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -255,6 +255,7 @@
    bool "Always load fallback"

config BOOTBLOCK_NORMAL
+	depends on USE_OPTION_TABLE
    select CONFIGURABLE_CBFS_PREFIX
    bool "Switch to normal if CMOS says so"

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35821 )

Change subject: [RFC]arch/x86: Only use BOOTBLOCK_NORMAL with an CMOS option table
......................................................................

Patch Set 1:

I assume you plan to use get_option() in a GCC bootblock
implementation? Then I would make it a `depends on
!C_ENVIRONMENT_BOOTBLOCK || USE_OPTION_TABLE`. I don't
see why we should tie the current implementation to the
option table.

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35821 )

Change subject: [RFC]arch/x86: Only use BOOTBLOCK_NORMAL with an CMOS option table
......................................................................

Patch Set 1: Code-Review-1
> Patch Set 1:
>
> I assume you plan to use get_option() in a GCC bootblock
> implementation? Then I would make it a `depends on
> !C_ENVIRONMENT_BOOTBLOCK || USE_OPTION_TABLE`. I don't
> see why we should tie the current implementation to the
> option table.

I have only weak arguments for this one: besides that nvramtool won't work nicely.
I guess this change is too patronizing and I'm not even convinced if get_option is desirable in a GCC bootblock implementation. For instance in the grub payload, just setting a (not checksummed) rtc nvram byte is trivial and maybe it should stay that way.

[Arthur Heymans (Code Review)]

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35821 )

Change subject: [RFC]arch/x86: Only use BOOTBLOCK_NORMAL with an CMOS option table
......................................................................

Abandoned

Already in master somehow.