Patch Set 1:

I assume you plan to use get_option() in a GCC bootblock
implementation? Then I would make it a `depends on
see why we should tie the current implementation to the
option table.

I have only weak arguments for this one: besides that nvramtool won't work nicely.
I guess this change is too patronizing and I'm not even convinced if get_option is desirable in a GCC bootblock implementation. For instance in the grub payload, just setting a (not checksummed) rtc nvram byte is trivial and maybe it should stay that way.

Patch set 1:Code-Review -1

View Change

To view, visit change 35821. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2126e71c72951d11960f5d27d25eaa838854057d
Gerrit-Change-Number: 35821
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <>
Gerrit-Reviewer: Arthur Heymans <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-Comment-Date: Sun, 06 Oct 2019 13:38:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment