Attention is currently required from: Angel Pons, xin hua wang, Evgeny Zinoviev, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 )
Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ......................................................................
Patch Set 43: Code-Review+1
(10 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/32673/comment/b3c0464c_028acbf7 PS43, Line 10: and Retina Display. Some words fit on the line above?
https://review.coreboot.org/c/coreboot/+/32673/comment/696b7c15_12bd7e5e PS43, Line 12: monent moment
Patchset:
PS43: Awesome work.
File Documentation/mainboard/apple/macbookpro10_1.md:
https://review.coreboot.org/c/coreboot/+/32673/comment/b5cd9f34_32cf7adc PS43, Line 19: this script the script `get_macbook_ramcfg`
https://review.coreboot.org/c/coreboot/+/32673/comment/efdeb67f_c7960acb PS43, Line 23: ```console : $ cd util/inteltool : $ make -j4 : ``` I’d just add blank lines and indent by four spaces.
https://review.coreboot.org/c/coreboot/+/32673/comment/234961c4_40b77dda PS43, Line 30: sudo ./inteltool -g | /path/to/get_macbook_ramcfg -m mbp101 Ditto.
https://review.coreboot.org/c/coreboot/+/32673/comment/e435eb63_49965ce6 PS43, Line 42: Yes Why not bold as below?
https://review.coreboot.org/c/coreboot/+/32673/comment/4b3c58f0_22039926 PS43, Line 73: to coreboot to *the* coreboot mailing list
https://review.coreboot.org/c/coreboot/+/32673/comment/8d49dc79_add6e804 PS43, Line 97: - SeaBIOS, GRUB, TianoCore Please add the versions.
File src/mainboard/apple/macbookpro10_1/early_init.c:
https://review.coreboot.org/c/coreboot/+/32673/comment/84783d91_c7a2751b PS43, Line 96: die("Unsupported memory, RAMCFG=%d\n", ramcfg);
… Please contact the coreboot mailing list.