Change in ...coreboot[master]: mb/apple: Add MacBook Pro 10,1 (A1398) support
Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32673 Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro Retina 15 (Mid 2012) with Ivy Bridge CPU. This is WIP. Not for merging. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- M 3rdparty/vboot A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/romstage.c 16 files changed, 758 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/1 diff --git a/3rdparty/vboot b/3rdparty/vboot index e7edff6..304aa42 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit e7edff6653e16ed915c3ad12234d133d1ef4dcc9 +Subproject commit 304aa429c1a04cda3ab2ce37b9e31af84405bfca diff --git a/src/mainboard/apple/macbookpro10_1/Kconfig b/src/mainboard/apple/macbookpro10_1/Kconfig new file mode 100644 index 0000000..603f3ee --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/Kconfig @@ -0,0 +1,46 @@ +if BOARD_APPLE_MACBOOKPRO10_1 + +config BOARD_SPECIFIC_OPTIONS + def_bool y + select BOARD_ROMSIZE_KB_8192 + select EC_ACPI + select HAVE_ACPI_RESUME + select HAVE_ACPI_TABLES + select INTEL_INT15 + select NORTHBRIDGE_INTEL_IVYBRIDGE + select SERIRQ_CONTINUOUS_MODE + select SOUTHBRIDGE_INTEL_C216 + select SYSTEM_TYPE_LAPTOP + select USE_NATIVE_RAMINIT + select MAINBOARD_HAS_LIBGFXINIT + select GFX_GMA_INTERNAL_IS_EDP + select SERIRQ_CONTINUOUS_MODE + +config MAINBOARD_DIR + string + default apple/macbookpro10_1 + +config MAINBOARD_PART_NUMBER + string + default "MacBookPro10,1" + +config VGA_BIOS_FILE + string + default "pci8086,0166.rom" + +config VGA_BIOS_ID + string + default "8086,0166" + +config DRAM_RESET_GATE_GPIO + int + default 28 + +config MAX_CPUS + int + default 8 + +config USBDEBUG_HCD_INDEX # FIXME: check this + int + default 2 +endif diff --git a/src/mainboard/apple/macbookpro10_1/Kconfig.name b/src/mainboard/apple/macbookpro10_1/Kconfig.name new file mode 100644 index 0000000..c257f7a --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/Kconfig.name @@ -0,0 +1,2 @@ +config BOARD_APPLE_MACBOOKPRO10_1 + bool "MacBookPro10,1" diff --git a/src/mainboard/apple/macbookpro10_1/Makefile.inc b/src/mainboard/apple/macbookpro10_1/Makefile.inc new file mode 100644 index 0000000..fd60338 --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/Makefile.inc @@ -0,0 +1,7 @@ +romstage-y += gpio.c + +cbfs-files-y += spd.bin +spd.bin-file := spd.bin +spd.bin-type := spd + +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/apple/macbookpro10_1/acpi/ec.asl b/src/mainboard/apple/macbookpro10_1/acpi/ec.asl new file mode 100644 index 0000000..f70cb3d --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/acpi/ec.asl @@ -0,0 +1,20 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +Device(EC) +{ + Name (_HID, EISAID("PNP0C09")) + Name (_UID, 0) + Name (_GPE, 23) +/* FIXME: EC support */ +} diff --git a/src/mainboard/apple/macbookpro10_1/acpi/platform.asl b/src/mainboard/apple/macbookpro10_1/acpi/platform.asl new file mode 100644 index 0000000..a17c6ea --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/acpi/platform.asl @@ -0,0 +1,23 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +Method(_WAK,1) +{ + /* FIXME: EC support */ + Return(Package(){0,0}) +} + +Method(_PTS,1) +{ + /* FIXME: EC support */ +} diff --git a/src/mainboard/apple/macbookpro10_1/acpi/superio.asl b/src/mainboard/apple/macbookpro10_1/acpi/superio.asl new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/acpi/superio.asl diff --git a/src/mainboard/apple/macbookpro10_1/acpi_tables.c b/src/mainboard/apple/macbookpro10_1/acpi_tables.c new file mode 100644 index 0000000..c48f0bd --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/acpi_tables.c @@ -0,0 +1,33 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <southbridge/intel/bd82x6x/nvs.h> + +/* FIXME: check this function. */ +void acpi_create_gnvs(global_nvs_t *gnvs) +{ + /* Disable USB ports in S3 by default */ + gnvs->s3u0 = 0; + gnvs->s3u1 = 0; + + /* Disable USB ports in S5 by default */ + gnvs->s5u0 = 0; + gnvs->s5u1 = 0; + + // the lid is open by default. + gnvs->lids = 1; + + gnvs->tcrt = 100; + gnvs->tpsv = 90; +} diff --git a/src/mainboard/apple/macbookpro10_1/board_info.txt b/src/mainboard/apple/macbookpro10_1/board_info.txt new file mode 100644 index 0000000..81a5134 --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/board_info.txt @@ -0,0 +1,6 @@ +Category: laptop +ROM protocol: SPI +Flashrom support: n +ROM package: SOIC-8 +ROM socketed: n +Release year: 2012 diff --git a/src/mainboard/apple/macbookpro10_1/devicetree.cb b/src/mainboard/apple/macbookpro10_1/devicetree.cb new file mode 100644 index 0000000..f9e7eb4 --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/devicetree.cb @@ -0,0 +1,124 @@ +chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did + #register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }" + register "gfx.did" = "{ 0x80000410, 0x80000320, 0x80000410, 0x80000410, 0x00000005 }" + register "gfx.link_frequency_270_mhz" = "0" + register "gfx.ndid" = "3" + register "gfx.use_spread_spectrum_clock" = "1" + register "gpu_cpu_backlight" = "0xffffffff" + register "gpu_dp_b_hotplug" = "7" + register "gpu_dp_c_hotplug" = "7" + register "gpu_dp_d_hotplug" = "7" + register "gpu_panel_port_select" = "3" + register "gpu_panel_power_backlight_off_delay" = "8191" + register "gpu_panel_power_backlight_on_delay" = "8191" + register "gpu_panel_power_cycle_delay" = "255" + register "gpu_panel_power_down_delay" = "8191" + register "gpu_panel_power_up_delay" = "8191" + register "gpu_pch_backlight" = "0xffffffff" + device cpu_cluster 0x0 on + chip cpu/intel/model_206ax # FIXME: check all registers + register "c1_acpower" = "1" + register "c1_battery" = "1" + register "c2_acpower" = "3" + register "c2_battery" = "3" + register "c3_acpower" = "5" + register "c3_battery" = "5" + device lapic 0x0 on + end + device lapic 0xacac off + end + end + end + device domain 0x0 on + chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH + register "c2_latency" = "0x0065" + register "docking_supported" = "0" + register "gen1_dec" = "0x000c0681" + register "gen2_dec" = "0x000c1641" + register "gen3_dec" = "0x001c0301" + register "gen4_dec" = "0x00fc0701" + register "gpi7_routing" = "2" + register "p_cnt_throttling_supported" = "1" + register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" + register "pcie_port_coalesce" = "1" + register "sata_interface_speed_support" = "0x3" + register "sata_port_map" = "0x1" + register "spi_lvscc" = "0x0" + register "spi_uvscc" = "0x2005" + register "superspeed_capable_ports" = "0x0000000f" + register "xhci_overcurrent_mapping" = "0x08040201" + register "xhci_switchable_ports" = "0x0000000f" + device pci 14.0 on # USB 3.0 Controller + subsystemid 0x8086 0x7270 + end + device pci 16.0 on # Management Engine Interface 1 + subsystemid 0x8086 0x7270 + end + device pci 16.1 off # Management Engine Interface 2 + end + device pci 16.2 off # Management Engine IDE-R + end + device pci 16.3 off # Management Engine KT + end + device pci 19.0 off # Intel Gigabit Ethernet + end + device pci 1a.0 on # USB2 EHCI #2 + subsystemid 0x8086 0x7270 + end + device pci 1b.0 on # High Definition Audio Audio controller + subsystemid 0x8086 0x7270 + end + device pci 1c.0 on # PCIe Port #1 + subsystemid 0x8086 0x7270 + end + device pci 1c.1 on # PCIe Port #2 + subsystemid 0x8086 0x7270 + end + device pci 1c.2 off # PCIe Port #3 + end + device pci 1c.3 off # PCIe Port #4 + end + device pci 1c.4 off # PCIe Port #5 + end + device pci 1c.5 off # PCIe Port #6 + end + device pci 1c.6 off # PCIe Port #7 + end + device pci 1c.7 off # PCIe Port #8 + end + device pci 1d.0 on # USB2 EHCI #1 + subsystemid 0x8086 0x7270 + end + device pci 1e.0 off # PCI bridge + end + device pci 1f.0 on # LPC bridge PCI-LPC bridge + subsystemid 0x8086 0x7270 + end + device pci 1f.2 on # SATA Controller 1 + subsystemid 0x8086 0x7270 + end + device pci 1f.3 on # SMBus + subsystemid 0x8086 0x7270 + end + device pci 1f.5 off # SATA Controller 2 + end + device pci 1f.6 off # Thermal + end + end + device pci 00.0 on # Host bridge Host bridge + subsystemid 0x106b 0x00f7 + end + device pci 01.0 on # PCIe Bridge for discrete graphics + subsystemid 0x106b 0x00f7 + end + device pci 02.0 on # Internal graphics VGA controller + subsystemid 0x106b 0x00f7 + end + device pci 01.2 on + subsystemid 0x106b 0x00f7 + end + device pci 01.1 on + subsystemid 0x106b 0x00f7 + end + end +end diff --git a/src/mainboard/apple/macbookpro10_1/dsdt.asl b/src/mainboard/apple/macbookpro10_1/dsdt.asl new file mode 100644 index 0000000..455ac17 --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/dsdt.asl @@ -0,0 +1,42 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB +#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB +#define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 + +#include <arch/acpi.h> +DefinitionBlock( + "dsdt.aml", + "DSDT", + 0x02, // DSDT revision: ACPI 2.0 and up + OEM_ID, + ACPI_TABLE_CREATOR, + 0x20141018 // OEM revision +) +{ + /* Some generic macros */ + #include "acpi/platform.asl" + #include <cpu/intel/common/acpi/cpu.asl> + #include <southbridge/intel/bd82x6x/acpi/platform.asl> + /* global NVS and variables. */ + #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> + #include <southbridge/intel/bd82x6x/acpi/sleepstates.asl> + + Device (\_SB.PCI0) + { + #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + #include <southbridge/intel/bd82x6x/acpi/pch.asl> + } +} diff --git a/src/mainboard/apple/macbookpro10_1/gma-mainboard.ads b/src/mainboard/apple/macbookpro10_1/gma-mainboard.ads new file mode 100644 index 0000000..d4a5d7d --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/gma-mainboard.ads @@ -0,0 +1,34 @@ +-- +-- This file is part of the coreboot project. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 2 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- + +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + + ports : constant Port_List := + (DP1, + DP2, + DP3, + HDMI1, + HDMI2, + HDMI3, + Analog, + Internal, + others => Disabled); + +end GMA.Mainboard; diff --git a/src/mainboard/apple/macbookpro10_1/gpio.c b/src/mainboard/apple/macbookpro10_1/gpio.c new file mode 100644 index 0000000..a445687 --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/gpio.c @@ -0,0 +1,243 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <southbridge/intel/common/gpio.h> + +static const struct pch_gpio_set1 pch_gpio_set1_mode = { + .gpio0 = GPIO_MODE_GPIO, + .gpio1 = GPIO_MODE_GPIO, + .gpio2 = GPIO_MODE_GPIO, + .gpio3 = GPIO_MODE_GPIO, + .gpio4 = GPIO_MODE_GPIO, + .gpio5 = GPIO_MODE_GPIO, + .gpio6 = GPIO_MODE_GPIO, + .gpio7 = GPIO_MODE_GPIO, + .gpio8 = GPIO_MODE_GPIO, + .gpio9 = GPIO_MODE_NATIVE, + .gpio10 = GPIO_MODE_GPIO, + .gpio11 = GPIO_MODE_GPIO, + .gpio12 = GPIO_MODE_GPIO, + .gpio13 = GPIO_MODE_GPIO, + .gpio14 = GPIO_MODE_GPIO, + .gpio15 = GPIO_MODE_GPIO, + .gpio16 = GPIO_MODE_GPIO, + .gpio17 = GPIO_MODE_GPIO, + .gpio18 = GPIO_MODE_NATIVE, + .gpio19 = GPIO_MODE_GPIO, + .gpio20 = GPIO_MODE_NATIVE, + .gpio21 = GPIO_MODE_GPIO, + .gpio22 = GPIO_MODE_GPIO, + .gpio23 = GPIO_MODE_GPIO, + .gpio24 = GPIO_MODE_GPIO, + .gpio25 = GPIO_MODE_NATIVE, + .gpio26 = GPIO_MODE_GPIO, + .gpio27 = GPIO_MODE_GPIO, + .gpio28 = GPIO_MODE_GPIO, + .gpio29 = GPIO_MODE_GPIO, + .gpio30 = GPIO_MODE_NATIVE, + .gpio31 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_direction = { + .gpio0 = GPIO_DIR_INPUT, + .gpio1 = GPIO_DIR_INPUT, + .gpio2 = GPIO_DIR_INPUT, + .gpio3 = GPIO_DIR_INPUT, + .gpio4 = GPIO_DIR_INPUT, + .gpio5 = GPIO_DIR_INPUT, + .gpio6 = GPIO_DIR_INPUT, + .gpio7 = GPIO_DIR_INPUT, + .gpio8 = GPIO_DIR_OUTPUT, + .gpio10 = GPIO_DIR_INPUT, + .gpio11 = GPIO_DIR_INPUT, + .gpio12 = GPIO_DIR_OUTPUT, + .gpio13 = GPIO_DIR_INPUT, + .gpio14 = GPIO_DIR_INPUT, + .gpio15 = GPIO_DIR_OUTPUT, + .gpio16 = GPIO_DIR_OUTPUT, + .gpio17 = GPIO_DIR_INPUT, + .gpio19 = GPIO_DIR_OUTPUT, + .gpio21 = GPIO_DIR_OUTPUT, + .gpio22 = GPIO_DIR_OUTPUT, + .gpio23 = GPIO_DIR_OUTPUT, + .gpio24 = GPIO_DIR_OUTPUT, + .gpio26 = GPIO_DIR_INPUT, + .gpio27 = GPIO_DIR_INPUT, + .gpio28 = GPIO_DIR_OUTPUT, + .gpio29 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_level = { + .gpio8 = GPIO_LEVEL_HIGH, + .gpio12 = GPIO_LEVEL_LOW, + .gpio15 = GPIO_LEVEL_HIGH, + .gpio16 = GPIO_LEVEL_LOW, + .gpio19 = GPIO_LEVEL_HIGH, + .gpio21 = GPIO_LEVEL_LOW, + .gpio22 = GPIO_LEVEL_LOW, + .gpio23 = GPIO_LEVEL_HIGH, + .gpio24 = GPIO_LEVEL_LOW, + .gpio28 = GPIO_LEVEL_HIGH, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_reset = { + .gpio11 = GPIO_RESET_RSMRST, + .gpio15 = GPIO_RESET_RSMRST, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_invert = { + .gpio1 = GPIO_INVERT, + .gpio2 = GPIO_INVERT, + .gpio4 = GPIO_INVERT, + .gpio5 = GPIO_INVERT, + .gpio7 = GPIO_INVERT, + .gpio14 = GPIO_INVERT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_blink = { +}; + +static const struct pch_gpio_set2 pch_gpio_set2_mode = { + .gpio32 = GPIO_MODE_NATIVE, + .gpio33 = GPIO_MODE_GPIO, + .gpio34 = GPIO_MODE_GPIO, + .gpio35 = GPIO_MODE_GPIO, + .gpio36 = GPIO_MODE_GPIO, + .gpio37 = GPIO_MODE_GPIO, + .gpio38 = GPIO_MODE_GPIO, + .gpio39 = GPIO_MODE_GPIO, + .gpio40 = GPIO_MODE_NATIVE, + .gpio41 = GPIO_MODE_NATIVE, + .gpio42 = GPIO_MODE_NATIVE, + .gpio43 = GPIO_MODE_NATIVE, + .gpio44 = GPIO_MODE_NATIVE, + .gpio45 = GPIO_MODE_NATIVE, + .gpio46 = GPIO_MODE_NATIVE, + .gpio47 = GPIO_MODE_GPIO, + .gpio48 = GPIO_MODE_GPIO, + .gpio49 = GPIO_MODE_GPIO, + .gpio50 = GPIO_MODE_GPIO, + .gpio51 = GPIO_MODE_GPIO, + .gpio52 = GPIO_MODE_GPIO, + .gpio53 = GPIO_MODE_GPIO, + .gpio54 = GPIO_MODE_GPIO, + .gpio55 = GPIO_MODE_GPIO, + .gpio56 = GPIO_MODE_GPIO, + .gpio57 = GPIO_MODE_GPIO, + .gpio58 = GPIO_MODE_NATIVE, + .gpio59 = GPIO_MODE_NATIVE, + .gpio60 = GPIO_MODE_GPIO, + .gpio61 = GPIO_MODE_NATIVE, + .gpio62 = GPIO_MODE_NATIVE, + .gpio63 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_direction = { + .gpio33 = GPIO_DIR_INPUT, + .gpio34 = GPIO_DIR_OUTPUT, + .gpio35 = GPIO_DIR_OUTPUT, + .gpio36 = GPIO_DIR_OUTPUT, + .gpio37 = GPIO_DIR_INPUT, + .gpio38 = GPIO_DIR_INPUT, + .gpio39 = GPIO_DIR_INPUT, + .gpio47 = GPIO_DIR_INPUT, + .gpio48 = GPIO_DIR_OUTPUT, + .gpio49 = GPIO_DIR_OUTPUT, + .gpio50 = GPIO_DIR_INPUT, + .gpio51 = GPIO_DIR_OUTPUT, + .gpio52 = GPIO_DIR_OUTPUT, + .gpio53 = GPIO_DIR_OUTPUT, + .gpio54 = GPIO_DIR_OUTPUT, + .gpio55 = GPIO_DIR_OUTPUT, + .gpio56 = GPIO_DIR_INPUT, + .gpio57 = GPIO_DIR_INPUT, + .gpio60 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_level = { + .gpio34 = GPIO_LEVEL_HIGH, + .gpio35 = GPIO_LEVEL_LOW, + .gpio36 = GPIO_LEVEL_LOW, + .gpio48 = GPIO_LEVEL_HIGH, + .gpio49 = GPIO_LEVEL_HIGH, + .gpio51 = GPIO_LEVEL_HIGH, + .gpio52 = GPIO_LEVEL_LOW, + .gpio53 = GPIO_LEVEL_HIGH, + .gpio54 = GPIO_LEVEL_LOW, + .gpio55 = GPIO_LEVEL_HIGH, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_reset = { +}; + +static const struct pch_gpio_set3 pch_gpio_set3_mode = { + .gpio64 = GPIO_MODE_GPIO, + .gpio65 = GPIO_MODE_GPIO, + .gpio66 = GPIO_MODE_GPIO, + .gpio67 = GPIO_MODE_GPIO, + .gpio68 = GPIO_MODE_GPIO, + .gpio69 = GPIO_MODE_GPIO, + .gpio70 = GPIO_MODE_GPIO, + .gpio71 = GPIO_MODE_GPIO, + .gpio72 = GPIO_MODE_NATIVE, + .gpio73 = GPIO_MODE_GPIO, + .gpio74 = GPIO_MODE_GPIO, + .gpio75 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_direction = { + .gpio64 = GPIO_DIR_OUTPUT, + .gpio65 = GPIO_DIR_OUTPUT, + .gpio66 = GPIO_DIR_OUTPUT, + .gpio67 = GPIO_DIR_OUTPUT, + .gpio68 = GPIO_DIR_INPUT, + .gpio69 = GPIO_DIR_INPUT, + .gpio70 = GPIO_DIR_INPUT, + .gpio71 = GPIO_DIR_INPUT, + .gpio73 = GPIO_DIR_INPUT, + .gpio74 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_level = { + .gpio64 = GPIO_LEVEL_LOW, + .gpio65 = GPIO_LEVEL_LOW, + .gpio66 = GPIO_LEVEL_LOW, + .gpio67 = GPIO_LEVEL_LOW, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_reset = { +}; + +const struct pch_gpio_map mainboard_gpio_map = { + .set1 = { + .mode = &pch_gpio_set1_mode, + .direction = &pch_gpio_set1_direction, + .level = &pch_gpio_set1_level, + .blink = &pch_gpio_set1_blink, + .invert = &pch_gpio_set1_invert, + .reset = &pch_gpio_set1_reset, + }, + .set2 = { + .mode = &pch_gpio_set2_mode, + .direction = &pch_gpio_set2_direction, + .level = &pch_gpio_set2_level, + .reset = &pch_gpio_set2_reset, + }, + .set3 = { + .mode = &pch_gpio_set3_mode, + .direction = &pch_gpio_set3_direction, + .level = &pch_gpio_set3_level, + .reset = &pch_gpio_set3_reset, + }, +}; diff --git a/src/mainboard/apple/macbookpro10_1/hda_verb.c b/src/mainboard/apple/macbookpro10_1/hda_verb.c new file mode 100644 index 0000000..b8e4855 --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/hda_verb.c @@ -0,0 +1,58 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <device/azalia_device.h> + +const u32 cim_verb_data[] = { + 0x10134206, /* Codec Vendor / Device ID: Cirrus */ + 0x106b2800, /* Subsystem ID */ + + 0x0000000b, /* Number of 4 dword sets */ + /* NID 0x01: Subsystem ID. */ + AZALIA_SUBVENDOR(0x0, 0x106b2800), + + /* NID 0x09. */ + AZALIA_PIN_CFG(0x0, 0x09, 0x002b4020), + + /* NID 0x0a. */ + AZALIA_PIN_CFG(0x0, 0x0a, 0x90100112), + + /* NID 0x0b. */ + AZALIA_PIN_CFG(0x0, 0x0b, 0x90100110), + + /* NID 0x0c. */ + AZALIA_PIN_CFG(0x0, 0x0c, 0x400000f0), + + /* NID 0x0d. */ + AZALIA_PIN_CFG(0x0, 0x0d, 0x400000f0), + + /* NID 0x0e. */ + AZALIA_PIN_CFG(0x0, 0x0e, 0x90a60100), + + /* NID 0x0f. */ + AZALIA_PIN_CFG(0x0, 0x0f, 0x400000f0), + + /* NID 0x10. */ + AZALIA_PIN_CFG(0x0, 0x10, 0x004be030), + + /* NID 0x12. */ + AZALIA_PIN_CFG(0x0, 0x12, 0x400000f0), + + /* NID 0x15. */ + AZALIA_PIN_CFG(0x0, 0x15, 0x400000f0), +}; + +const u32 pc_beep_verbs[0] = {}; + +AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/apple/macbookpro10_1/mainboard.c b/src/mainboard/apple/macbookpro10_1/mainboard.c new file mode 100644 index 0000000..3910541 --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/mainboard.c @@ -0,0 +1,37 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <device/device.h> +#include <drivers/intel/gma/int15.h> +#include <southbridge/intel/bd82x6x/pch.h> +#include <ec/acpi/ec.h> +#include <console/console.h> + +static void mainboard_init(struct device *dev) +{ + +} + +static void mainboard_enable(struct device *dev) +{ + dev->ops->init = mainboard_init; + + /* FIXME: fix those values*/ + install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, + GMA_INT15_PANEL_FIT_DEFAULT, + GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); +} + +struct chip_operations mainboard_ops = { + .enable_dev = mainboard_enable, +}; diff --git a/src/mainboard/apple/macbookpro10_1/romstage.c b/src/mainboard/apple/macbookpro10_1/romstage.c new file mode 100644 index 0000000..c35604b --- /dev/null +++ b/src/mainboard/apple/macbookpro10_1/romstage.c @@ -0,0 +1,82 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +/* FIXME: Check if all includes are needed. */ + +#include <stdint.h> +#include <string.h> +#include <timestamp.h> +#include <arch/byteorder.h> +#include <arch/io.h> +#include <device/mmio.h> +#include <device/pci_ops.h> +#include <device/pnp_ops.h> +#include <console/console.h> +#include <northbridge/intel/sandybridge/sandybridge.h> +#include <northbridge/intel/sandybridge/raminit_native.h> +#include <southbridge/intel/bd82x6x/pch.h> +#include <southbridge/intel/common/gpio.h> +#include <cbfs.h> + +void pch_enable_lpc(void) +{ + pci_write_config16(PCH_LPC_DEV, 0x82, 0x3f0f); + pci_write_config32(PCH_LPC_DEV, 0x84, 0x000c0681); + pci_write_config32(PCH_LPC_DEV, 0x88, 0x000c1641); + pci_write_config32(PCH_LPC_DEV, 0x8c, 0x001c0301); + pci_write_config32(PCH_LPC_DEV, 0x90, 0x00fc0701); + pci_write_config16(PCH_LPC_DEV, 0x80, 0x0070); +} + +void mainboard_rcba_config(void) +{ +} + +const struct southbridge_usb_port mainboard_usb_ports[] = { + { 1, 0, 0 }, + { 1, 0, 1 }, + { 1, 0, 2 }, + { 1, 0, 3 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, +}; + +void mainboard_early_init(int s3resume) +{ +} + +void mainboard_config_superio(void) +{ +} + +// FIXME +void mainboard_get_spd(spd_raw_data *spd, bool id_only) +{ + void *spd_file; + size_t spd_file_len = 0; + spd_file = cbfs_boot_map_with_leak("spd.bin", CBFS_TYPE_SPD, + &spd_file_len); + if (spd_file && spd_file_len >= 128) { + memcpy(&spd[0], spd_file, 128); + memcpy(&spd[2], spd_file, 128); + } +} -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> Gerrit-MessageType: newchange
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#2). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro Retina 15 (Mid 2012) with Ivy Bridge CPU. This is WIP. Not for merging. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/romstage.c A src/mainboard/apple/macbookpro10_1/spd.bin 16 files changed, 757 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#3). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro Retina 15 (Mid 2012) with Ivy Bridge CPU. This is WIP. Not for merge. Current state: - coreboot works, but no graphics; need to support gmux Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/romstage.c A src/mainboard/apple/macbookpro10_1/spd.bin 16 files changed, 756 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 3 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 21: Works well, seems stable, ready for review. It's much better than Apple's firmware I must say. It's a real pain to use iGPU on Linux under Apple UEFI, as it enforces dGPU if anything other than macOS was booted. There are many guides on the internet how to work around that but none of them worked for me, perhaps they just don't work with newer firmware versions. Now, with coreboot, it Just Works (TM), just as Steve used to say. -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 21 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 02 Jun 2019 13:39:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 22: (1 comment) https://review.coreboot.org/#/c/32673/22/src/mainboard/apple/macbookpro10_1/... File src/mainboard/apple/macbookpro10_1/romstage.c: https://review.coreboot.org/#/c/32673/22/src/mainboard/apple/macbookpro10_1/... PS22, Line 82: void mainboard_get_spd(spd_raw_data *spd, bool id_only) there are probably versions with different amount of ram. How to detect the amount of ram soldered on the board and use the right spd image for that ram? -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 22 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 04 Jun 2019 11:36:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 22: (1 comment) https://review.coreboot.org/#/c/32673/22/src/mainboard/apple/macbookpro10_1/... File src/mainboard/apple/macbookpro10_1/romstage.c: https://review.coreboot.org/#/c/32673/22/src/mainboard/apple/macbookpro10_1/... PS22, Line 82: void mainboard_get_spd(spd_raw_data *spd, bool id_only)
there are probably versions with different amount of ram. […] Yes, it seems it was possible to buy version with 16G RAM soldered. I have no idea at the moment, would be great to find such a machine and test. I wonder, are there existing mainboards in coreboot's tree with similar case?
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 22 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 04 Jun 2019 13:55:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 22: (1 comment) https://review.coreboot.org/#/c/32673/22/src/mainboard/apple/macbookpro10_1/... File src/mainboard/apple/macbookpro10_1/romstage.c: https://review.coreboot.org/#/c/32673/22/src/mainboard/apple/macbookpro10_1/... PS22, Line 82: void mainboard_get_spd(spd_raw_data *spd, bool id_only)
Yes, it seems it was possible to buy version with 16G RAM soldered. […] lenovo/x1_carbon_gen1 does that; IIRC also pcengines/apu2 and i think also some chromebooks. I'd suggest having a look at the schematics if there are some resistors that tell the firmware what ram is soldered down.
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 22 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 04 Jun 2019 14:21:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 22: (1 comment) https://review.coreboot.org/#/c/32673/22/src/mainboard/apple/macbookpro10_1/... File src/mainboard/apple/macbookpro10_1/romstage.c: https://review.coreboot.org/#/c/32673/22/src/mainboard/apple/macbookpro10_1/... PS22, Line 82: void mainboard_get_spd(spd_raw_data *spd, bool id_only)
lenovo/x1_carbon_gen1 does that; IIRC also pcengines/apu2 and i think also some chromebooks. […] RAMCFG[0..3] indicate what RAM is soldered down; also connected to PCH GPIOs on this device
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 22 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 04 Jun 2019 15:38:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 22: (21 comments) https://review.coreboot.org/c/coreboot/+/32673/22//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/32673/22//COMMIT_MSG@7 PS22, Line 7: A1398 I found out that these model numbers are not precise enough. A1418, for instance, came with at least four different mainboards. I would recommend using the EMC number (e.g. EMC 2544), or the mainboard model number (820-3302) https://review.coreboot.org/c/coreboot/+/32673/22//COMMIT_MSG@10 PS22, Line 10: : What works: : - libgfxinit : - VGA ROM loading : - Integrated GPU : - Discrete GPU : - SeaBIOS, GRUB, Tianocore : - Linux (devuan ascii, kernel 4.9) : - Wi-Fi : - Both USB ports : - Trackpad : - me_cleaner : - Integrated/Discrete graphics selection via nvramtool : - Camera : - Mic : - SD card reader : - Speaker : - Headphones : - usbdebug (the usb port on the right side) : - Backlight control via gmux (/sys/class/backlight/gmux_backlight) Maybe add some documentation and move this list there? What about untested / non-working things? https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/Kconfig: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 17: SERIRQ_CONTINUOUS_MODE Already selected on line 11 https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 16: FIXME Has this been fixed? https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 17: /* FIXME: check this function. */ Has it been checked? https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 28: // the lid is open by default. Please be consistent with the comment style https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/cmos.layout: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 75: gfx_uma_size This option should not be commented out https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 2: { 0x80000410, 0x80000320, 0x80000410, 0x80000410, 0x00000005 } Please trim to size (gfx.ndid) https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 41: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" This can be dropped https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 63: Audio Audio Much audio? I guess this is duplicated https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 83: PCI-LPC bridge Can drop this part https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 99: Host bridge Host bridge Host bridge much? I guess it's duplicated https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 98: : device pci 00.0 on # Host bridge Host bridge : subsystemid 0x106b 0x00f7 : end : device pci 01.0 on # PCIe Bridge for discrete graphics : subsystemid 0x106b 0x00f7 : end : device pci 02.0 on # Internal graphics VGA controller : subsystemid 0x106b 0x00f7 : end Move these before the southbridge "chip" entry https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 108: device pci 01.2 on : subsystemid 0x106b 0x00f7 : end : device pci 01.1 on : subsystemid 0x106b 0x00f7 : end What is this? https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 30: Analog Hmm? https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 25: /* NID 0x09. */ Please get rid of these obnoxious comments https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 30: LVDS But you said GFX_GMA_INTERNAL_IS_EDP in Kconfig! https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/romstage.c: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 26: pci_write_config16(PCH_LPC_DEV, 0x82, 0x3f0f); : pci_write_config32(PCH_LPC_DEV, 0x84, 0x000c0681); : pci_write_config32(PCH_LPC_DEV, 0x88, 0x000c1641); : pci_write_config32(PCH_LPC_DEV, 0x8c, 0x001c0301); : pci_write_config32(PCH_LPC_DEV, 0x90, 0x00fc0701); : pci_write_config16(PCH_LPC_DEV, 0x80, 0x0070); There are macros for these https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 72: /* Disable IGD VGA decode, no GTT or GFX stolen */ : pci_write_config16(PCI_DEV(0, 0, 0), GGC, 2); This is confusing without braces on the if/else https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 87: &spd_file_len); Fits on the previous line https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 88: (spd_file && spd_file_len >= 128) So, if this check is false, what's the chances of the machine booting successfully? I'm not an expert, but I'd say... ZILCH! I would then suggest placing a die() here, with a message along the lines of: "reading spd file failed" -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 22 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 29 Oct 2019 09:51:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 22: (20 comments) https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/Kconfig: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 29: : config VGA_BIOS_FILE : string : default "pci8086,0166.rom" : : config VGA_BIOS_ID : string : default "8086,0166" Is the VBIOS tested? https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/Makefile.inc: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 1: romstage-y += gpio.c Note that currently, this also needs to be built for the bootblock https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 2: : cbfs-files-y += spd.bin : spd.bin-file := spd.bin : spd.bin-type := spd This could use the GENERIC_SPD mechanism. See CB:32604 for details https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 20: /* Disable USB ports in S3 by default */ : gnvs->s3u0 = 0; : gnvs->s3u1 = 0; : : /* Disable USB ports in S5 by default */ : gnvs->s5u0 = 0; : gnvs->s5u1 = 0; These are zero and can be dropped https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 2: { 0x80000410, 0x80000320, 0x80000410, 0x80000410, 0x00000005 }
Please trim to size (gfx. […] Better yet: drop it altogether.
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 18: 0x0 0 https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 26: 0x0 0 https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 31: 0x0 0 https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 33: : register "docking_supported" = "0" These are zero and can be dropped https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 39: : register "p_cnt_throttling_supported" = "1" This no longer exists on master https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 51: subsystemid 0x8086 0x7270 This can be factored out https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 108: device pci 01.2 on : subsystemid 0x106b 0x00f7 : end : device pci 01.1 on : subsystemid 0x106b 0x00f7 : end
What is this? This means that PEG is muxed in three: x16 ---> x8, x4, x4
It would be nice to comment what is connected to each of these. https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 14: #define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB : #define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB : #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 Are these used? https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 28: /* Some generic macros */ Please remove this. I killed all instances of this comment in a previous change. https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 31: #include <southbridge/intel/bd82x6x/acpi/platform.asl> : /* global NVS and variables. */ : #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> : #include <southbridge/intel/bd82x6x/acpi/sleepstates.asl> Note that some of these are now under common/ https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 21: 0x0000000b This should be decimal https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 23: 0x0 This too https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 30: LVDS
But you said GFX_GMA_INTERNAL_IS_EDP in Kconfig! If not using the VBIOS, you can drop the entire file.
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/romstage.c: PS22: This is now called early_init.c, and needs to be built for romstage and bootblock https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 64: DEVEN_PEG10 Note that, since the PEG port is muxed, disabling function 0 could break some stuff -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 22 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 01 Feb 2020 14:54:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Hello Angel Pons, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#23). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012) with Ivy Bridge CPU and Retina Display. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd.bin 21 files changed, 875 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/23 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 23 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 23: (1 comment) https://review.coreboot.org/c/coreboot/+/32673/23/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/early_init.c: https://review.coreboot.org/c/coreboot/+/32673/23/src/mainboard/apple/macboo... PS23, Line 71: if (!spd_file || spd_file_len < 128) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 23 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 02 Feb 2020 21:55:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 23: (34 comments) https://review.coreboot.org/c/coreboot/+/32673/22//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/32673/22//COMMIT_MSG@7 PS22, Line 7: A1398
I found out that these model numbers are not precise enough. […] Done
https://review.coreboot.org/c/coreboot/+/32673/22//COMMIT_MSG@10 PS22, Line 10: : What works: : - libgfxinit : - VGA ROM loading : - Integrated GPU : - Discrete GPU : - SeaBIOS, GRUB, Tianocore : - Linux (devuan ascii, kernel 4.9) : - Wi-Fi : - Both USB ports : - Trackpad : - me_cleaner : - Integrated/Discrete graphics selection via nvramtool : - Camera : - Mic : - SD card reader : - Speaker : - Headphones : - usbdebug (the usb port on the right side) : - Backlight control via gmux (/sys/class/backlight/gmux_backlight)
Maybe add some documentation and move this list there? […] Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/Kconfig: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 17: SERIRQ_CONTINUOUS_MODE
Already selected on line 11 Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 29: : config VGA_BIOS_FILE : string : default "pci8086,0166.rom" : : config VGA_BIOS_ID : string : default "8086,0166"
Is the VBIOS tested? On this one, yes.
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/Makefile.inc: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 1: romstage-y += gpio.c
Note that currently, this also needs to be built for the bootblock Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 16: FIXME
Has this been fixed? Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 17: /* FIXME: check this function. */
Has it been checked? Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 20: /* Disable USB ports in S3 by default */ : gnvs->s3u0 = 0; : gnvs->s3u1 = 0; : : /* Disable USB ports in S5 by default */ : gnvs->s5u0 = 0; : gnvs->s5u1 = 0;
These are zero and can be dropped Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 28: // the lid is open by default.
Please be consistent with the comment style Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/cmos.layout: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 75: gfx_uma_size
This option should not be commented out Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 2: { 0x80000410, 0x80000320, 0x80000410, 0x80000410, 0x00000005 }
Better yet: drop it altogether. Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 18: 0x0
0 Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 26: 0x0
0 Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 31: 0x0
0 Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 33: : register "docking_supported" = "0"
These are zero and can be dropped Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 39: : register "p_cnt_throttling_supported" = "1"
This no longer exists on master Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 41: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
This can be dropped Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 51: subsystemid 0x8086 0x7270
This can be factored out Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 63: Audio Audio
Much audio? I guess this is duplicated Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 83: PCI-LPC bridge
Can drop this part Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 99: Host bridge Host bridge
Host bridge much? I guess it's duplicated Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 98: : device pci 00.0 on # Host bridge Host bridge : subsystemid 0x106b 0x00f7 : end : device pci 01.0 on # PCIe Bridge for discrete graphics : subsystemid 0x106b 0x00f7 : end : device pci 02.0 on # Internal graphics VGA controller : subsystemid 0x106b 0x00f7 : end
Move these before the southbridge "chip" entry Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 14: #define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB : #define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB : #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Are these used? Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 28: /* Some generic macros */
Please remove this. I killed all instances of this comment in a previous change. Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 31: #include <southbridge/intel/bd82x6x/acpi/platform.asl> : /* global NVS and variables. */ : #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> : #include <southbridge/intel/bd82x6x/acpi/sleepstates.asl>
Note that some of these are now under common/ Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 21: 0x0000000b
This should be decimal Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 23: 0x0
This too Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 25: /* NID 0x09. */
Please get rid of these obnoxious comments Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 30: LVDS
If not using the VBIOS, you can drop the entire file. Well, VBIOS works. Who knows, maybe someone will use it.
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/romstage.c: PS22:
This is now called early_init. […] Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 26: pci_write_config16(PCH_LPC_DEV, 0x82, 0x3f0f); : pci_write_config32(PCH_LPC_DEV, 0x84, 0x000c0681); : pci_write_config32(PCH_LPC_DEV, 0x88, 0x000c1641); : pci_write_config32(PCH_LPC_DEV, 0x8c, 0x001c0301); : pci_write_config32(PCH_LPC_DEV, 0x90, 0x00fc0701); : pci_write_config16(PCH_LPC_DEV, 0x80, 0x0070);
There are macros for these Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 72: /* Disable IGD VGA decode, no GTT or GFX stolen */ : pci_write_config16(PCI_DEV(0, 0, 0), GGC, 2);
This is confusing without braces on the if/else Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 87: &spd_file_len);
Fits on the previous line Done
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 88: (spd_file && spd_file_len >= 128)
So, if this check is false, what's the chances of the machine booting successfully? […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 23 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 02 Feb 2020 21:55:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Hello Angel Pons, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#24). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012) with Ivy Bridge CPU and Retina Display. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd.bin 21 files changed, 874 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/24 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 24 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 24: (1 comment) https://review.coreboot.org/c/coreboot/+/32673/23/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/early_init.c: https://review.coreboot.org/c/coreboot/+/32673/23/src/mainboard/apple/macboo... PS23, Line 71: if (!spd_file || spd_file_len < 128) {
braces {} are not necessary for single statement blocks Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 24 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 02 Feb 2020 21:57:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: comment
Hello Angel Pons, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#25). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012) with Ivy Bridge CPU and Retina Display. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd.bin 21 files changed, 876 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/25 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 25 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 25: (4 comments) https://review.coreboot.org/c/coreboot/+/32673/25/Documentation/mainboard/ap... File Documentation/mainboard/apple/mbp101_board.jpg: PS25: Is this picture yours? I would try bringing its size down to 50 KiB https://review.coreboot.org/c/coreboot/+/32673/25/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/cmos.default: https://review.coreboot.org/c/coreboot/+/32673/25/src/mainboard/apple/macboo... PS25, Line 3: gfx_uma_size=32M https://review.coreboot.org/c/coreboot/+/32673/25/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32673/25/src/mainboard/apple/macboo... PS25, Line 38: device pci 01.2 on Would be good to check what is wired to these PCIe RPs https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 30: LVDS
Well, VBIOS works. Who knows, maybe someone will use it. Ack. Still, this shouldn't be LVDS but eDP
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 25 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 03 Feb 2020 09:34:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 25: (1 comment) https://review.coreboot.org/c/coreboot/+/32673/25/Documentation/mainboard/ap... File Documentation/mainboard/apple/mbp101_board.jpg: PS25:
Is this picture yours? I would try bringing its size down to 50 KiB Yes. My photos + some photoshop skills lol.
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 25 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 03 Feb 2020 09:50:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 25: (1 comment) https://review.coreboot.org/c/coreboot/+/32673/25/Documentation/mainboard/ap... File Documentation/mainboard/apple/mbp101_board.jpg: PS25:
Yes. My photos + some photoshop skills lol. Oh, I love the idea! It clearly shows where the flash chip is. Two questions, though:
- Mind placing an arrow that points to the pin 1 circle on the chip package? - I guess pin 3 and 7 are not marked, as they have different functions for Quad I/O mode? -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 25 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 03 Feb 2020 11:48:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 25: (1 comment) https://review.coreboot.org/c/coreboot/+/32673/25/Documentation/mainboard/ap... File Documentation/mainboard/apple/mbp101_board.jpg: PS25:
Oh, I love the idea! It clearly shows where the flash chip is. Two questions, though: […] I also added MBA 5,2 documentation with similar motherboard view.
- OK - Well, yes, but actually they are not marked just because you don't need them to flash coreboot. Users are already confused enough, so I marked only what's necessary :) -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 25 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 03 Feb 2020 12:16:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 25: (1 comment) https://review.coreboot.org/c/coreboot/+/32673/25/Documentation/mainboard/ap... File Documentation/mainboard/apple/mbp101_board.jpg: PS25:
I also added MBA 5,2 documentation with similar motherboard view. […] Ah, not sure about that board, but on some others pulling those pins high is a must. Pin 3 is WP# (if low, no writes allowed) and pin 7 is HOLD# (if low, chip will not answer back at all)
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 25 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 03 Feb 2020 12:35:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 25: (3 comments) https://review.coreboot.org/c/coreboot/+/32673/25//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/32673/25//COMMIT_MSG@10 PS25, Line 10: Please add a note, if you used autoport or some other board as template. https://review.coreboot.org/c/coreboot/+/32673/25/Documentation/mainboard/ap... File Documentation/mainboard/apple/macbookpro10_1.md: https://review.coreboot.org/c/coreboot/+/32673/25/Documentation/mainboard/ap... PS25, Line 34: Tianocore TianoCore https://review.coreboot.org/c/coreboot/+/32673/25/Documentation/mainboard/ap... PS25, Line 55: - Bad sound in headphones Can you elaborate? -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 25 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 11 Feb 2020 11:55:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Attention is currently required from: Evgeny Zinoviev. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#28). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012) with Ivy Bridge CPU and Retina Display. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd.bin 21 files changed, 752 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/28 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 28 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: newpatchset
Attention is currently required from: Evgeny Zinoviev. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#30). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012) with Ivy Bridge CPU and Retina Display. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd.bin 21 files changed, 752 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/30 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 30 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#31). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012) with Ivy Bridge CPU and Retina Display. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd.bin 21 files changed, 749 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/31 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 31 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#32). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012) with Ivy Bridge CPU and Retina Display. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd.bin 21 files changed, 749 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/32 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 32 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#33). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012) with Ivy Bridge CPU and Retina Display. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd.bin 21 files changed, 749 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/33 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 33 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Angel Pons. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 35: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/32673/comment/7eb27963_9b06bb36 PS25, Line 10:
Please add a note, if you used autoport or some other board as template. Done
File Documentation/mainboard/apple/macbookpro10_1.md: https://review.coreboot.org/c/coreboot/+/32673/comment/96b3565a_ea34d3e2 PS25, Line 34: Tianocore
TianoCore Done
https://review.coreboot.org/c/coreboot/+/32673/comment/5dfa9982_c22ebae2 PS25, Line 55: - Bad sound in headphones
Can you elaborate? No such problem any more.
File Documentation/mainboard/apple/mbp101_board.jpg: PS25:
Ah, not sure about that board, but on some others pulling those pins high is a must. […] This one doesn't need it, marking as resolved.
File src/mainboard/apple/macbookpro10_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/32673/comment/cd84ca3b_1e729715 PS22, Line 30: LVDS
Ack. […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 35 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Wed, 03 Feb 2021 19:15:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 35: (10 comments) File Documentation/mainboard/apple/macbookpro10_1.md: https://review.coreboot.org/c/coreboot/+/32673/comment/ba53b560_8a24b65a PS35, Line 16: 8MB MiB https://review.coreboot.org/c/coreboot/+/32673/comment/9f2290a5_c4d71ee1 PS35, Line 29: 8GB GiB File src/mainboard/apple/macbookpro10_1/Kconfig: https://review.coreboot.org/c/coreboot/+/32673/comment/d14c2f26_5eb85cf9 PS35, Line 19: select DRIVERS_APPLE_HYBRID_GRAPHICS I'd sort the selected options alphabetically. https://review.coreboot.org/c/coreboot/+/32673/comment/707006ba_2b77def9 PS35, Line 29: config VGA_BIOS_FILE : string : default "pci8086,0166.rom" Please drop this option. Not everyone will use a file named `pci8086,0166.rom`. File src/mainboard/apple/macbookpro10_1/Makefile.inc: https://review.coreboot.org/c/coreboot/+/32673/comment/d5fd6c0b_ee4ec997 PS35, Line 8: spd.bin-file := spd.bin For memory down SPD data, we usually have a plain-text file and use the `GENERIC_SPD_BIN` Kconfig option. There's an example in hp/snb_ivb_laptops File src/mainboard/apple/macbookpro10_1/cmos.layout: PS35: Please get rid of the commented-out options. I'd suggest grabbing a cmos.layout from a board in the tree as a reference. File src/mainboard/apple/macbookpro10_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32673/comment/e379ab10_cba194c8 PS35, Line 24: 0x8086 0x7270 Replace the IDs in here with `0x106b 0x00f7` and drop all other `subsystemid 0x106b 0x00f7` lines File src/mainboard/apple/macbookpro10_1/early_init.c: https://review.coreboot.org/c/coreboot/+/32673/comment/da8d13e1_043cd661 PS35, Line 12: pci_write_config16(PCH_LPC_DEV, LPC_EN, 0x3f0f); : pci_write_config32(PCH_LPC_DEV, LPC_GEN1_DEC, 0x000c0681); : pci_write_config32(PCH_LPC_DEV, LPC_GEN2_DEC, 0x000c1641); : pci_write_config32(PCH_LPC_DEV, LPC_GEN3_DEC, 0x001c0301); : pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0x00fc0701); : pci_write_config16(PCH_LPC_DEV, LPC_IO_DEC, 0x0070); : } Shouldn't be needed. https://review.coreboot.org/c/coreboot/+/32673/comment/ae6be2a1_c845d474 PS35, Line 44: /* Hide disabled devices */ Shouldn't this code be in the northbridge? https://review.coreboot.org/c/coreboot/+/32673/comment/bdfb9b3b_34097f52 PS35, Line 45: PCI_DEV(0, 0, 0) HOST_BRIDGE -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 35 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Wed, 03 Feb 2021 19:40:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Evgeny Zinoviev. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#36). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the monent, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 23 files changed, 778 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/36 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 36 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 36: (13 comments) File Documentation/mainboard/apple/macbookpro10_1.md: https://review.coreboot.org/c/coreboot/+/32673/comment/37414a6d_43948669 PS35, Line 16: 8MB
MiB Done
https://review.coreboot.org/c/coreboot/+/32673/comment/e85e9045_81115eff PS35, Line 29: 8GB
GiB Done
File src/mainboard/apple/macbookpro10_1/Kconfig: https://review.coreboot.org/c/coreboot/+/32673/comment/30424565_5e155959 PS35, Line 19: select DRIVERS_APPLE_HYBRID_GRAPHICS
I'd sort the selected options alphabetically. Done
https://review.coreboot.org/c/coreboot/+/32673/comment/eb2f6ce6_e70b5a37 PS35, Line 29: config VGA_BIOS_FILE : string : default "pci8086,0166.rom"
Please drop this option. Not everyone will use a file named `pci8086,0166.rom`. Done
File src/mainboard/apple/macbookpro10_1/Makefile.inc: https://review.coreboot.org/c/coreboot/+/32673/comment/a9e4269c_587142e8 PS22, Line 2: : cbfs-files-y += spd.bin : spd.bin-file := spd.bin : spd.bin-type := spd
This could use the GENERIC_SPD mechanism. […] Done
File src/mainboard/apple/macbookpro10_1/Makefile.inc: https://review.coreboot.org/c/coreboot/+/32673/comment/04f0f424_43533325 PS35, Line 8: spd.bin-file := spd.bin
For memory down SPD data, we usually have a plain-text file and use the `GENERIC_SPD_BIN` Kconfig op […] Done
File src/mainboard/apple/macbookpro10_1/cmos.default: https://review.coreboot.org/c/coreboot/+/32673/comment/ddc1a5e7_1380f033 PS25, Line 3:
gfx_uma_size=32M Done
File src/mainboard/apple/macbookpro10_1/cmos.layout: PS35:
Please get rid of the commented-out options. I'd suggest grabbing a cmos. […] Done
File src/mainboard/apple/macbookpro10_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32673/comment/dd0d735c_7f20eca0 PS35, Line 24: 0x8086 0x7270
Replace the IDs in here with `0x106b 0x00f7` and drop all other `subsystemid 0x106b 0x00f7` lines Done
File src/mainboard/apple/macbookpro10_1/early_init.c: https://review.coreboot.org/c/coreboot/+/32673/comment/fdd97aaa_780ca2af PS35, Line 12: pci_write_config16(PCH_LPC_DEV, LPC_EN, 0x3f0f); : pci_write_config32(PCH_LPC_DEV, LPC_GEN1_DEC, 0x000c0681); : pci_write_config32(PCH_LPC_DEV, LPC_GEN2_DEC, 0x000c1641); : pci_write_config32(PCH_LPC_DEV, LPC_GEN3_DEC, 0x001c0301); : pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0x00fc0701); : pci_write_config16(PCH_LPC_DEV, LPC_IO_DEC, 0x0070); : }
Shouldn't be needed. Done
https://review.coreboot.org/c/coreboot/+/32673/comment/125c51d3_ba2025e3 PS35, Line 45: PCI_DEV(0, 0, 0)
HOST_BRIDGE Done
File src/mainboard/apple/macbookpro10_1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/32673/comment/acecb15a_3a3fbcf7 PS22, Line 30: Analog
Hmm? Removed.
File src/mainboard/apple/macbookpro10_1/romstage.c: https://review.coreboot.org/c/coreboot/+/32673/comment/a362f354_d17d22ca PS22, Line 82: void mainboard_get_spd(spd_raw_data *spd, bool id_only)
RAMCFG[0.. […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 36 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Comment-Date: Tue, 09 Feb 2021 15:56:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#37). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the monent, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 23 files changed, 778 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/37 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 37 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Angel Pons, Evgeny Zinoviev, Felix Held. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#38). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the monent, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 23 files changed, 823 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/38 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 38 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#39). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the monent, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 23 files changed, 837 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/39 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 39 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#40). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the monent, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 23 files changed, 837 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/40 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 40 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#41). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the monent, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 23 files changed, 837 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/41 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 41 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#42). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the monent, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 23 files changed, 834 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/42 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 42 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#43). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the monent, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 24 files changed, 850 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/43 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 43 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Angel Pons, Evgeny Zinoviev, Felix Held. xin hua wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 43: (1 comment) Patchset: PS43: has anyone able to find the debug ports on the motherboard via test points? its not the side ones i tested woth find_debugport -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 43 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 14:31:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Angel Pons, xin hua wang, Felix Held. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 43: (1 comment) Patchset: PS43:
has anyone able to find the debug ports on the motherboard via test points? its not the side ones i […] I don't know what find_debugport is but USB port on the right side is what you need.
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 43 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 14:34:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: xin hua wang <xinhuawang0101@gmail.com> Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, xin hua wang, Evgeny Zinoviev, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 43: Code-Review+1 (10 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/32673/comment/b3c0464c_028acbf7 PS43, Line 10: and Retina Display. Some words fit on the line above? https://review.coreboot.org/c/coreboot/+/32673/comment/696b7c15_12bd7e5e PS43, Line 12: monent moment Patchset: PS43: Awesome work. File Documentation/mainboard/apple/macbookpro10_1.md: https://review.coreboot.org/c/coreboot/+/32673/comment/b5cd9f34_32cf7adc PS43, Line 19: this script the script `get_macbook_ramcfg` https://review.coreboot.org/c/coreboot/+/32673/comment/efdeb67f_c7960acb PS43, Line 23: ```console : $ cd util/inteltool : $ make -j4 : ``` I’d just add blank lines and indent by four spaces. https://review.coreboot.org/c/coreboot/+/32673/comment/234961c4_40b77dda PS43, Line 30: sudo ./inteltool -g | /path/to/get_macbook_ramcfg -m mbp101 Ditto. https://review.coreboot.org/c/coreboot/+/32673/comment/e435eb63_49965ce6 PS43, Line 42: Yes Why not bold as below? https://review.coreboot.org/c/coreboot/+/32673/comment/4b3c58f0_22039926 PS43, Line 73: to coreboot to *the* coreboot mailing list https://review.coreboot.org/c/coreboot/+/32673/comment/8d49dc79_add6e804 PS43, Line 97: - SeaBIOS, GRUB, TianoCore Please add the versions. File src/mainboard/apple/macbookpro10_1/early_init.c: https://review.coreboot.org/c/coreboot/+/32673/comment/84783d91_c7a2751b PS43, Line 96: die("Unsupported memory, RAMCFG=%d\n", ramcfg);
… Please contact the coreboot mailing list.
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 43 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 19:28:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Evgeny Zinoviev, Felix Held. xin hua wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 43: (1 comment) Patchset: PS43:
I don't know what find_debugport is but USB port on the right side is what you need. https://review.coreboot.org/c/coreboot/+/9305/ this util says none even if i plug to right side? will ft232h work? thx
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 43 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 20:22:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: xin hua wang <xinhuawang0101@gmail.com> Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Angel Pons, xin hua wang, Felix Held. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 43: (2 comments) Patchset: PS43:
Awesome work. Thank you!
PS43:
https://review.coreboot. […] Well then maybe that util unreliable or something, I don't know. As a guy who made this port, I'm telling you, the port on the right side works :) and it's documented here https://review.coreboot.org/c/coreboot/+/32673/43/Documentation/mainboard/ap...
I also saw your comment in the 8,1 patch; I can't tell which port works there right now but I'm pretty sure that some worked. -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 43 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 20:32:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org> Comment-In-Reply-To: xin hua wang <xinhuawang0101@gmail.com> Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Angel Pons, Evgeny Zinoviev, Felix Held. xin hua wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 43: (1 comment) Patchset: PS43:
Well then maybe that util unreliable or something, I don't know. […] ok I will try the ft232h..
can you tell me what "VGA ROM loading" means in the link above? Nvidia or Intel HD4000?, if HD4000, where is the file? also do you have schematics of the board? googling 820-3332 only shows picture of single fan motherboard, mines and yours is dual fan thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 43 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Comment-Date: Tue, 21 Dec 2021 01:05:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: xin hua wang <xinhuawang0101@gmail.com> Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Angel Pons, Evgeny Zinoviev, Felix Held. Hello build bot (Jenkins), Martin L Roth, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#45). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the monent, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 24 files changed, 868 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/45 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 45 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Angel Pons, Evgeny Zinoviev, Felix Held. Hello build bot (Jenkins), Martin L Roth, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#46). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the monent, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 24 files changed, 869 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/46 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 46 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Angel Pons, Evgeny Zinoviev, Felix Held. Hello build bot (Jenkins), Martin L Roth, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32673 to look at the new patch set (#47). Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the monent, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.inc A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 24 files changed, 868 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/47 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 47 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Paul Menzel, Angel Pons. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 51: (9 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/32673/comment/b0529d68_03903c79 PS43, Line 10: and Retina Display.
Some words fit on the line above? Done
https://review.coreboot.org/c/coreboot/+/32673/comment/cd88d641_060a8440 PS43, Line 12: monent
moment Done
File Documentation/mainboard/apple/macbookpro10_1.md: https://review.coreboot.org/c/coreboot/+/32673/comment/4ee85a7f_3d299eb8 PS43, Line 19: this script
the script `get_macbook_ramcfg` Done
https://review.coreboot.org/c/coreboot/+/32673/comment/36b5c29a_bce2493a PS43, Line 23: ```console : $ cd util/inteltool : $ make -j4 : ```
I’d just add blank lines and indent by four spaces. Done
https://review.coreboot.org/c/coreboot/+/32673/comment/cec48296_abb2a7a2 PS43, Line 30: sudo ./inteltool -g | /path/to/get_macbook_ramcfg -m mbp101
Ditto. Done
https://review.coreboot.org/c/coreboot/+/32673/comment/895d7990_c0603527 PS43, Line 42: Yes
Why not bold as below? Done
https://review.coreboot.org/c/coreboot/+/32673/comment/91347dd2_e6777e92 PS43, Line 73: to coreboot
to *the* coreboot mailing list Done
https://review.coreboot.org/c/coreboot/+/32673/comment/0c1e1d10_6e332372 PS43, Line 97: - SeaBIOS, GRUB, TianoCore
Please add the versions. in progress
File src/mainboard/apple/macbookpro10_1/early_init.c: https://review.coreboot.org/c/coreboot/+/32673/comment/22999dcc_bdfb7796 PS43, Line 96: die("Unsupported memory, RAMCFG=%d\n", ramcfg);
… Please contact the coreboot mailing list. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 51 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Sun, 15 Jan 2023 02:09:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org> Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Evgeny Zinoviev, Martin L Roth, Paul Menzel, Renstals. David Hendricks has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 52: Code-Review+1 (1 comment) Patchset: PS52: Is there any reason not to merge this patch? It seems to add useful functionality and is self-contained. -- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 52 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Renstals <citoharux@vpslists.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Wed, 31 Jul 2024 17:53:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
Attention is currently required from: David Hendricks, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel, Renstals. Angel Pons has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 52: (15 comments) Patchset: PS52:
Is there any reason not to merge this patch? It seems to add useful functionality and is self-contai […] It hasn't been updated to the latest state of the codebase. I left a few comments but I am sure I missed something. Plus there's still old unresolved comments.
File src/mainboard/apple/macbookpro10_1/Kconfig: PS52: Should have a license header https://review.coreboot.org/c/coreboot/+/32673/comment/10c7eb0d_1541fb05?usp... : PS52, Line 22: config MAINBOARD_DIR : string : default "apple/macbookpro10_1" : : config MAINBOARD_PART_NUMBER : string : default "MacBookPro10,1" : : config VGA_BIOS_ID : string : default "8086,0166" : : config DRAM_RESET_GATE_GPIO : int : default 28 : : config USBDEBUG_HCD_INDEX : int : default 0 Types are redundant: ```suggestion config MAINBOARD_DIR default "apple/macbookpro10_1" config MAINBOARD_PART_NUMBER default "MacBookPro10,1" config VGA_BIOS_ID default "8086,0166" config DRAM_RESET_GATE_GPIO default 28 config USBDEBUG_HCD_INDEX default 0 ``` https://review.coreboot.org/c/coreboot/+/32673/comment/b45223bb_8e4be2af?usp... : PS52, Line 42: config MAX_CPUS : int : default 8 Matches default value, please remove File src/mainboard/apple/macbookpro10_1/Kconfig.name: PS52: Should have a license header File src/mainboard/apple/macbookpro10_1/acpi/superio.asl: PS52: Should be licensed as CC-PDDC instead File src/mainboard/apple/macbookpro10_1/cmos.layout: https://review.coreboot.org/c/coreboot/+/32673/comment/e2936b51_621176d4?usp... : PS52, Line 27: 432 3 e 11 gfx_uma_size : 435 2 e 12 hybrid_graphics_mode I think `gfx_uma_size` should be 4 bits wide to support all possible values. You would also need to move the `hybrid_graphics_mode` option one bit. ```suggestion 432 4 e 11 gfx_uma_size 436 2 e 12 hybrid_graphics_mode ``` https://review.coreboot.org/c/coreboot/+/32673/comment/a27d7b87_4c7a3d6e?usp... : PS52, Line 42: #ID value text : 1 0 Disable : 1 1 Enable : 2 0 Enable : 2 1 Disable : 4 0 Fallback : 4 1 Normal : 6 0 Emergency : 6 1 Alert : 6 2 Critical : 6 3 Error : 6 4 Warning : 6 5 Notice : 6 6 Info : 6 7 Debug : 6 8 Spew : 7 0 Disable : 7 1 Enable : 7 2 Keep : 11 0 32M : 11 1 64M : 11 2 96M : 11 3 128M : 11 4 160M : 11 5 192M : 11 6 224M : 12 0 Integrated Only : 12 1 Discrete Only : 13 0 Normal : 13 1 Disabled Some of these enums are unused (e.g. ID 2). Would be good to remove unused ones. Enum for iGPU memory seems to be missing a few values. File src/mainboard/apple/macbookpro10_1/devicetree.cb: PS52: Should have a license header https://review.coreboot.org/c/coreboot/+/32673/comment/dded59f5_a9742cdb?usp... : PS52, Line 16: device cpu_cluster 0 on : chip cpu/intel/model_206ax : device lapic 0 on end : device lapic 0xacac off end : end : end : : device domain 0 on : subsystemid 0x106b 0x00f7 inherit : device pci 00.0 on end # Host bridge : device pci 01.0 on end # PCIe Bridge for discrete graphics : device pci 01.2 on end : device pci 01.1 on end : device pci 02.0 on end # Internal graphics VGA controller : chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH : register "gen1_dec" = "0x000c0681" : register "gen2_dec" = "0x000c1641" : register "gen3_dec" = "0x001c0301" : register "gen4_dec" = "0x00fc0701" : register "gpi7_routing" = "2" : register "pcie_port_coalesce" = "1" : register "sata_interface_speed_support" = "0x3" : register "sata_port_map" = "0x1" : register "spi_lvscc" = "0x0" : register "spi_uvscc" = "0x2005" : register "superspeed_capable_ports" = "0x0000000f" : register "xhci_overcurrent_mapping" = "0x08040201" : register "xhci_switchable_ports" = "0x0000000f" : device pci 14.0 on end # USB 3.0 Controller : device pci 16.0 on end # Management Engine Interface 1 : device pci 16.1 off end # Management Engine Interface 2 : device pci 16.2 off end # Management Engine IDE-R : device pci 16.3 off end # Management Engine KT : device pci 19.0 off end # Intel Gigabit Ethernet : device pci 1a.0 on end # USB2 EHCI #2 : device pci 1b.0 on end # HD Audio controller : device pci 1c.0 on end # PCIe Port #1 : device pci 1c.1 on end # PCIe Port #2 : device pci 1c.2 off end # PCIe Port #3 : device pci 1c.3 off end # PCIe Port #4 : device pci 1c.4 off end # PCIe Port #5 : device pci 1c.5 off end # PCIe Port #6 : device pci 1c.6 off end # PCIe Port #7 : device pci 1c.7 off end # PCIe Port #8 : device pci 1d.0 on end # USB2 EHCI #1 : device pci 1e.0 off end # PCI bridge : device pci 1f.0 on # LPC bridge : chip drivers/apple/hybrid_graphics : device pnp ff.f on end # dummy : register "gmux_indexed" = "1" : end : end : device pci 1f.2 on end # SATA Controller 1 : device pci 1f.3 on end # SMBus : device pci 1f.5 off end # SATA Controller 2 : device pci 1f.6 off end # Thermal : end : end Should be updated to make use of chipset devicetree aliases. File src/mainboard/apple/macbookpro10_1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/32673/comment/e0f229da_de98c955?usp... : PS52, Line 10: // OEM revision Please remove this comment, it's autoport copypasta (which CB:82401 finally got rid of) File src/mainboard/apple/macbookpro10_1/early_init.c: https://review.coreboot.org/c/coreboot/+/32673/comment/717de5ae_df32ff15?usp... : PS52, Line 11: const struct southbridge_usb_port mainboard_usb_ports[] = { : { 1, 0, 0 }, /* Ext A (XHCI/EHCI) */ : { 1, 0, 1 }, /* Ext B (XHCI) */ : { 1, 0, 2 }, /* Ext C (XHCI/EHCI) */ : { 1, 0, 3 }, /* Ext D (XHCI) */ : { 0, 0, -1 }, /* Unused */ : { 1, 0, -1 }, /* SD */ : { 1, 0, -1 }, /* Wi-Fi */ : { 1, 0, -1 }, /* USB Hub (All LS/FS Devices) */ : { 1, 0, -1 }, /* Camera */ : { 1, 0, 4 }, /* Ext B (EHCI) */ : { 1, 0, 5 }, /* Ext D (EHCI) */ : { 1, 0, -1 }, /* BT */ : { 0, 0, -1 }, /* Unused */ : { 0, 0, -1 }, /* Unused */ : }; USB settings are now in devicetree File src/mainboard/apple/macbookpro10_1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/32673/comment/b8d5fa5f_b321ac4f?usp... : PS52, Line 8: nit: drop blank line? File src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex: PS52: nit: this is the only SPD file without a newline at the end, would be nice to add the newline for consistency File src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex: PS52: Not sure if SPD files need a license header, @service+coreboot-gerrit@felixsinger.de or @gaumless@gmail.com do you know? -- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 52 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Renstals <citoharux@vpslists.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Wed, 31 Jul 2024 18:21:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com>
Attention is currently required from: David Hendricks, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel, Renstals. Felix Singer has uploaded a new patch set (#54) to the change originally created by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by David Hendricks Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the moment, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.mk A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.inc 24 files changed, 851 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/54 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 54 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Renstals <citoharux@vpslists.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io>
Attention is currently required from: David Hendricks, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel. Felix Singer has uploaded a new patch set (#55) to the change originally created by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the moment, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.mk A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.mk 24 files changed, 851 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/55 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 55 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io>
Attention is currently required from: David Hendricks, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel. Felix Singer has uploaded a new patch set (#56) to the change originally created by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the moment, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.mk A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.mk 24 files changed, 850 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/56 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 56 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io>
Attention is currently required from: Angel Pons, David Hendricks, Evgeny Zinoviev, Martin L Roth, Paul Menzel. Felix Singer has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 56: (1 comment) File src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex: PS52:
Not sure if SPD files need a license header, @service+coreboot-gerrit@felixsinger. […] I recall that pure data is not licensable.
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 56 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Sat, 03 Aug 2024 05:42:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Attention is currently required from: Angel Pons, David Hendricks, Evgeny Zinoviev, Martin L Roth, Paul Menzel. Felix Singer has uploaded a new patch set (#57) to the change originally created by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the moment, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.mk A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.mk 24 files changed, 828 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/57 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 57 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io>
Attention is currently required from: Angel Pons, David Hendricks, Evgeny Zinoviev, Martin L Roth, Paul Menzel. Felix Singer has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 57: (9 comments) File src/mainboard/apple/macbookpro10_1/Kconfig: PS52:
Should have a license header Done
https://review.coreboot.org/c/coreboot/+/32673/comment/0d62832f_42eb6259?usp... : PS52, Line 22: config MAINBOARD_DIR : string : default "apple/macbookpro10_1" : : config MAINBOARD_PART_NUMBER : string : default "MacBookPro10,1" : : config VGA_BIOS_ID : string : default "8086,0166" : : config DRAM_RESET_GATE_GPIO : int : default 28 : : config USBDEBUG_HCD_INDEX : int : default 0
Types are redundant: […] Done
https://review.coreboot.org/c/coreboot/+/32673/comment/0a3ba42b_437a847e?usp... : PS52, Line 42: config MAX_CPUS : int : default 8
Matches default value, please remove Done
File src/mainboard/apple/macbookpro10_1/Kconfig.name: PS52:
Should have a license header Done
File src/mainboard/apple/macbookpro10_1/acpi/superio.asl: PS52:
Should be licensed as CC-PDDC instead Done
File src/mainboard/apple/macbookpro10_1/devicetree.cb: PS52:
Should have a license header Done
https://review.coreboot.org/c/coreboot/+/32673/comment/61e7ef33_f5810a1b?usp... : PS52, Line 16: device cpu_cluster 0 on : chip cpu/intel/model_206ax : device lapic 0 on end : device lapic 0xacac off end : end : end : : device domain 0 on : subsystemid 0x106b 0x00f7 inherit : device pci 00.0 on end # Host bridge : device pci 01.0 on end # PCIe Bridge for discrete graphics : device pci 01.2 on end : device pci 01.1 on end : device pci 02.0 on end # Internal graphics VGA controller : chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH : register "gen1_dec" = "0x000c0681" : register "gen2_dec" = "0x000c1641" : register "gen3_dec" = "0x001c0301" : register "gen4_dec" = "0x00fc0701" : register "gpi7_routing" = "2" : register "pcie_port_coalesce" = "1" : register "sata_interface_speed_support" = "0x3" : register "sata_port_map" = "0x1" : register "spi_lvscc" = "0x0" : register "spi_uvscc" = "0x2005" : register "superspeed_capable_ports" = "0x0000000f" : register "xhci_overcurrent_mapping" = "0x08040201" : register "xhci_switchable_ports" = "0x0000000f" : device pci 14.0 on end # USB 3.0 Controller : device pci 16.0 on end # Management Engine Interface 1 : device pci 16.1 off end # Management Engine Interface 2 : device pci 16.2 off end # Management Engine IDE-R : device pci 16.3 off end # Management Engine KT : device pci 19.0 off end # Intel Gigabit Ethernet : device pci 1a.0 on end # USB2 EHCI #2 : device pci 1b.0 on end # HD Audio controller : device pci 1c.0 on end # PCIe Port #1 : device pci 1c.1 on end # PCIe Port #2 : device pci 1c.2 off end # PCIe Port #3 : device pci 1c.3 off end # PCIe Port #4 : device pci 1c.4 off end # PCIe Port #5 : device pci 1c.5 off end # PCIe Port #6 : device pci 1c.6 off end # PCIe Port #7 : device pci 1c.7 off end # PCIe Port #8 : device pci 1d.0 on end # USB2 EHCI #1 : device pci 1e.0 off end # PCI bridge : device pci 1f.0 on # LPC bridge : chip drivers/apple/hybrid_graphics : device pnp ff.f on end # dummy : register "gmux_indexed" = "1" : end : end : device pci 1f.2 on end # SATA Controller 1 : device pci 1f.3 on end # SMBus : device pci 1f.5 off end # SATA Controller 2 : device pci 1f.6 off end # Thermal : end : end
Should be updated to make use of chipset devicetree aliases. Done
File src/mainboard/apple/macbookpro10_1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/32673/comment/2c6028dd_0a58975e?usp... : PS52, Line 10: // OEM revision
Please remove this comment, it's autoport copypasta (which CB:82401 finally got rid of) Done
File src/mainboard/apple/macbookpro10_1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/32673/comment/b0b45a88_dc8730b8?usp... : PS52, Line 8:
nit: drop blank line? Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 57 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Sat, 03 Aug 2024 06:06:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Attention is currently required from: David Hendricks, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel. Angel Pons has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 57: (6 comments) File Documentation/mainboard/apple/mbp101_board.jpg: PS57: You should not be executable File src/mainboard/apple/macbookpro10_1/cmos.default: PS57: Add license header as per commit e623845df64b28d2c809e40c0703d18d6bc246c4 File src/mainboard/apple/macbookpro10_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32673/comment/43342b71_7e102085?usp... : PS57, Line 6: device ref peg10 on end : device ref peg12 on end : device ref peg11 on end nit: order ```suggestion device ref peg10 on end device ref peg11 on end device ref peg12 on end ``` https://review.coreboot.org/c/coreboot/+/32673/comment/13841415_2f5b92b1?usp... : PS57, Line 29: register "spi_lvscc" = "0x0" Isn't this the default? https://review.coreboot.org/c/coreboot/+/32673/comment/f72ef424_14d25fa9?usp... : PS57, Line 35: device ref mei1 on end Isn't MEI1 enabled by default? File src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex: PS52:
I recall that pure data is not licensable. https://github.com/coreboot/coreboot/blob/940fe080bf1ed2dac827b569c70fb0ea11... does not use a license header.
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 57 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Sat, 03 Aug 2024 08:46:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit@felixsinger.de> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Attention is currently required from: David Hendricks, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel. Elyes Haouas has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 57: (2 comments) File src/mainboard/apple/macbookpro10_1/early_init.c: https://review.coreboot.org/c/coreboot/+/32673/comment/796bb574_7587efb2?usp... : PS57, Line 8: #include <cbfs.h> not sure if this is needed or not File src/mainboard/apple/macbookpro10_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/32673/comment/e81cc30b_7e3aa00d?usp... : PS57, Line 6: #include <ec/acpi/ec.h> : #include <console/console.h> : please check if those are needed -- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 57 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas@noos.fr> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Sat, 03 Aug 2024 10:23:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
Attention is currently required from: David Hendricks, Elyes Haouas, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel. Angel Pons has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 57: (1 comment) File src/mainboard/apple/macbookpro10_1/early_init.c: https://review.coreboot.org/c/coreboot/+/32673/comment/b3ed7e52_640ebde5?usp... : PS57, Line 8: #include <cbfs.h>
not sure if this is needed or not `spd_file = cbfs_map("spd.bin", &spd_file_len);`
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 57 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas@noos.fr> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr> Gerrit-Comment-Date: Sat, 03 Aug 2024 10:25:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas@noos.fr>
Attention is currently required from: David Hendricks, Elyes Haouas, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel. Felix Singer has uploaded a new patch set (#58) to the change originally created by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the moment, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.mk A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.mk 24 files changed, 817 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/58 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 58 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas@noos.fr> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr>
Attention is currently required from: David Hendricks, Elyes Haouas, Evgeny Zinoviev, Martin L Roth, Paul Menzel. Felix Singer has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 58: (1 comment) Patchset: PS58: I was able to boot to SeaBIOS, but for some reason USB ports and keyboard didn't work. I do have the hardware now (thanks to a supportive person from the postmarketos project). I will try working on the issues. -- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 58 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas@noos.fr> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr> Gerrit-Comment-Date: Mon, 05 Aug 2024 02:01:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
Attention is currently required from: Angel Pons, David Hendricks, Elyes Haouas, Evgeny Zinoviev, Martin L Roth, Paul Menzel. Felix Singer has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 58: (5 comments) File Documentation/mainboard/apple/mbp101_board.jpg: PS57:
You should not be executable Done
File src/mainboard/apple/macbookpro10_1/cmos.default: PS57:
Add license header as per commit e623845df64b28d2c809e40c0703d18d6bc246c4 Done
File src/mainboard/apple/macbookpro10_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32673/comment/f6836b7a_fc459021?usp... : PS57, Line 6: device ref peg10 on end : device ref peg12 on end : device ref peg11 on end
nit: order […] Done
https://review.coreboot.org/c/coreboot/+/32673/comment/da491439_6edde5ee?usp... : PS57, Line 29: register "spi_lvscc" = "0x0"
Isn't this the default? Done
https://review.coreboot.org/c/coreboot/+/32673/comment/a7761992_40200043?usp... : PS57, Line 35: device ref mei1 on end
Isn't MEI1 enabled by default? Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 58 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas@noos.fr> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr> Gerrit-Comment-Date: Tue, 06 Aug 2024 07:36:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Attention is currently required from: Angel Pons, David Hendricks, Elyes Haouas, Evgeny Zinoviev, Martin L Roth, Paul Menzel. Felix Singer has uploaded a new patch set (#59) to the change originally created by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... mb/apple: Add MacBook Pro 10,1 (A1398) support MacBook Pro 15 (Mid 2012/Early 2013) with Ivy Bridge CPU and Retina Display. Not all RAM configurations are supported at the moment, see comment in early_init.c. Used autoported config as a template. Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro10_1.md A Documentation/mainboard/apple/mbp101_board.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro10_1/Kconfig A src/mainboard/apple/macbookpro10_1/Kconfig.name A src/mainboard/apple/macbookpro10_1/Makefile.mk A src/mainboard/apple/macbookpro10_1/acpi/ec.asl A src/mainboard/apple/macbookpro10_1/acpi/platform.asl A src/mainboard/apple/macbookpro10_1/acpi/superio.asl A src/mainboard/apple/macbookpro10_1/acpi_tables.c A src/mainboard/apple/macbookpro10_1/board_info.txt A src/mainboard/apple/macbookpro10_1/cmos.default A src/mainboard/apple/macbookpro10_1/cmos.layout A src/mainboard/apple/macbookpro10_1/devicetree.cb A src/mainboard/apple/macbookpro10_1/dsdt.asl A src/mainboard/apple/macbookpro10_1/early_init.c A src/mainboard/apple/macbookpro10_1/gma-mainboard.ads A src/mainboard/apple/macbookpro10_1/gpio.c A src/mainboard/apple/macbookpro10_1/hda_verb.c A src/mainboard/apple/macbookpro10_1/mainboard.c A src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/4g_hynix_1600.spd.hex A src/mainboard/apple/macbookpro10_1/spd/Makefile.mk 24 files changed, 816 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32673/59 -- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 59 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas@noos.fr> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr>
Attention is currently required from: Angel Pons, David Hendricks, Elyes Haouas, Evgeny Zinoviev, Martin L Roth, Paul Menzel. Felix Singer has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 59: (1 comment) File src/mainboard/apple/macbookpro10_1/early_init.c: https://review.coreboot.org/c/coreboot/+/32673/comment/91d07464_f95b2c58?usp... : PS52, Line 11: const struct southbridge_usb_port mainboard_usb_ports[] = { : { 1, 0, 0 }, /* Ext A (XHCI/EHCI) */ : { 1, 0, 1 }, /* Ext B (XHCI) */ : { 1, 0, 2 }, /* Ext C (XHCI/EHCI) */ : { 1, 0, 3 }, /* Ext D (XHCI) */ : { 0, 0, -1 }, /* Unused */ : { 1, 0, -1 }, /* SD */ : { 1, 0, -1 }, /* Wi-Fi */ : { 1, 0, -1 }, /* USB Hub (All LS/FS Devices) */ : { 1, 0, -1 }, /* Camera */ : { 1, 0, 4 }, /* Ext B (EHCI) */ : { 1, 0, 5 }, /* Ext D (EHCI) */ : { 1, 0, -1 }, /* BT */ : { 0, 0, -1 }, /* Unused */ : { 0, 0, -1 }, /* Unused */ : };
USB settings are now in devicetree Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 59 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas@noos.fr> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr> Gerrit-Comment-Date: Tue, 06 Aug 2024 09:00:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Attention is currently required from: Angel Pons, David Hendricks, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel. Name of user not set #1004406 has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 59: (1 comment) File src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex: https://review.coreboot.org/c/coreboot/+/32673/comment/c087cb80_397e9fb9?usp... : PS59, Line 1: 92 11 0b 03 03 00 00 01 03 52 01 08 0a 00 80 00 how were this spd data dumped? i am very interested in this port -- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 59 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: Name of user not set #1004406 Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Wed, 22 Jan 2025 15:27:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
Attention is currently required from: David Hendricks, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel. Angel Pons has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email ) Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ...................................................................... Patch Set 59: (1 comment) File src/mainboard/apple/macbookpro10_1/spd/1g_samsung_1600.spd.hex: https://review.coreboot.org/c/coreboot/+/32673/comment/09196123_97b4bddc?usp... : PS59, Line 1: 92 11 0b 03 03 00 00 01 03 52 01 08 0a 00 80 00
how were this spd data dumped? i am very interested in this port util/autoport can generate "fake" SPD data. Actually, I think it's util/inteltool that generates the data, autoport just puts it in here.
-- To view, visit https://review.coreboot.org/c/coreboot/+/32673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df Gerrit-Change-Number: 32673 Gerrit-PatchSet: 59 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: Name of user not set #1004406 Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Wed, 22 Jan 2025 16:05:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Name of user not set #1004406
participants (10)
-
Angel Pons (Code Review) -
build bot (Jenkins) (Code Review)
-
David Hendricks (Code Review)
-
Elyes Haouas (Code Review)
-
Evgeny Zinoviev (Code Review)
-
Felix Held (Code Review)
-
Felix Singer (Code Review)
-
Name of user not set (Code Review)
-
Paul Menzel (Code Review)
-
xin hua wang (Code Review)