Attention is currently required from: Angel Pons, xin hua wang, Evgeny Zinoviev, Felix Held.

Patch set 43:Code-Review +1

View Change

10 comments:

• Commit Message:

  • Patch Set #43, Line 10: and Retina Display.

    Some words fit on the line above?

  • Patch Set #43, Line 12: monent

    moment

• Patchset:

  • Patch Set #43:

    Awesome work.

• File Documentation/mainboard/apple/macbookpro10_1.md:

  • Patch Set #43, Line 19: this script

    the script `get_macbook_ramcfg`

  • Patch Set #43, Line 23:

    ```console
    $ cd util/inteltool
    $ make -j4
    ```
    

    I’d just add blank lines and indent by four spaces.

  • Patch Set #43, Line 30: sudo ./inteltool -g | /path/to/get_macbook_ramcfg -m mbp101

    Ditto.

  • Patch Set #43, Line 42: Yes

    Why not bold as below?

  • Patch Set #43, Line 73: to coreboot

    to *the* coreboot mailing list

  • Patch Set #43, Line 97: - SeaBIOS, GRUB, TianoCore

    Please add the versions.

• File src/mainboard/apple/macbookpro10_1/early_init.c:

  • Patch Set #43, Line 96: die("Unsupported memory, RAMCFG=%d\n", ramcfg);

    … Please contact the coreboot mailing list.

To view, visit change 32673. To unsubscribe, or for help writing mail filters, visit settings.