Attention is currently required from: Paul Menzel, Evgeny Zinoviev.
10 comments:
File Documentation/mainboard/apple/macbookpro10_1.md:
MiB
GiB
File src/mainboard/apple/macbookpro10_1/Kconfig:
Patch Set #35, Line 19: select DRIVERS_APPLE_HYBRID_GRAPHICS
I'd sort the selected options alphabetically.
config VGA_BIOS_FILE
string
default "pci8086,0166.rom"
Please drop this option. Not everyone will use a file named `pci8086,0166.rom`.
File src/mainboard/apple/macbookpro10_1/Makefile.inc:
Patch Set #35, Line 8: spd.bin-file := spd.bin
For memory down SPD data, we usually have a plain-text file and use the `GENERIC_SPD_BIN` Kconfig option. There's an example in hp/snb_ivb_laptops
File src/mainboard/apple/macbookpro10_1/cmos.layout:
Please get rid of the commented-out options. I'd suggest grabbing a cmos.layout from a board in the tree as a reference.
File src/mainboard/apple/macbookpro10_1/devicetree.cb:
Patch Set #35, Line 24: 0x8086 0x7270
Replace the IDs in here with `0x106b 0x00f7` and drop all other `subsystemid 0x106b 0x00f7` lines
File src/mainboard/apple/macbookpro10_1/early_init.c:
pci_write_config16(PCH_LPC_DEV, LPC_EN, 0x3f0f);
pci_write_config32(PCH_LPC_DEV, LPC_GEN1_DEC, 0x000c0681);
pci_write_config32(PCH_LPC_DEV, LPC_GEN2_DEC, 0x000c1641);
pci_write_config32(PCH_LPC_DEV, LPC_GEN3_DEC, 0x001c0301);
pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0x00fc0701);
pci_write_config16(PCH_LPC_DEV, LPC_IO_DEC, 0x0070);
}
Shouldn't be needed.
Patch Set #35, Line 44: /* Hide disabled devices */
Shouldn't this code be in the northbridge?
Patch Set #35, Line 45: PCI_DEV(0, 0, 0)
HOST_BRIDGE
To view, visit change 32673. To unsubscribe, or for help writing mail filters, visit settings.