Attention is currently required from: Nico Huber, Benjamin Doron, Paul Menzel, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 180:
(21 comments)
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/fe256738_a2fa03f2 PS180, Line 45: if (data_buffer <= (2017/ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/die.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/71817898_cc0ff251 PS180, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/ec.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/1c0c7086_cb5ad9eb PS180, Line 27: #define EC_INDEX_IO_HIGH_ADDR_PORT EC_INDEX_IO_PORT+1 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/35523/comment/6df2906f_acfc63d8 PS180, Line 28: #define EC_INDEX_IO_LOW_ADDR_PORT EC_INDEX_IO_PORT+2 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/35523/comment/034fe96a_d581fa78 PS180, Line 29: #define EC_INDEX_IO_DATA_PORT EC_INDEX_IO_PORT+3 Macros with complex values should be enclosed in parentheses
File src/mainboard/acer/aspire_vn7_572g/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/1d5c7aa6_1d0b3a47 PS180, Line 73: 0x0143b000, /* Set amplifier gain on speaker: Set output, L+R amp; Unmuted; No gain */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/35523/comment/3f2e2444_96c72323 PS180, Line 75: 0x01470740, /* Set widget control on speaker: Out enabled; VrefEn: Hi-Z (disabled) */ line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/1a9f99a7_0d84a399 PS180, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/06c48ea1_87d7dbd6 PS180, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/ecc73236_063e9c49 PS180, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/5d9c2a45_d00f20fd PS180, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/5fdf993e_09fdb1ec PS180, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/c896c344_298d8aec PS180, Line 97: if (dat & 1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/5f2a5a67_35c6d0fb PS180, Line 120: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/838bfbcb_c839d02f PS180, Line 130: /* Clear xHCI PM_CS[PME_Status] - RW/1C - and disable xHCI PM_CS[PME_En] */ line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/c68e535c_17585dad PS180, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/bcc5ca98_8760e9e0 PS180, Line 51: switch (gnvs->unused_was_osys) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/35523/comment/282a842d_3e9a0539 PS180, Line 85: switch (function_parameter_0) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/35523/comment/15efeea4_21045589 PS180, Line 120: function_parameter_0 = smm_data_port &~ 0xF0; need consistent spacing around '&' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/35523/comment/81f7c3ce_30785058 PS180, Line 120: function_parameter_0 = smm_data_port &~ 0xF0; space prohibited after that '~' (ctx:OxW)
https://review.coreboot.org/c/coreboot/+/35523/comment/9f79e475_b9c6ba18 PS180, Line 123: printk(BIOS_DEBUG, "Function 0x%x(0x%x, 0x%x) called\n", smif, function_parameter_0, function_parameter_1); line over 96 characters