Attention is currently required from: Nico Huber, Benjamin Doron, Paul Menzel, Angel Pons.
21 comments:
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
Patch Set #180, Line 45: if (data_buffer <= (2017/ADC_3V_10BIT_GRANULARITY_MAX)) {
braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/die.c:
Patch Set #180, Line 9: if (ENV_POSTCAR) {
braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/ec.c:
Patch Set #180, Line 27: #define EC_INDEX_IO_HIGH_ADDR_PORT EC_INDEX_IO_PORT+1
Macros with complex values should be enclosed in parentheses
Patch Set #180, Line 28: #define EC_INDEX_IO_LOW_ADDR_PORT EC_INDEX_IO_PORT+2
Macros with complex values should be enclosed in parentheses
Patch Set #180, Line 29: #define EC_INDEX_IO_DATA_PORT EC_INDEX_IO_PORT+3
Macros with complex values should be enclosed in parentheses
File src/mainboard/acer/aspire_vn7_572g/hda_verb.c:
Patch Set #180, Line 73: 0x0143b000, /* Set amplifier gain on speaker: Set output, L+R amp; Unmuted; No gain */
line over 96 characters
Patch Set #180, Line 75: 0x01470740, /* Set widget control on speaker: Out enabled; VrefEn: Hi-Z (disabled) */
line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
Patch Set #180, Line 29: if (!nhlt) {
braces {} are not necessary for single statement blocks
Patch Set #180, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) {
braces {} are not necessary for single statement blocks
Patch Set #180, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) {
braces {} are not necessary for single statement blocks
Patch Set #180, Line 48: if (end_addr != start_addr) {
braces {} are not necessary for single statement blocks
Patch Set #180, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) {
braces {} are not necessary for single statement blocks
Patch Set #180, Line 97: if (dat & 1) {
braces {} are not necessary for single statement blocks
Patch Set #180, Line 120: if (!(out_data & 2)) {
braces {} are not necessary for single statement blocks
Patch Set #180, Line 130: /* Clear xHCI PM_CS[PME_Status] - RW/1C - and disable xHCI PM_CS[PME_En] */
line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Patch Set #180, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig;
need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
Patch Set #180, Line 51: switch (gnvs->unused_was_osys) {
switch and case should be at the same indent
Patch Set #180, Line 85: switch (function_parameter_0) {
switch and case should be at the same indent
Patch Set #180, Line 120: function_parameter_0 = smm_data_port &~ 0xF0;
need consistent spacing around '&' (ctx:WxO)
Patch Set #180, Line 120: function_parameter_0 = smm_data_port &~ 0xF0;
space prohibited after that '~' (ctx:OxW)
Patch Set #180, Line 123: printk(BIOS_DEBUG, "Function 0x%x(0x%x, 0x%x) called\n", smif, function_parameter_0, function_parameter_1);
line over 96 characters
To view, visit change 35523. To unsubscribe, or for help writing mail filters, visit settings.