build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39658 )
Change subject: [DO NOT MERGE] q1900m ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... File src/mainboard/asrock/q1900m/fadt.c:
https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... PS1, Line 8: void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt) "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... PS1, Line 8: void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt) "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... File src/mainboard/asrock/q1900m/gpio.c:
https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... PS1, Line 229: struct soc_gpio_config* mainboard_get_gpios(void) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... File src/mainboard/asrock/q1900m/irqroute.h:
https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... PS1, Line 8: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... PS1, Line 24: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses