build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39658 ) Change subject: [DO NOT MERGE] q1900m ...................................................................... Patch Set 1: (5 comments) https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... File src/mainboard/asrock/q1900m/fadt.c: https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... PS1, Line 8: void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt) "foo * bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... PS1, Line 8: void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt) "foo * bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... File src/mainboard/asrock/q1900m/gpio.c: https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... PS1, Line 229: struct soc_gpio_config* mainboard_get_gpios(void) "foo* bar" should be "foo *bar" https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... File src/mainboard/asrock/q1900m/irqroute.h: https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... PS1, Line 8: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses https://review.coreboot.org/c/coreboot/+/39658/1/src/mainboard/asrock/q1900m... PS1, Line 24: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/39658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id029074e4231db231a68bc92a4210dc052bba1c9 Gerrit-Change-Number: 39658 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 18 Mar 2020 22:16:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment