[coreboot-gerrit] Change in coreboot[master]: sb/intel/bd82x6x/smihandler: Fix xHCI sleep handler

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41852 )

Change subject: sb/intel/bd82x6x/smihandler: Fix xHCI sleep handler
......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/41852/7/src/southbridge/intel/bd82x... 
File src/southbridge/intel/bd82x6x/smihandler.c:

https://review.coreboot.org/c/coreboot/+/41852/7/src/southbridge/intel/bd82x... 
PS7, Line 92: sizeof(uint16_t)
> this should be `sizeof(uint32_t)`, `read32` is used below

I'd rather check if the entire xHCI MMIO window overlaps with SMRAM.

https://review.coreboot.org/c/coreboot/+/41852/7/src/southbridge/intel/bd82x... 
PS7, Line 120: pci_read_config32
Isn't there some function to read a PCI BAR?

https://review.coreboot.org/c/coreboot/+/41852/7/src/southbridge/intel/bd82x... 
PS7, Line 138: xhci_bar = pci_read_config32(PCH_XHCI_DEV, PCI_BASE_ADDRESS_0) & ~0xFUL;
This read looks pointless.