3 comments:
File src/southbridge/intel/bd82x6x/smihandler.c:
Patch Set #7, Line 92: sizeof(uint16_t)
this should be `sizeof(uint32_t)`, `read32` is used below
I'd rather check if the entire xHCI MMIO window overlaps with SMRAM.
Patch Set #7, Line 120: pci_read_config32
Isn't there some function to read a PCI BAR?
Patch Set #7, Line 138: xhci_bar = pci_read_config32(PCH_XHCI_DEV, PCI_BASE_ADDRESS_0) & ~0xFUL;
This read looks pointless.
To view, visit change 41852. To unsubscribe, or for help writing mail filters, visit settings.