Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 29:
(6 comments)
I adopted the change of the new file src/lib/ramdetect.c. I updated cbmem.c and mainboard.c to use new functions.
Boot log looks good: https://0paste.com/32642 I didn't try booting a payload.
It works well as long as it doesn't have a payload. I currently try to run coreboot.rom with the integrated LinuxBoot payload on QEMU but there seem to be problems.
https://review.coreboot.org/c/coreboot/+/33387/27//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33387/27//COMMIT_MSG@9 PS27, Line 9:
"adds a new board"
Done
https://review.coreboot.org/c/coreboot/+/33387/27/Documentation/mainboard/em... File Documentation/mainboard/emulation/qemu-aarch64.md:
https://review.coreboot.org/c/coreboot/+/33387/27/Documentation/mainboard/em... PS27, Line 37:
an
Done
https://review.coreboot.org/c/coreboot/+/33387/27/Documentation/mainboard/em... PS27, Line 37:
an
Done
https://review.coreboot.org/c/coreboot/+/33387/27/Documentation/mainboard/em... PS27, Line 39: See [Flattened uImage Tree documentation](../../lib/payloads/fit) for more details.
../../lib/payloads/fit. […]
Done
https://review.coreboot.org/c/coreboot/+/33387/27/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/cbmem.c:
https://review.coreboot.org/c/coreboot/+/33387/27/src/mainboard/emulation/qe... PS27, Line 49: 1
Is this arbitrary?
Instead of the function, I used new probe_ramsize() and probe_mb() defined at src/lib/ramdetect.c because the CL (https://review.coreboot.org/c/coreboot/+/33934) was merged.
https://review.coreboot.org/c/coreboot/+/33387/27/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33387/27/src/mainboard/emulation/qe... PS27, Line 8:
Add a comment saying that the only reason this is here is to keep the compiler happy.
Done