I adopted the change of the new file src/lib/ramdetect.c. I updated cbmem.c and mainboard.c to use new functions.

> Boot log looks good: https://0paste.com/32642
> I didn't try booting a payload.

It works well as long as it doesn't have a payload. I currently try to run coreboot.rom with the integrated LinuxBoot payload on QEMU but there seem to be problems.

View Change

6 comments:

• Commit Message:

  • Patch Set #27, Line 9:

    "adds a new board"

    Done

• File Documentation/mainboard/emulation/qemu-aarch64.md:

  • Patch Set #27, Line 37:

    an

    Done

  • Patch Set #27, Line 37:

    an

    Done

  • Patch Set #27, Line 39: See [Flattened uImage Tree documentation](../../lib/payloads/fit) for more details.

    ../../lib/payloads/fit. […]

    Done

• File src/mainboard/emulation/qemu-aarch64/cbmem.c:

  • Patch Set #27, Line 49: 1

    Is this arbitrary?

    Instead of the function, I used new probe_ramsize() and probe_mb() defined at src/lib/ramdetect.c because the CL (https://review.coreboot.org/c/coreboot/+/33934) was merged.

• File src/mainboard/emulation/qemu-aarch64/devicetree.cb:

  • Patch Set #27, Line 8:

    Add a comment saying that the only reason this is here is to keep the compiler happy.

    Done

To view, visit change 33387. To unsubscribe, or for help writing mail filters, visit settings.