[coreboot-gerrit] Change in coreboot[master]: sb/intel/bd82x6x/smihandler: Fix xHCI sleep handler

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41852 )

Change subject: sb/intel/bd82x6x/smihandler: Fix xHCI sleep handler
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41852/7/src/southbridge/intel/bd82x... 
File src/southbridge/intel/bd82x6x/smihandler.c:

https://review.coreboot.org/c/coreboot/+/41852/7/src/southbridge/intel/bd82x... 
PS7, Line 92: sizeof(uint16_t)
> I'd rather check if the entire xHCI MMIO window overlaps with SMRAM.

Do we know how big it is? There are just seemingly random offsets used below.

https://review.coreboot.org/c/coreboot/+/41852/7/src/southbridge/intel/bd82x... 
PS7, Line 138: xhci_bar = pci_read_config32(PCH_XHCI_DEV, PCI_BASE_ADDRESS_0) & ~0xFUL;
> This read looks pointless.

looks like copypasta, how could the BAR change in between? also not used after this