2 comments:
File src/southbridge/intel/bd82x6x/smihandler.c:
Patch Set #7, Line 92: sizeof(uint16_t)
I'd rather check if the entire xHCI MMIO window overlaps with SMRAM.
Do we know how big it is? There are just seemingly random offsets used below.
Patch Set #7, Line 138: xhci_bar = pci_read_config32(PCH_XHCI_DEV, PCI_BASE_ADDRESS_0) & ~0xFUL;
This read looks pointless.
looks like copypasta, how could the BAR change in between? also not used after this
To view, visit change 41852. To unsubscribe, or for help writing mail filters, visit settings.