Attention is currently required from: Raul Rangel, Martin Roth, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use "*SIZE" in fw config file as NVRAM entry
......................................................................
Patch Set 35:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/2f2eff82_f5a00f11
PS1, Line 7: *
Is "*" proper?
Done.
Keep as "*".
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/cf40281d_d8ad9bb7
PS27, Line 11: to config file. Then the required size of space will
: be allocated related to the firmware type.
Maybe add a comment as to why this is needed?
Done.
Added in the commit message.
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/484abc63_da7fff87
PS30, Line 7: Use *number in config file
If this is the reason, could we add this to the commit message?
Done
https://review.coreboot.org/c/coreboot/+/49015/comment/f0ab62ca_c2ea38c2
PS30, Line 10: XXXX_FW_TYPE_STRING *0xXXXXX
Why not just use commas to separate them?
Ack. The asterisk is not a separator. It is a mark to tell it is a entry without a filename.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae
Gerrit-Change-Number: 49015
Gerrit-PatchSet: 35
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 26 Mar 2021 11:11:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment