Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to review the following change.
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
amdfwtool: Use *number in config file as NVRAM entry
Add the entry like XXXX_FW_TYPE_STRING *0xXXXXX to config file. Then the required size of space will be allocated related to the firmware type.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 35 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/1
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index a0f3ec4..08d2817 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -213,7 +213,7 @@
# Add all the files listed in the config file POUND_SIGN=$(call strip_quotes, "#") -DEP_FILES= $(patsubst %,$(FIRMWARE_LOCATION)/%, $(shell sed -e /^$(POUND_SIGN)/d -e /^FIRMWARE_LOCATION/d $(CONFIG_AMDFW_CONFIG_FILE) | awk '{print $$2}' )) +DEP_FILES= $(patsubst %,$(FIRMWARE_LOCATION)/%, $(shell sed -e /^$(POUND_SIGN)/d -e /*/d -e /^FIRMWARE_LOCATION/d $(CONFIG_AMDFW_CONFIG_FILE) | awk '{print $$2}' ))
AMDFW_COMMON_ARGS=$(OPT_PSP_APCB_FILES) \ $(OPT_PSP_APCB_FILES_BK) \ diff --git a/src/soc/amd/stoneyridge/Makefile.inc b/src/soc/amd/stoneyridge/Makefile.inc index 969f512..f7ef699 100644 --- a/src/soc/amd/stoneyridge/Makefile.inc +++ b/src/soc/amd/stoneyridge/Makefile.inc @@ -141,7 +141,7 @@
# Add all the files listed in the config file POUND_SIGN=$(call strip_quotes, "#") -DEP_FILES= $(patsubst %,$(FIRMWARE_LOCATION)/%, $(shell sed -e /^$(POUND_SIGN)/d -e /^FIRMWARE_LOCATION/d $(CONFIG_AMDFW_CONFIG_FILE) | awk '{print $$2}' )) +DEP_FILES= $(patsubst %,$(FIRMWARE_LOCATION)/%, $(shell sed -e /^$(POUND_SIGN)/d -e /*/d -e /^FIRMWARE_LOCATION/d $(CONFIG_AMDFW_CONFIG_FILE) | awk '{print $$2}' ))
$(obj)/amdfw.rom: $(call strip_quotes, $(CONFIG_STONEYRIDGE_XHCI_FWM_FILE)) \ $(call strip_quotes, $(CONFIG_STONEYRIDGE_GEC_FWM_FILE)) \ diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.inc index 215a5a1..3d96823 100644 --- a/src/southbridge/amd/pi/hudson/Makefile.inc +++ b/src/southbridge/amd/pi/hudson/Makefile.inc @@ -110,7 +110,7 @@
# Add all the files listed in the config file POUND_SIGN=$(call strip_quotes, "#") -DEP_FILES= $(patsubst %,$(FIRMWARE_LOCATION)/%, $(shell sed -e /^$(POUND_SIGN)/d -e /^FIRMWARE_LOCATION/d $(CONFIG_AMDFW_CONFIG_FILE) | awk '{print $$2}' )) +DEP_FILES= $(patsubst %,$(FIRMWARE_LOCATION)/%, $(shell sed -e /^$(POUND_SIGN)/d -e /*/d -e /^FIRMWARE_LOCATION/d $(CONFIG_AMDFW_CONFIG_FILE) | awk '{print $$2}' ))
$(obj)/amdfw.rom: $(call strip_quotes, $(CONFIG_HUDSON_XHCI_FWM_FILE)) \ $(call strip_quotes, $(CONFIG_HUDSON_IMC_FWM_FILE)) \ diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index f167e5e..b6c9c8d 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -775,6 +775,13 @@ ctx->current = ALIGN(ctx->current + bytes, BLOB_ALIGNMENT); count++; + } else if (fw_table[i].blank_size != 0) { + pspdir->entries[count].type = fw_table[i].type; + pspdir->entries[count].subprog = fw_table[i].subprog; + pspdir->entries[count].rsvd = 0; + pspdir->entries[count].size = (uint32_t)fw_table[i].blank_size; + pspdir->entries[count].addr = RUN_CURRENT(*ctx); + count++; } else { /* This APU doesn't have this firmware. */ } @@ -1018,11 +1025,15 @@ fw_table[i].type == AMD_BIOS_APCB_BK) ctx->current = ALIGN( ctx->current, ERASE_ALIGNMENT); - bytes = copy_blob(BUFF_CURRENT(*ctx), - fw_table[i].filename, BUFF_ROOM(*ctx)); - if (bytes <= 0) { - free(ctx->rom); - exit(1); + if (fw_table[i].filename != NULL) { + bytes = copy_blob(BUFF_CURRENT(*ctx), + fw_table[i].filename, BUFF_ROOM(*ctx)); + if (bytes <= 0) { + free(ctx->rom); + exit(1); + } + } else if (fw_table[i].blank_size != 0){ + bytes = fw_table[i].blank_size; }
biosdir->entries[count].size = (uint32_t)bytes; diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h index 6ae4675..beaa360 100644 --- a/util/amdfwtool/amdfwtool.h +++ b/util/amdfwtool/amdfwtool.h @@ -109,6 +109,7 @@ uint8_t subprog; int level; uint64_t other; + uint32_t blank_size; } amd_fw_entry;
typedef struct _amd_cb_config { diff --git a/util/amdfwtool/data_parse.c b/util/amdfwtool/data_parse.c index 017c689..de31242 100644 --- a/util/amdfwtool/data_parse.c +++ b/util/amdfwtool/data_parse.c @@ -254,7 +254,10 @@ while (psp_tableptr->type != AMD_FW_INVALID) { /* instance are not used in PSP table */ if (psp_tableptr->type == fw_type && psp_tableptr->subprog == subprog) { - psp_tableptr->filename = filename; + if (filename[0] == '*') + psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); + else + psp_tableptr->filename = filename; break; } psp_tableptr++; @@ -330,7 +333,10 @@ if (bhd_tableptr->type == fw_type && bhd_tableptr->subpr == subprog && bhd_tableptr->inst == instance) { - bhd_tableptr->filename = filename; + if (filename[0] == '*') + bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); + else + bhd_tableptr->filename = filename; break; } bhd_tableptr++; @@ -440,9 +446,13 @@ continue; } else { path_filename = malloc(MAX_LINE_SIZE); - strcpy(path_filename, dir); - strcat(path_filename, "/"); - strcat(path_filename, &(oneline[match[2].rm_so])); + if (oneline[match[2].rm_so] == '*') { + strcpy(path_filename, &(oneline[match[2].rm_so])); + } else { + strcpy(path_filename, dir); + strcat(path_filename, "/"); + strcat(path_filename, &(oneline[match[2].rm_so])); + }
if (find_register_fw_filename_psp_dir( &(oneline[match[1].rm_so]),
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49015/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/1//COMMIT_MSG@7 PS1, Line 7: * Is "*" proper?
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/49015/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/49015/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1035: } else if (fw_table[i].blank_size != 0){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/49015/1/util/amdfwtool/data_parse.c File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/1/util/amdfwtool/data_parse.c... PS1, Line 258: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/1/util/amdfwtool/data_parse.c... PS1, Line 337: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#2).
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
amdfwtool: Use *number in config file as NVRAM entry
Add the entry like XXXX_FW_TYPE_STRING *0xXXXXX to config file. Then the required size of space will be allocated related to the firmware type.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 38 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/49015/2/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/49015/2/util/amdfwtool/amdfwtool.c@... PS2, Line 1035: } else if (fw_table[i].blank_size != 0){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/49015/2/util/amdfwtool/data_parse.c File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/2/util/amdfwtool/data_parse.c... PS2, Line 258: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/2/util/amdfwtool/data_parse.c... PS2, Line 337: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#3).
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
amdfwtool: Use *number in config file as NVRAM entry
Add the entry like XXXX_FW_TYPE_STRING *0xXXXXX to config file. Then the required size of space will be allocated related to the firmware type.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 38 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49015/3/util/amdfwtool/data_parse.c File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/3/util/amdfwtool/data_parse.c... PS3, Line 258: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/3/util/amdfwtool/data_parse.c... PS3, Line 337: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 4:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/1b774388_91835706 PS4, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/6625d6be_fa5ec8b8 PS4, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 5:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/283be201_4d38a1d9 PS5, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/bc12bd8e_da4a3f78 PS5, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 6:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/491c49ae_e3712cbb PS6, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/8dbba10e_c17b5e1f PS6, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 7:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/e679fbeb_400b0cd1 PS7, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/29062eb0_0d509e61 PS7, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 8:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/62c037ca_cd569eb3 PS8, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/42213de4_d3c40218 PS8, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 9:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/34c51b72_88d9ad46 PS9, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/1d406594_c76557f3 PS9, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 10:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/c31daec8_f613cdec PS10, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/b22bb263_0b209863 PS10, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 11:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/57c52f77_5129e283 PS11, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/5f7ec4a8_ec2427e8 PS11, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 12:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/c81ec2a1_86dc9dad PS12, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/1f40ba9c_a0e58476 PS12, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 13:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/38c0afd8_6b6c996d PS13, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/64c2fbab_a70825fb PS13, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 14:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/2b36b942_b16cf8cb PS14, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/f9b2f1aa_2118c6a7 PS14, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 15:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/8fcbb0d5_10423959 PS15, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/44cb4f3d_bf67cee5 PS15, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 16:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/42c8debc_007e1be6 PS16, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/c4bf5e50_6ad0f5dc PS16, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 17:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/1621c1de_b0b6a244 PS17, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/55faacce_00853fea PS17, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 18:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/c1263eb8_86f84acf PS18, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/2ca26bca_39047d5f PS18, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 19:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/d76b0da9_6307b3be PS19, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/9b416ef0_70e2f03d PS19, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Attention is currently required from: Bao Zheng. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 20:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/a5b8e368_82e9aff4 PS20, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/35f94c20_cd9af7c8 PS20, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#22).
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
amdfwtool: Use *number in config file as NVRAM entry
Add the entry like XXXX_FW_TYPE_STRING *0xXXXXX to config file. Then the required size of space will be allocated related to the firmware type.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 38 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/22
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 22:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/b10753cc_156b3e58 PS22, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/b703e404_df1ea14f PS22, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#23).
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
amdfwtool: Use *number in config file as NVRAM entry
Add the entry like XXXX_FW_TYPE_STRING *0xXXXXX to config file. Then the required size of space will be allocated related to the firmware type.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 38 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/23
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 23:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/3f7c48f1_e4a3d2c5 PS23, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/6a77f191_98beb719 PS23, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#27).
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
amdfwtool: Use *number in config file as NVRAM entry
Add the entry like XXXX_FW_TYPE_STRING *0xXXXXX to config file. Then the required size of space will be allocated related to the firmware type.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 38 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/27
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 27:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/70cc1442_83d0027c PS27, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/0900087d_b5ddb89e PS27, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Attention is currently required from: Bao Zheng. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 27:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/c96cb46d_ce193573 PS27, Line 11: to config file. Then the required size of space will : be allocated related to the firmware type. Maybe add a comment as to why this is needed?
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 28:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/789a88a9_b14bbd73 PS28, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/675fb326_b0c34bf1 PS28, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Attention is currently required from: Raul Rangel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 29:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/6df8dc49_3a6b2d99 PS29, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/a4e2d72f_e26e1d62 PS29, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Attention is currently required from: Raul Rangel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 30:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/6fd77613_6790d908 PS30, Line 259: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/ef4b1d52_dd04b35f PS30, Line 338: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Attention is currently required from: Bao Zheng, Raul Rangel. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 30:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/8543ab60_68c01aff PS30, Line 7: Use *number in config file Why is this needed? What's the purpose?
https://review.coreboot.org/c/coreboot/+/49015/comment/a56d5e54_89ef01dd PS30, Line 10: XXXX_FW_TYPE_STRING *0xXXXXX Why not just use commas to separate them?
https://review.coreboot.org/c/coreboot/+/49015/comment/1fa5ed63_e6113aec PS30, Line 13: Add BUG= and TEST=?
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/6c801859_0d464509 PS30, Line 70: else if (strcmp(fw_name, "AMD_PUBKEY_FILE") == 0) { : fw_type = AMD_FW_PSP_PUBKEY; : subprog = 0; Nit: Not related to this patch, but it seems like the simple matches like this could be put into a data structure instead of having quite so many else if statements. Maybe look at that for a future patch?
https://review.coreboot.org/c/coreboot/+/49015/comment/81e130d2_6b0c960d PS30, Line 254: if These if statements are getting deep. Maybe break them out to separate functions?
https://review.coreboot.org/c/coreboot/+/49015/comment/06d9f525_a3caaa14 PS30, Line 467: if Nit: Obviously not this patch, but 6 levels of if and while statements is pretty deep. Could this be refactored into a separate function? Again, maybe a future patch?
Attention is currently required from: Bao Zheng, Raul Rangel, Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 30:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/779aabb2_d218defa PS30, Line 7: Use *number in config file
Why is this needed? What's the purpose?
the purpose is to be able to add empty regions to amdfw without having to have empty blobs with the right size in the blobs repo. so in the fw.cfg file those can be used instead of file names pointing to files in amd_blobs. i think the psp wants to have some empty region for something, but i might misremember; didn't get around to have a close look
Attention is currently required from: Bao Zheng, Raul Rangel, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 30:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/b35bb943_f2bc595c PS30, Line 7: Use *number in config file
the purpose is to be able to add empty regions to amdfw without having to have empty blobs with the […]
If this is the reason, could we add this to the commit message?
Attention is currently required from: Bao Zheng, Raul Rangel, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#31).
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
amdfwtool: Use *number in config file as NVRAM entry
Add the entry like XXXX_FW_TYPE_STRING *0xXXXXX to config file. Then the required size of space will be allocated related to the firmware type. This change is required by the deleted TODO comment.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 38 insertions(+), 43 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/31
Attention is currently required from: Raul Rangel, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 31:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/bc8d4504_3620c362 PS31, Line 262: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/086a2e1f_bb65153b PS31, Line 341: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Attention is currently required from: Raul Rangel, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#32).
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
amdfwtool: Use *number in config file as NVRAM entry
Add the entry like XXXX_FW_TYPE_STRING *0xXXXXX to config file. Then the required size of space will be allocated related to the firmware type. This change is required by the deleted TODO comment.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 40 insertions(+), 43 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/32
Attention is currently required from: Raul Rangel, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 32:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/94c2bdbd_5b4a0b07 PS32, Line 262: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/91697fcb_763baf22 PS32, Line 341: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Attention is currently required from: Raul Rangel, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#33).
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
amdfwtool: Use *number in config file as NVRAM entry
Sometimes the PSP or BIOS entry is all 0xFF. It doesn't make any sense to integrate a dummy binary. Only the entry type and size matter. So, add the entry like --------------- XXXX_FW_TYPE_STRING *0xXXXXX --------------- to fw config file. The asterisk is the prefix to detect if the current entry specifies size instead of filename. Then the required size of space related to the firmware type will be reserved. The TODO in the comment is completed and removed.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 41 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/33
Attention is currently required from: Raul Rangel, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 33:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/5b2d030f_7ff1336d PS33, Line 262: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/8801009b_fa57ecde PS33, Line 341: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Attention is currently required from: Raul Rangel, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#34).
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
amdfwtool: Use *number in config file as NVRAM entry
Sometimes the PSP or BIOS entry is all 0xFF. It doesn't make any sense to integrate a dummy binary. Only the entry type and size matter. So, add the entry like --------------- XXXX_FW_TYPE_STRING *0xXXXXX --------------- to fw config file. The asterisk is the prefix to detect if the current entry specifies size instead of filename. Then the required size of space related to the firmware type will be reserved. The TODO in the comment is completed and removed.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 41 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/34
Attention is currently required from: Raul Rangel, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use *number in config file as NVRAM entry ......................................................................
Patch Set 34:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/892a1517_fb378d65 PS34, Line 262: psp_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/49015/comment/628f3481_361a4776 PS34, Line 341: bhd_tableptr->blank_size = strtoull(&filename[1], NULL, 16); line over 96 characters
Attention is currently required from: Raul Rangel, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#35).
Change subject: amdfwtool: Use "*SIZE" in fw config file as NVRAM entry ......................................................................
amdfwtool: Use "*SIZE" in fw config file as NVRAM entry
Sometimes the PSP or BIOS entry is all 0xFF. It doesn't make any sense to integrate a dummy binary. Only the entry type and size matter. So, add the entry like --------------- XXXX_FW_TYPE_STRING *0xXXXXX --------------- to fw config file. The asterisk is the prefix to detect if the current entry specifies size instead of filename. Then the required size of space related to the firmware type will be reserved. The TODO in the comment is completed and removed.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 41 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/35
Attention is currently required from: Raul Rangel, Martin Roth, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use "*SIZE" in fw config file as NVRAM entry ......................................................................
Patch Set 35:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/2f2eff82_f5a00f11 PS1, Line 7: *
Is "*" proper?
Done. Keep as "*".
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/cf40281d_d8ad9bb7 PS27, Line 11: to config file. Then the required size of space will : be allocated related to the firmware type.
Maybe add a comment as to why this is needed?
Done. Added in the commit message.
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/484abc63_da7fff87 PS30, Line 7: Use *number in config file
If this is the reason, could we add this to the commit message?
Done
https://review.coreboot.org/c/coreboot/+/49015/comment/f0ab62ca_c2ea38c2 PS30, Line 10: XXXX_FW_TYPE_STRING *0xXXXXX
Why not just use commas to separate them?
Ack. The asterisk is not a separator. It is a mark to tell it is a entry without a filename.
Attention is currently required from: Raul Rangel, Martin Roth, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#36).
Change subject: amdfwtool: Use "*SIZE" in fw config file as NVRAM entry ......................................................................
amdfwtool: Use "*SIZE" in fw config file as NVRAM entry
Sometimes the PSP or BIOS entry is all 0xFF. It doesn't make any sense to integrate a dummy binary. Only the entry type and size matter. So, add the entry like --------------- XXXX_FW_TYPE_STRING *0xXXXXX --------------- to fw config file. The asterisk is the prefix to detect if the current entry specifies size instead of filename. Then the required size of space related to the firmware type will be reserved. The TODO in the comment is completed and removed.
TEST=Bilby. FTPM code can run.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 41 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/36
Attention is currently required from: Raul Rangel, Martin Roth, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use "*SIZE" in fw config file as NVRAM entry ......................................................................
Patch Set 36:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49015/comment/0d7e2076_5263bffb PS30, Line 13:
Add BUG= and TEST=?
Done. Add TEST= and no BUG=.
Attention is currently required from: Raul Rangel, Martin Roth, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#37).
Change subject: amdfwtool: Use "*SIZE" in fw config file as NVRAM entry ......................................................................
amdfwtool: Use "*SIZE" in fw config file as NVRAM entry
Sometimes the PSP or BIOS entry is all 0xFF. It doesn't make any sense to integrate a dummy binary. Only the entry type and size matter. So, add the entry like --------------- XXXX_FW_TYPE_STRING *0xXXXXX --------------- to fw config file. The asterisk is the prefix to detect if the current entry specifies size instead of a filename. Then the required size of space related to the firmware type will be reserved. The TODO comment is completed and removed.
TEST=Bilby. FTPM code can run.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 41 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/37
Attention is currently required from: Raul Rangel, Martin Roth, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Patrick Georgi, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49015
to look at the new patch set (#38).
Change subject: amdfwtool: Use "*SIZE" in fw config file as NVRAM entry ......................................................................
amdfwtool: Use "*SIZE" in fw config file as NVRAM entry
Sometimes the PSP or BIOS entry is all 0xFF. It doesn't make any sense to integrate a dummy binary. Only the entry type and size matter. So, add the entry like --------------- XXXX_FW_TYPE_STRING *0xXXXXX --------------- to fw config file. The asterisk is the prefix to detect if the current entry specifies size instead of a filename. Then the required size of space related to the firmware type will be reserved. The TODO comment is completed and removed.
TEST=Bilby. FTPM code can run.
Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 6 files changed, 43 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/49015/38
Attention is currently required from: Raul Rangel, Martin Roth, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use "*SIZE" in fw config file as NVRAM entry ......................................................................
Patch Set 38:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/49015/comment/5b36e990_f6559659 PS30, Line 254: if
These if statements are getting deep. […]
Done
Attention is currently required from: Raul Rangel, Martin Roth, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49015 )
Change subject: amdfwtool: Use "*SIZE" in fw config file as NVRAM entry ......................................................................
Patch Set 38:
(1 comment)
Patchset:
PS38: this need to be abandoned.
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/49015?usp=email )
Change subject: amdfwtool: Use "*SIZE" in fw config file as NVRAM entry ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Bao Zheng (Code Review) -
build bot (Jenkins) (Code Review)
-
Felix Held (Code Review)
-
Martin L Roth (Code Review)
-
Martin Roth (Code Review)