Attention is currently required from: Raul Rangel, Martin Roth, Felix Held.
View Change
4 comments:
Commit Message:
Commit Message:
Commit Message:
Patch Set #30, Line 7: Use *number in config file
If this is the reason, could we add this to the commit message?
Done
Patch Set #30, Line 10: XXXX_FW_TYPE_STRING *0xXXXXX
Why not just use commas to separate them?
Ack. The asterisk is not a separator. It is a mark to tell it is a entry without a filename.
To view, visit change 49015. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98c94b4087f8a174f7d5753a30695a10f1b796ae
Gerrit-Change-Number: 49015
Gerrit-PatchSet: 35
Gerrit-Owner: Bao Zheng <fishbaozi@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Fri, 26 Mar 2021 11:11:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng <fishbaozi@gmail.com>
Comment-In-Reply-To: Martin Roth <martinroth@google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: comment