build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32531 )
Change subject: Add support for the 51nb X210 ......................................................................
Patch Set 1:
(31 comments)
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c File src/ec/51nb/51nb.c:
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@23 PS1, Line 23: /* Enable function 5 (PS/2 AUX) */ code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@24 PS1, Line 24: outb(LDN_SEL, SETUP_COMMAND); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@24 PS1, Line 24: outb(LDN_SEL, SETUP_COMMAND); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@25 PS1, Line 25: outb(0x05, SETUP_DATA); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@25 PS1, Line 25: outb(0x05, SETUP_DATA); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@26 PS1, Line 26: outb(LDN_ENABLE, SETUP_COMMAND); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@26 PS1, Line 26: outb(LDN_ENABLE, SETUP_COMMAND); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@27 PS1, Line 27: outb(0x01, SETUP_DATA); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@27 PS1, Line 27: outb(0x01, SETUP_DATA); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@29 PS1, Line 29: /* Enable function 6 (PS/2 KB) */ code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@30 PS1, Line 30: outb(LDN_SEL, SETUP_COMMAND); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@30 PS1, Line 30: outb(LDN_SEL, SETUP_COMMAND); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@31 PS1, Line 31: outb(0x06, SETUP_DATA); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@31 PS1, Line 31: outb(0x06, SETUP_DATA); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@32 PS1, Line 32: outb(LDN_ENABLE, SETUP_COMMAND); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@32 PS1, Line 32: outb(LDN_ENABLE, SETUP_COMMAND); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@33 PS1, Line 33: outb(0x01, SETUP_DATA); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@33 PS1, Line 33: outb(0x01, SETUP_DATA); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@35 PS1, Line 35: /* Enable funcion 17 (EC) */ 'funcion' may be misspelled - perhaps 'function'?
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@35 PS1, Line 35: /* Enable funcion 17 (EC) */ code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@36 PS1, Line 36: outb(LDN_SEL, SETUP_COMMAND); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@36 PS1, Line 36: outb(LDN_SEL, SETUP_COMMAND); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@37 PS1, Line 37: outb(0x11, SETUP_DATA); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@37 PS1, Line 37: outb(0x11, SETUP_DATA); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@38 PS1, Line 38: outb(LDN_ENABLE, SETUP_COMMAND); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@38 PS1, Line 38: outb(LDN_ENABLE, SETUP_COMMAND); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@39 PS1, Line 39: outb(0x01, SETUP_DATA); code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/src/ec/51nb/51nb.c@39 PS1, Line 39: outb(0x01, SETUP_DATA); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32531/1/src/mainboard/51nb/x210/mainboard.c File src/mainboard/51nb/x210/mainboard.c:
https://review.coreboot.org/#/c/32531/1/src/mainboard/51nb/x210/mainboard.c@... PS1, Line 57: /* Route 0x4e/4f to LPC */ code indent should use tabs where possible
https://review.coreboot.org/#/c/32531/1/util/51nb/51nb_ec_insert.c File util/51nb/51nb_ec_insert.c:
https://review.coreboot.org/#/c/32531/1/util/51nb/51nb_ec_insert.c@65 PS1, Line 65: if (fw == NULL) { suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/32531/1/util/51nb/51nb_ec_insert.c@93 PS1, Line 93: while (fread(&c, 1, 1, fw) == 1) { braces {} are not necessary for single statement blocks