31 comments:
Patch Set #1, Line 23: /* Enable function 5 (PS/2 AUX) */
code indent should use tabs where possible
Patch Set #1, Line 24: outb(LDN_SEL, SETUP_COMMAND);
code indent should use tabs where possible
Patch Set #1, Line 24: outb(LDN_SEL, SETUP_COMMAND);
please, no spaces at the start of a line
Patch Set #1, Line 25: outb(0x05, SETUP_DATA);
code indent should use tabs where possible
Patch Set #1, Line 25: outb(0x05, SETUP_DATA);
please, no spaces at the start of a line
Patch Set #1, Line 26: outb(LDN_ENABLE, SETUP_COMMAND);
code indent should use tabs where possible
Patch Set #1, Line 26: outb(LDN_ENABLE, SETUP_COMMAND);
please, no spaces at the start of a line
Patch Set #1, Line 27: outb(0x01, SETUP_DATA);
code indent should use tabs where possible
Patch Set #1, Line 27: outb(0x01, SETUP_DATA);
please, no spaces at the start of a line
Patch Set #1, Line 29: /* Enable function 6 (PS/2 KB) */
code indent should use tabs where possible
Patch Set #1, Line 30: outb(LDN_SEL, SETUP_COMMAND);
code indent should use tabs where possible
Patch Set #1, Line 30: outb(LDN_SEL, SETUP_COMMAND);
please, no spaces at the start of a line
Patch Set #1, Line 31: outb(0x06, SETUP_DATA);
code indent should use tabs where possible
Patch Set #1, Line 31: outb(0x06, SETUP_DATA);
please, no spaces at the start of a line
Patch Set #1, Line 32: outb(LDN_ENABLE, SETUP_COMMAND);
code indent should use tabs where possible
Patch Set #1, Line 32: outb(LDN_ENABLE, SETUP_COMMAND);
please, no spaces at the start of a line
Patch Set #1, Line 33: outb(0x01, SETUP_DATA);
code indent should use tabs where possible
Patch Set #1, Line 33: outb(0x01, SETUP_DATA);
please, no spaces at the start of a line
Patch Set #1, Line 35: /* Enable funcion 17 (EC) */
'funcion' may be misspelled - perhaps 'function'?
Patch Set #1, Line 35: /* Enable funcion 17 (EC) */
code indent should use tabs where possible
Patch Set #1, Line 36: outb(LDN_SEL, SETUP_COMMAND);
code indent should use tabs where possible
Patch Set #1, Line 36: outb(LDN_SEL, SETUP_COMMAND);
please, no spaces at the start of a line
Patch Set #1, Line 37: outb(0x11, SETUP_DATA);
code indent should use tabs where possible
Patch Set #1, Line 37: outb(0x11, SETUP_DATA);
please, no spaces at the start of a line
Patch Set #1, Line 38: outb(LDN_ENABLE, SETUP_COMMAND);
code indent should use tabs where possible
Patch Set #1, Line 38: outb(LDN_ENABLE, SETUP_COMMAND);
please, no spaces at the start of a line
Patch Set #1, Line 39: outb(0x01, SETUP_DATA);
code indent should use tabs where possible
Patch Set #1, Line 39: outb(0x01, SETUP_DATA);
please, no spaces at the start of a line
File src/mainboard/51nb/x210/mainboard.c:
Patch Set #1, Line 57: /* Route 0x4e/4f to LPC */
code indent should use tabs where possible
File util/51nb/51nb_ec_insert.c:
Patch Set #1, Line 65: if (fw == NULL) {
suspect code indent for conditional statements (8, 24)
Patch Set #1, Line 93: while (fread(&c, 1, 1, fw) == 1) {
braces {} are not necessary for single statement blocks
To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.