Attention is currently required from: Ravi kumar, Paul Menzel, Julius Werner, mturney mturney. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47074 )
Change subject: herobrine: SoC makefile blob support ......................................................................
Patch Set 38:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/47074/comment/d6ceaf2e_03650862 PS1, Line 7: herobrine
Is that the mainboard name? The change-set is for the SoC, so please use that prefix.
Ack
https://review.coreboot.org/c/coreboot/+/47074/comment/aa78e1d1_d1b37e19 PS1, Line 7: SoC makefile blob support
Please make it a statement: […]
All these changes are squashed into below qupv3_fw relevant changes https://review.coreboot.org/c/coreboot/+/47525
https://review.coreboot.org/c/coreboot/+/47074/comment/8c4f82f8_4a742214 PS1, Line 9: will includes
are included
Ack
https://review.coreboot.org/c/coreboot/+/47074/comment/8e647683_5d39816d PS1, Line 9: Following blobs will includes with SoC makefile:
Please remove the indentation (probably copied from `git show` output for some reason).
Ack
https://review.coreboot.org/c/coreboot/+/47074/comment/b47f8387_5144af38 PS1, Line 10: QCSEC
I do not see that in the diff of the Makefile.
Ack
https://review.coreboot.org/c/coreboot/+/47074/comment/6a632c9c_b6adba98 PS1, Line 11: * QUPV3FW
Please describe boths blobs in the commit message.
Ack