Attention is currently required from: Ravi kumar, Paul Menzel, Julius Werner, mturney mturney.
View Change
6 comments:
Commit Message:
Patch Set #1, Line 7: herobrine
Is that the mainboard name? The change-set is for the SoC, so please use that prefix.
Ack
Patch Set #1, Line 7: SoC makefile blob support
Please make it a statement: […]
All these changes are squashed into below qupv3_fw relevant changes
https://review.coreboot.org/c/coreboot/+/47525
Patch Set #1, Line 9: will includes
are included
Ack
Patch Set #1, Line 9: Following blobs will includes with SoC makefile:
Please remove the indentation (probably copied from `git show` output for some reason).
Ack
Patch Set #1, Line 10: QCSEC
I do not see that in the diff of the Makefile.
Ack
Patch Set #1, Line 11: * QUPV3FW
Please describe boths blobs in the commit message.
Ack
To view, visit change 47074. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic76af29440a6ef3a458381d63a819f5a1843e111
Gerrit-Change-Number: 47074
Gerrit-PatchSet: 38
Gerrit-Owner: Ravi kumar <rbokka@codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney@codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka@qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka@codeaurora.org>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Attention: mturney mturney <mturney@codeaurora.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:47:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: comment