Change in coreboot[master]: herobrine: SoC makefile blob support

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Ravi kumar (Code Review)

1 Nov 2020 1 Nov '20

9:15 p.m.

Ravi kumar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47074 )

Change subject: herobrine: SoC makefile blob support ......................................................................

herobrine: SoC makefile blob support

Following blobs will includes with SoC makefile: * QCSEC * QUPV3FW

Change-Id: Ic76af29440a6ef3a458381d63a819f5a1843e111 Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org --- M src/soc/qualcomm/sc7280/Makefile.inc 1 file changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/47074/1

diff --git a/src/soc/qualcomm/sc7280/Makefile.inc b/src/soc/qualcomm/sc7280/Makefile.inc index 6d07629..d6f8d29 100644 --- a/src/soc/qualcomm/sc7280/Makefile.inc +++ b/src/soc/qualcomm/sc7280/Makefile.inc @@ -44,4 +44,28 @@ @util/qualcomm/qgpt.py $(objcbfs)/merged_bb_qcsec.mbn \ $(objcbfs)/bootblock.bin

+################################################################################ +UART_FW_FILE := $(SC7280_BLOB)/qup_fw/uart_fw.bin +UART_FW_CBFS := $(CONFIG_CBFS_PREFIX)/uart_fw +$(UART_FW_CBFS)-file := $(UART_FW_FILE) +$(UART_FW_CBFS)-type := raw +$(UART_FW_CBFS)-compression := none +cbfs-files-y += $(UART_FW_CBFS) + +################################################################################ +SPI_FW_FILE := $(SC7280_BLOB)/qup_fw/spi_fw.bin +SPI_FW_CBFS := $(CONFIG_CBFS_PREFIX)/spi_fw +$(SPI_FW_CBFS)-file := $(SPI_FW_FILE) +$(SPI_FW_CBFS)-type := raw +$(SPI_FW_CBFS)-compression := none +cbfs-files-y += $(SPI_FW_CBFS) + +################################################################################ +I2C_FW_FILE := $(SC7280_BLOB)/qup_fw/i2c_fw.bin +I2C_FW_CBFS := $(CONFIG_CBFS_PREFIX)/i2c_fw +$(I2C_FW_CBFS)-file := $(I2C_FW_FILE) +$(I2C_FW_CBFS)-type := raw +$(I2C_FW_CBFS)-compression := none +cbfs-files-y += $(I2C_FW_CBFS) + endif

Attachments:

attachment.htm (text/html — 4.3 KB)

Show replies by date

Paul Menzel (Code Review)

1 Nov 1 Nov

10:39 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47074 )

Change subject: herobrine: SoC makefile blob support ......................................................................

Patch Set 1:

(4 comments)

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG@9 PS1, Line 9: Following blobs will includes with SoC makefile: Please remove the indentation (probably copied from `git show` output for some reason).

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG@9 PS1, Line 9: will includes are included

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG@10 PS1, Line 10: QCSEC I do not see that in the diff of the Makefile.

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG@11 PS1, Line 11: * QUPV3FW Please describe boths blobs in the commit message.

Paul Menzel (Code Review)

10:40 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47074 )

Change subject: herobrine: SoC makefile blob support ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG@7 PS1, Line 7: herobrine Is that the mainboard name? The change-set is for the SoC, so please use that prefix.

Paul Menzel (Code Review)

10:52 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47074 )

Change subject: herobrine: SoC makefile blob support ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG@7 PS1, Line 7: SoC makefile blob support Please make it a statement:

...

Add blobs to CBFS

Ravi kumar (Code Review)

18 Mar 18 Mar

3:08 p.m.

Attention is currently required from: mturney mturney. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47074

to look at the new patch set (#18).

Change subject: herobrine: SoC makefile blob support ......................................................................

herobrine: SoC makefile blob support

Following blobs will includes with SoC makefile: * QCSEC * QUPV3FW

Change-Id: Ic76af29440a6ef3a458381d63a819f5a1843e111 Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org --- M src/soc/qualcomm/sc7280/Makefile.inc 1 file changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/47074/18

Ravi kumar (Code Review)

3:25 p.m.

Attention is currently required from: mturney mturney. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47074

to look at the new patch set (#19).

Change subject: herobrine: SoC makefile blob support ......................................................................

herobrine: SoC makefile blob support

Following blobs will includes with SoC makefile: * QCSEC * QUPV3FW

Change-Id: Ic76af29440a6ef3a458381d63a819f5a1843e111 Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org --- M src/soc/qualcomm/sc7280/Makefile.inc 1 file changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/47074/19

Ravi kumar (Code Review)

31 Mar 31 Mar

7:42 a.m.

Attention is currently required from: Shelley Chen, Julius Werner, mturney mturney. Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner, mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47074

to look at the new patch set (#34).

Change subject: herobrine: SoC makefile blob support ......................................................................

herobrine: SoC makefile blob support

Following blobs will includes with SoC makefile: * QCSEC * QUPV3FW

Change-Id: Ic76af29440a6ef3a458381d63a819f5a1843e111 Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org --- M src/soc/qualcomm/sc7280/Makefile.inc 1 file changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/47074/34

-- To view, visit https://review.coreboot.org/c/coreboot/+/47074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic76af29440a6ef3a458381d63a819f5a1843e111 Gerrit-Change-Number: 47074 Gerrit-PatchSet: 34 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Shelley Chen (Code Review)

28 Apr 28 Apr

12:46 a.m.

Attention is currently required from: Ravi kumar, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47074 )

Change subject: herobrine: SoC makefile blob support ......................................................................

Patch Set 38: Code-Review+2

(1 comment)

Patchset:

PS38: Nit: Let's add the general umbrella bug if we have no specific bug# to attach:

BUG=b:182963902 TEST= (how you verified)

-- To view, visit https://review.coreboot.org/c/coreboot/+/47074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic76af29440a6ef3a458381d63a819f5a1843e111 Gerrit-Change-Number: 47074 Gerrit-PatchSet: 38 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-Comment-Date: Tue, 27 Apr 2021 22:46:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

12:50 a.m.

Attention is currently required from: Ravi kumar, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47074 )

Change subject: herobrine: SoC makefile blob support ......................................................................

Patch Set 38:

(1 comment)

Patchset:

PS38:

...

Nit: Let's add the general umbrella bug if we have no specific bug# to attach: […]

Oh let's also change title to sc7280: SoC makefile blob support

so it's consistent with the other CLs

-- To view, visit https://review.coreboot.org/c/coreboot/+/47074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic76af29440a6ef3a458381d63a819f5a1843e111 Gerrit-Change-Number: 47074 Gerrit-PatchSet: 38 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-Comment-Date: Tue, 27 Apr 2021 22:50:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen shchen@google.com Gerrit-MessageType: comment

Shelley Chen (Code Review)

12:51 a.m.

Attention is currently required from: Ravi kumar, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47074 )

Change subject: herobrine: SoC makefile blob support ......................................................................

Patch Set 38: -Code-Review

(1 comment)

Patchset:

PS38: Sorry, I'll +2 after jenkins verifies :).

-- To view, visit https://review.coreboot.org/c/coreboot/+/47074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic76af29440a6ef3a458381d63a819f5a1843e111 Gerrit-Change-Number: 47074 Gerrit-PatchSet: 38 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-Comment-Date: Tue, 27 Apr 2021 22:51:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ravi Kumar Bokka (Code Review)

7:47 p.m.

Attention is currently required from: Ravi kumar, Paul Menzel, Julius Werner, mturney mturney. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47074 )

Change subject: herobrine: SoC makefile blob support ......................................................................

Patch Set 38:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/47074/comment/d6ceaf2e_03650862 PS1, Line 7: herobrine

...

Is that the mainboard name? The change-set is for the SoC, so please use that prefix.

Ack

https://review.coreboot.org/c/coreboot/+/47074/comment/aa78e1d1_d1b37e19 PS1, Line 7: SoC makefile blob support

...

Please make it a statement: […]

All these changes are squashed into below qupv3_fw relevant changes https://review.coreboot.org/c/coreboot/+/47525

https://review.coreboot.org/c/coreboot/+/47074/comment/8c4f82f8_4a742214 PS1, Line 9: will includes

...

are included

Ack

https://review.coreboot.org/c/coreboot/+/47074/comment/8e647683_5d39816d PS1, Line 9: Following blobs will includes with SoC makefile:

...

Please remove the indentation (probably copied from `git show` output for some reason).

Ack

https://review.coreboot.org/c/coreboot/+/47074/comment/b47f8387_5144af38 PS1, Line 10: QCSEC

...

I do not see that in the diff of the Makefile.

Ack

https://review.coreboot.org/c/coreboot/+/47074/comment/6a632c9c_b6adba98 PS1, Line 11: * QUPV3FW

...

Please describe boths blobs in the commit message.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/47074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic76af29440a6ef3a458381d63a819f5a1843e111 Gerrit-Change-Number: 47074 Gerrit-PatchSet: 38 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-Comment-Date: Wed, 28 Apr 2021 17:47:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: comment

Ravi Kumar Bokka (Code Review)

22 Mar 22 Mar

9:39 a.m.

Ravi Kumar Bokka has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47074 )

Change subject: herobrine: SoC makefile blob support ......................................................................

Abandoned

abondon these changes

777

days inactive

1283

days old

coreboot-gerrit@coreboot.org

11 comments

4 participants

tags (0)

participants (4)

Paul Menzel (Code Review)
Ravi kumar (Code Review)
Ravi Kumar Bokka (Code Review)
Shelley Chen (Code Review)